New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760296 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: 2017-08-31
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

Bump the min supported version of ForceBrowserSignin

Project Member Reported by zmin@chromium.org, Aug 29 2017

Issue description

Bump the version to 62 as the launch review has not been finished yet.
 

Comment 1 by zmin@chromium.org, Aug 29 2017

Launch review issue: crbug.com/751230 (Googler only)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3292acff755b0d0e3486451e832ea50d49a29bef

commit 3292acff755b0d0e3486451e832ea50d49a29bef
Author: Owen Min <zmin@chromium.org>
Date: Wed Aug 30 16:57:59 2017

Bump the minimum supported version of ForceBrowserSignin policy to 62.

Bug:  760296 
Change-Id: I008c76a95e1140a453d7750c1aeb3c45a09393d1
Reviewed-on: https://chromium-review.googlesource.com/641780
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498501}
[modify] https://crrev.com/3292acff755b0d0e3486451e832ea50d49a29bef/components/policy/resources/policy_templates.json

Comment 3 by zmin@chromium.org, Aug 30 2017

Labels: Merge-Request-61
Hi, 

This CL needs to be merged into M61.

It raises minimum support version of force-sign-in feature as it's still under launch review. So that this feature will remains in Beta/Dev.
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 30 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 5 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by zmin@chromium.org, Aug 30 2017

Labels: -Pri-3 Pri-1

Comment 6 by gov...@chromium.org, Aug 30 2017

Pls apply appropriate OSs. Thank you.

Comment 7 by zmin@chromium.org, Aug 30 2017

Labels: OS-Linux OS-Windows
Done.

Comment 8 by gov...@chromium.org, Aug 30 2017

NextAction: 2017-08-31
CL at #2 just landed, not yet tested/baked/verified in Canary. Please update the bug with Canary coverage. 

Comment 9 by zmin@chromium.org, Aug 30 2017

This CL does not change any code. It affects the documentation and ADM/ADMX file exporting. In the other word, after it's merged into M61, the M61 ADM/ADMX file will not include ForceBrowserSignin policy anymore.

Comment 10 by zmin@chromium.org, Aug 30 2017

Cc: georgesak@chromium.org pastarmovj@chromium.org
This CL will not change any behavior of Chrome
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 branch 3163 based on comments #3, #9 & #10. Please merge ASAP. Thank you.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 30 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/509fc4193e52724406fa0bf828b3532d57c379fc

commit 509fc4193e52724406fa0bf828b3532d57c379fc
Author: Owen Min <zmin@chromium.org>
Date: Wed Aug 30 21:41:14 2017

Bump the minimum supported version of ForceBrowserSignin policy to 62.

Bug:  760296 

TBR=zmin@chromium.org

(cherry picked from commit 3292acff755b0d0e3486451e832ea50d49a29bef)

Change-Id: I008c76a95e1140a453d7750c1aeb3c45a09393d1
Reviewed-on: https://chromium-review.googlesource.com/641780
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498501}
Reviewed-on: https://chromium-review.googlesource.com/644171
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1010}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/509fc4193e52724406fa0bf828b3532d57c379fc/components/policy/resources/policy_templates.json

The NextAction date has arrived: 2017-08-31
Cc: tnagel@chromium.org
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2556416124ddb9b0aea9a1e7508f583e07ca0c54

commit 2556416124ddb9b0aea9a1e7508f583e07ca0c54
Author: Owen Min <zmin@chromium.org>
Date: Mon Sep 11 20:59:23 2017

Add future flag for ForceBrowserSignin policy to remove it from ADM/ADMX file

Bug:  760296 
Change-Id: Idc0fa15a94d7fd843a1ae72159ece779a96fccae
Reviewed-on: https://chromium-review.googlesource.com/660686
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501037}
[modify] https://crrev.com/2556416124ddb9b0aea9a1e7508f583e07ca0c54/components/policy/resources/policy_templates.json

Comment 16 by zmin@chromium.org, Sep 11 2017

Labels: Merge-Request-61
Request merging the above CL to M61.

This CL will remove the ForceBrowserSignin policy from html documentation and ADM/ADMX file.
It will only affects documentation but not any behavior of Chrome.

Comment 17 by zmin@chromium.org, Sep 11 2017

Removing the policy from ADM/ADMX file and html documentation as it is still under launch review.
Project Member

Comment 18 by sheriffbot@chromium.org, Sep 11 2017

Labels: -Merge-Request-61 Merge-Review-61
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 branch 3163 based on comment #16 and per offline chat with 	pastarmovj@. Please merge ASAP. Thank you.


Please also request a merge to M62 if needed. 
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 11 2017

Labels: -merge-approved-61
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e354501128ca4c1f821d928ea8cbe89c52d5363d

commit e354501128ca4c1f821d928ea8cbe89c52d5363d
Author: Owen Min <zmin@chromium.org>
Date: Mon Sep 11 21:34:42 2017

Add future flag for ForceBrowserSignin policy to remove it from ADM/ADMX file

TBR=zmin@chromium.org

(cherry picked from commit 2556416124ddb9b0aea9a1e7508f583e07ca0c54)

Bug:  760296 
Change-Id: Idc0fa15a94d7fd843a1ae72159ece779a96fccae
Reviewed-on: https://chromium-review.googlesource.com/660686
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501037}
Reviewed-on: https://chromium-review.googlesource.com/661387
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1164}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/e354501128ca4c1f821d928ea8cbe89c52d5363d/components/policy/resources/policy_templates.json

Cc: abdulsyed@chromium.org
+  abdulsyed@ (M62 Desktop TPM) to follow up on M62 merge

Comment 22 by zmin@chromium.org, Oct 11 2017

Labels: Merge-Request-62
Request merge the second CL(refs/heads/master@{#488528}) to 62.
The CL has been merged into 61 already.
Project Member

Comment 23 by sheriffbot@chromium.org, Oct 11 2017

Labels: -Merge-Request-62 Merge-Review-62
This bug requires manual review: We are only 5 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-62 Merge-Approved-62
Checked with zmin@ offline, and approving merge to M62. Branch:3202
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 12 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ba90df06c8afc222a5876118d79f4b8bc30fed2

commit 3ba90df06c8afc222a5876118d79f4b8bc30fed2
Author: Owen Min <zmin@chromium.org>
Date: Thu Oct 12 19:53:03 2017

Add future flag for ForceBrowserSignin policy to remove it from ADM/ADMX file

TBR=zmin@chromium.org

(cherry picked from commit 2556416124ddb9b0aea9a1e7508f583e07ca0c54)

Bug:  760296 
Change-Id: Idc0fa15a94d7fd843a1ae72159ece779a96fccae
Reviewed-on: https://chromium-review.googlesource.com/660686
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501037}
Reviewed-on: https://chromium-review.googlesource.com/717041
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#670}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/3ba90df06c8afc222a5876118d79f4b8bc30fed2/components/policy/resources/policy_templates.json

Project Member

Comment 26 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1be3597301369c79b54e24a09c06d0de0c11d9c2

commit 1be3597301369c79b54e24a09c06d0de0c11d9c2
Author: Owen Min <zmin@chromium.org>
Date: Tue Nov 28 22:04:19 2017

Bump up the ForceBrowserSignin policy suppoert version.

Bug:  760296 
Change-Id: Icd7907d70667feea0f5398c5c87c6f84e441f472
Reviewed-on: https://chromium-review.googlesource.com/792175
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519863}
[modify] https://crrev.com/1be3597301369c79b54e24a09c06d0de0c11d9c2/components/policy/resources/policy_templates.json

Comment 27 by zmin@chromium.org, May 11 2018

Status: Verified (was: Started)

Sign in to add a comment