New issue
Advanced search Search tips

Issue 760288 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

MediaRouterElementsBrowserTest.MediaRouterContainerSearch is flaky on Win7 Tests (dbg)(1)

Project Member Reported by tbansal@chromium.org, Aug 29 2017

Issue description

Labels: OS-Windows
https://chromium-review.googlesource.com/c/chromium/src/+/625509 is a mechanical change and doesn't touch the UI bits that the failed test exercises.

It looks like it is a flaky test as the next build succeeded.
Do you know whom to route this for fixing the flakiness?
Components: Blink>PresentationAPI
Status: Available (was: Untriaged)
Summary: MediaRouterElementsBrowserTest.MediaRouterContainerSearch is flaky on Win7 Tests (dbg)(1) (was: MediaRouterElementsBrowserTest.MediaRouterContainerSearch is failing on Win7 Tests (dbg)(1) )
Triaging to MR.

IIRC, MediaRouterElementsBrowserTest had a tendency to time out in the past. Our solution was to split our test cases into smaller test files where each can run to completion within the timeout. So if this flakes again we have 2 options: split again, or look into setting a custom timeout in the webui browser test framework.
Thank you so much!
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1268d4b65b5e4b08a3972b54933d3f2acc967f76

commit 1268d4b65b5e4b08a3972b54933d3f2acc967f76
Author: sebsg <sebsg@chromium.org>
Date: Tue Sep 12 22:54:43 2017

Disable MediaRouterContainerSearch on Win7 (flaky).

Bug:  760288 
Change-Id: I79e0c682394236aa4a7d2dcd421680e09abef082
Reviewed-on: https://chromium-review.googlesource.com/663793
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501436}
[modify] https://crrev.com/1268d4b65b5e4b08a3972b54933d3f2acc967f76/chrome/test/data/webui/media_router/media_router_elements_browsertest.js

Comment 7 by mfo...@chromium.org, Oct 26 2017

Cc: -imch...@chromium.org
Components: -Blink>PresentationAPI Internals>Cast>UI Tests>Disabled
Labels: M-64
Owner: imch...@chromium.org
Status: Assigned (was: Available)
Let's try to address this for M64.  imcheng@, feel free to reassign depending on what's on your plate.
Owner: btolsch@chromium.org
Status: Started (was: Assigned)
Taking this for now since it's related to the filter test fix.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40f304cc99d6d6241fcbdba2f294db2b7d46be77

commit 40f304cc99d6d6241fcbdba2f294db2b7d46be77
Author: btolsch <btolsch@chromium.org>
Date: Fri Nov 10 21:39:47 2017

Split search and filter MediaRouterElementsBrowserTests into 2 parts

Search and filter tests have been flaky on Windows bots because they
time out.  In the past, the fix for this was to split the tests up into
more cases so this change further splits filter and search tests.

Bug:  657964 ,  760288 
Change-Id: I01bd179aed3b7181a50ef0627320ccc643f8437a
Reviewed-on: https://chromium-review.googlesource.com/761260
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515691}
[modify] https://crrev.com/40f304cc99d6d6241fcbdba2f294db2b7d46be77/chrome/test/data/webui/media_router/media_router_container_filter_tests.js
[modify] https://crrev.com/40f304cc99d6d6241fcbdba2f294db2b7d46be77/chrome/test/data/webui/media_router/media_router_container_search_tests.js
[modify] https://crrev.com/40f304cc99d6d6241fcbdba2f294db2b7d46be77/chrome/test/data/webui/media_router/media_router_elements_browsertest.js

Status: Fixed (was: Started)
Bots are looking good after the test split.
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment