New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 760265 link

Starred by 3 users
Status: Fixed
Owner:
jojwang@chromium.org
Closed: May 2018
Cc:
█ jparent@chromium.org
qyears...@chromium.org
seanmccullough@chromium.org
zhangtiff@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Create Shared Polymer UI Elements for ChOps

Project Member Reported by jojwang@google.com, Aug 29 2017 
design doc: go/chops-ui

Create shared Web Components for ChOps application frontends.
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/97623c9ec0a3632cc66ca87f25f92a24120b280a

commit 97623c9ec0a3632cc66ca87f25f92a24120b280a
Author: Joanna Wang <jojwang@google.com>
Date: Tue Oct 31 17:41:08 2017

Make bug-input accept non-chromium bugs

Bug:760265
Change-Id: Id3545d8f998c7da7a7124fe2b684dc4a52e167b3
Reviewed-on: https://chromium-review.googlesource.com/744587
Commit-Queue: Joanna Wang <jojwang@google.com>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/97623c9ec0a3632cc66ca87f25f92a24120b280a/go/src/infra/appengine/shared/elements/bug-input.html
[modify] https://crrev.com/97623c9ec0a3632cc66ca87f25f92a24120b280a/go/src/infra/appengine/shared/test/bug-input_test.html
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/912271c29a7a8208154678b9e034866206a1c319

commit 912271c29a7a8208154678b9e034866206a1c319
Author: Joanna Wang <jojwang@google.com>
Date: Fri Nov 10 03:15:11 2017

Edit chopsui name

I may have given the wrong git URL when I registered 'chops-ui' because
stuff isn't working when it should be.

To fix this I need to manually request the bower team to unregister
and register again. and it looks like it takes several weeks for them to
get back to those requests.

So I'm just going to register it again under the name 'chopsui'.

Bug:760265
Change-Id: I3c99d03673766c2a64ef6d6d973bbe41e29eceaf
Reviewed-on: https://chromium-review.googlesource.com/762147
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Joanna Wang <jojwang@google.com>

[modify] https://crrev.com/912271c29a7a8208154678b9e034866206a1c319/crdx/chopsui/bower.json
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fd38369af9f6ed7eb56e5b58073f518d8ad1640f

commit fd38369af9f6ed7eb56e5b58073f518d8ad1640f
Author: Joanna Wang <jojwang@google.com>
Date: Fri Nov 10 17:43:17 2017

Keep only one html file in bower.json main

Bug:760265
Change-Id: I8985e9f454d345cbf4d55684627d62a67d7dbdb6
Reviewed-on: https://chromium-review.googlesource.com/763571
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Joanna Wang <jojwang@google.com>

[modify] https://crrev.com/fd38369af9f6ed7eb56e5b58073f518d8ad1640f/crdx/chopsui/bower.json
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/932f7aff0f6a1781bc2ce02bd8c99cc5ba02be8d

commit 932f7aff0f6a1781bc2ce02bd8c99cc5ba02be8d
Author: Joanna Wang <jojwang@google.com>
Date: Mon Nov 13 17:41:04 2017

Use chops-ui elements and demos to create chopsui-gallery app.

Removing local demo files. Creating demo files from chops-ui package via 'make build'


staging: https://12746-fb6e95f-tainted-jojwang-dot-chopsui-gallery.appspot.com/#/elements/bug-input

Bug:760265
Change-Id: Ib2d1bd0d36c9731eb3eacefd2ae4ae91cb0a50b9
Reviewed-on: https://chromium-review.googlesource.com/764954
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Joanna Wang <jojwang@google.com>

[delete] https://crrev.com/4be52d806542e7f0998dc1bb6854e66e05340224/go/src/infra/appengine/chopsui-gallery/demo/crdx-timestamp_demo.html
[add] https://crrev.com/932f7aff0f6a1781bc2ce02bd8c99cc5ba02be8d/go/src/infra/appengine/chopsui-gallery/README.md
[delete] https://crrev.com/4be52d806542e7f0998dc1bb6854e66e05340224/go/src/infra/appengine/chopsui-gallery/demo/bug-input_demo.html
[delete] https://crrev.com/4be52d806542e7f0998dc1bb6854e66e05340224/go/src/infra/appengine/chopsui-gallery/demo/bug-link_demo.html
[add] https://crrev.com/932f7aff0f6a1781bc2ce02bd8c99cc5ba02be8d/go/src/infra/appengine/chopsui-gallery/Makefile
[delete] https://crrev.com/4be52d806542e7f0998dc1bb6854e66e05340224/go/src/infra/appengine/chopsui-gallery/demo/user-input_demo.html
[delete] https://crrev.com/4be52d806542e7f0998dc1bb6854e66e05340224/go/src/infra/appengine/chopsui-gallery/demo/user-id_demo.html
[delete] https://crrev.com/4be52d806542e7f0998dc1bb6854e66e05340224/go/src/infra/appengine/chopsui-gallery/demo/cl-link_demo.html
[delete] https://crrev.com/4be52d806542e7f0998dc1bb6854e66e05340224/go/src/infra/appengine/chopsui-gallery/demo/tree-status_demo.html
[delete] https://crrev.com/4be52d806542e7f0998dc1bb6854e66e05340224/go/src/infra/appengine/chopsui-gallery/demo/user-login_demo.html
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/14c444d3d37aff7798fa563d65e804757d24361d

commit 14c444d3d37aff7798fa563d65e804757d24361d
Author: Joanna Wang <jojwang@google.com>
Date: Mon Nov 13 21:52:55 2017

Update README

Bug:760265
Change-Id: I6a4509649e21b5f007dc4ec177c2c8bf91247dd4
Reviewed-on: https://chromium-review.googlesource.com/767029
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Joanna Wang <jojwang@google.com>

[modify] https://crrev.com/14c444d3d37aff7798fa563d65e804757d24361d/crdx/chopsui/bower.json
[modify] https://crrev.com/14c444d3d37aff7798fa563d65e804757d24361d/crdx/chopsui/README.md

Comment 24 by qyears...@chromium.org, May 15 2018 

I have a feeling that this bug should be considered "fixed" now, right?

Follow-up question: now that Polymer 3 has been announced, and the Polymer project is moving away from bower, is there any plan for chops-ui currently to be changed so that it's distributed with npm or something like that?

Comment 25 by qyears...@chromium.org, May 15 2018

Cc: qyears...@chromium.org

Comment 26 by seanmccullough@google.com, May 15 2018 

Yeah this doesn't really have solid completion criteria but it exists now and people are using it.

Re Polymer 3: We'll use the recommended packager for polymer 3.0, npm, when we upgrade to 3.0.  It's probably going to be a good chunk of work to upgrade our existing apps (and ChopsUI) but they've also announced some tools to help with the conversion.

Comment 27 by seanmccullough@google.com, May 15 2018

Status: Fixed (was: Started)

Comment 28 by qyears...@chromium.org, May 15 2018 

Thanks Sean, that makes sense.
►

Sign in to add a comment