New issue
Advanced search Search tips

Issue 760256 link

Starred by 2 users
Status: Duplicate
Merged: issue 760196
Owner: ----
Closed: Aug 2017
Cc:
sergeyu@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

net_unittests failing on Android N5X Swarm Builder

Project Member Reported by tbansal@chromium.org, Aug 29 2017 
Started with:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/14823

From logs:
ERROR:spawner_communicator.cc(228)] Spawner server returned bad status: HTTP/1.0 400 Invalid request, Too many test servers running
[ERROR:ssl_client_socket_unittest.cc(925)] Could not start SpawnedTestServer


Seems related to https://chromium-review.googlesource.com/c/chromium/src/+/641073

I am going to revert the CL to see if it helps.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b7dac4c9da04f73e80cf82bc2c33f7f8bcd35a2

commit 4b7dac4c9da04f73e80cf82bc2c33f7f8bcd35a2
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Aug 29 19:57:28 2017

Speculatively revert "Fix typo in chrome_test_server_spawner.py"

This reverts commit 309bd24c9dca914dfce162a336bc320cbd2e6af3.

Reason for revert:
Breaks net unittests
See  crbug.com/760256 


Original change's description:
> Fix typo in chrome_test_server_spawner.py
> 
> SpawningServerRequestHandler.CleanupState() was setting test_servers to
> [] instead of {}. As result test server spawner was crashing on some
> bots.
> 
> TBR=jbudorick@chromium.org
> 
> Bug:  760196 
> Change-Id: Ib11575bca5fad0d1f128e4673e6b50f4d9e58b9b
> Reviewed-on: https://chromium-review.googlesource.com/641073
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498160}

TBR=sergeyu@chromium.org,jbudorick@chromium.org

Change-Id: I3a807a1db148fe022ca1372b8d0624d08d4e449f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  760196 ,  760256 
Reviewed-on: https://chromium-review.googlesource.com/641353
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498207}
[modify] https://crrev.com/4b7dac4c9da04f73e80cf82bc2c33f7f8bcd35a2/build/util/lib/common/chrome_test_server_spawner.py

Comment 4 by sergeyu@chromium.org, Aug 29 2017

Mergedinto: 760196
Status: Duplicate
►

Sign in to add a comment