No breakpoints in source-mapped code, no error message or user guidance. |
|||
Issue description
Chrome Version : 60.0.3112.101
OS Version: Goobuntu (Ubuntu 14 variant I think)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:
What steps will reproduce the problem?
1. Use compiled TypeScript with inline arrow functions
2. Try to set a breakpoint on the inline arrow function
What is the expected result? Ideally a breakpoint would be set on that arrow function, or at the very least, I'd get a message asking me to toggle out of sourcemaps to set that breakpoint.
What happens instead of that? No breakpoint appears. No error. No message. Just nothing happens, but there's a little flicker like maybe something happened. It's very confusing.
Please provide any additional information below. Attach a screenshot if
possible.
UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.101 Safari/537.36
Imagine trying to set a breakpoint on the third function in here:
const (a: number) => (b: number) => (c: number) => (d: number) => a + b + c + d;
,
Sep 14 2017
@kozy - I'm guessing you can dedupe this with a similar bug?
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b215935dccf392557df907d8eb68f06edc1a227 commit 4b215935dccf392557df907d8eb68f06edc1a227 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Oct 12 06:26:32 2017 [DevTools] use end line position to request possible breakpoints Currently we use first char in next line, it regressed breakpoints in files from source map. TBR=lushnikov@chromium.org Bug: chromium:676388 , chromium:760229 , chromium:761263 Change-Id: I10e83ff96fcda6aae77515003ae1d0cdf993ee84 Reviewed-on: https://chromium-review.googlesource.com/714436 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#508267} [add] https://crrev.com/4b215935dccf392557df907d8eb68f06edc1a227/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap-expected.txt [add] https://crrev.com/4b215935dccf392557df907d8eb68f06edc1a227/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/breakpoint-with-sourcemap.js [modify] https://crrev.com/4b215935dccf392557df907d8eb68f06edc1a227/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05e936f753407fad2c97ae65a3004d71610ee1ad commit 05e936f753407fad2c97ae65a3004d71610ee1ad Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Oct 12 20:26:26 2017 [DevTools] take into account column in uiLocationToRawLocation with sourceMap .. otherwise inline breakpoints are just broken for files with source map. R=lushnikov@chromium.org Bug: chromium:760229 Change-Id: I2658258ac6f4b6f255583bdea16ede4ad99940f3 Reviewed-on: https://chromium-review.googlesource.com/716660 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#508443} [modify] https://crrev.com/05e936f753407fad2c97ae65a3004d71610ee1ad/third_party/WebKit/LayoutTests/http/tests/devtools/compiler-script-mapping.html [add] https://crrev.com/05e936f753407fad2c97ae65a3004d71610ee1ad/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/inline-breakpoint-with-sourcemap-expected.txt [add] https://crrev.com/05e936f753407fad2c97ae65a3004d71610ee1ad/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/inline-breakpoint-with-sourcemap.js [modify] https://crrev.com/05e936f753407fad2c97ae65a3004d71610ee1ad/third_party/WebKit/LayoutTests/http/tests/devtools/text-source-map.html [modify] https://crrev.com/05e936f753407fad2c97ae65a3004d71610ee1ad/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js [modify] https://crrev.com/05e936f753407fad2c97ae65a3004d71610ee1ad/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js
,
Oct 12 2017
Inline breakpoints for type script should be fixed in next Canary. |
|||
►
Sign in to add a comment |
|||
Comment 1 by krajshree@chromium.org
, Sep 5 2017Components: Platform>DevTools>JavaScript
Labels: Needs-Triage-M60 Needs-Feedback