ContentBrowserTests-Viz: RenderWidgetHostViewChildFrameTest |
|||||
Issue descriptionRenderWidgetHostViewChildFrameTest has dependencies on components/viz/common/surfaces/surface_sequence.h components/viz/service/frame_sinks/compositor_frame_sink_support.h components/viz/service/surfaces/surface.h components/viz/service/surfaces/surface_manager.h components/viz/test/begin_frame_args_test.h components/viz/test/fake_external_begin_frame_source.h Find out how the Viz process split impacts this test, and update.
,
Aug 29 2017
Surface sequences are going away in a week or so. We should use a test interface instead of depending directly on CompositorFrameSinkSupport. Also, RWHVChildFrame does text selection handles now so we can't switch to CompositorFrameSinkImpl yet. I believe Pedro is looking into this. We should not be accessing surface or surface manager directly nor modifying / accessing BeginFrameSources directly in tests. A test interface should solve this.
,
Aug 29 2017
Slight mix-up, this should be tracking the variant in content_unittests: content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc
,
Sep 6 2017
compositor_frame_sink_support setup to mock out the service is fine. Need to decide if SurfaceManager checking is the appropriate way to verify that things have worked.
,
Nov 8 2017
Migrating from Internals>Viz to Internals>Services>Viz.
,
Dec 15 2017
Currently some tests also touch the SubmitCompositorFrame path, which will not be used anymore in --enable-viz These are leading to a failing DCHECK that is looking for not --enable-viz RenderWidgetHostViewChildFrameTest.FrameEviction RenderWidgetHostViewChildFrameTest.SwapCompositorFrame
,
Mar 1 2018
,
May 16 2018
RenderWidgetHostViewChildFrameTest.SwapCompositorFrame should go away.
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d0e749658616f9efdefc68c58432efe404cb412 commit 9d0e749658616f9efdefc68c58432efe404cb412 Author: jonross <jonross@chromium.org> Date: Wed May 23 17:08:42 2018 Disable RenderWidgetHostViewChildFrameTest.SwapCompositorFrame on Viz RenderWidgetHostViewChildFrameTest.SwapCompositorFrame will be obsolete once Viz is the default. This updates the test to exit early in that state, with a note for me to delete it later. TEST=RenderWidgetHostViewChildFrameTest.SwapCompositorFrame Bug: 760213 Change-Id: Ibcef75e5a99b4ae524041ecb28303aff63186b64 Reviewed-on: https://chromium-review.googlesource.com/1070213 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#561127} [modify] https://crrev.com/9d0e749658616f9efdefc68c58432efe404cb412/content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc [modify] https://crrev.com/9d0e749658616f9efdefc68c58432efe404cb412/testing/buildbot/filters/viz.content_unittests.filter
,
May 23 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jonr...@chromium.org
, Aug 29 2017