New issue
Advanced search Search tips

Issue 760211 link

Starred by 1 user
Status: Fixed
Owner:
peconn@chromium.org
Closed: Sep 2017
Cc:
liber...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug


Participants' hotlists:
FullscreenActivityBugs


Sign in to add a comment

FullscreenActivity causes chrome to resume

Project Member Reported by liber...@chromium.org, Aug 29 2017 
1. navigate to a page with video (e.g. http://storage.googleapis.com/watk-public/v)
2. enter fullscreen.
3. make sure that video is paused
4. press home
5. wait about five seconds
6. chrome reopens

video attached.

turning off the feature FullscreenActivity fixes it.

filing this as a new bug since it was previously just a comment on an unrelated one.
chrome_restarts_after_leaving_fullscreen.mp4
2.2 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c5c9bbd47f8c32b1ce94752ee12b3aa3629e1d5

commit 9c5c9bbd47f8c32b1ce94752ee12b3aa3629e1d5
Author: Peter E Conn <peconn@chromium.org>
Date: Wed Sep 06 11:51:39 2017

📺 Only use FullscreenActivity if the current Activity is RESUMED.

When Chrome goes into the background, the web-page dismisses fullscreen.
If FullscreenActivity is enabled, this dismissal launches the Tab back
to ChromeTabbedActivity with an Intent, in effect launching Chrome
again.

Therefore we use the normal, non-FullscreenActivity transition when
fullscreen is requested and the Activity is not RESUMED.

Bug:  760211 
Change-Id: I0cfe3b6af085f1cd635b7b66c0e481184bfbbba2
Reviewed-on: https://chromium-review.googlesource.com/650351
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499933}
[modify] https://crrev.com/9c5c9bbd47f8c32b1ce94752ee12b3aa3629e1d5/chrome/android/java/src/org/chromium/chrome/browser/FullscreenActivity.java
[modify] https://crrev.com/9c5c9bbd47f8c32b1ce94752ee12b3aa3629e1d5/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java
[modify] https://crrev.com/9c5c9bbd47f8c32b1ce94752ee12b3aa3629e1d5/chrome/android/javatests/src/org/chromium/chrome/browser/FullscreenActivityTest.java

Comment 2 by peconn@chromium.org, Sep 6 2017

Status: Fixed (was: Assigned)
(for verification, you'll need the FullscreenActivity feature enabled)
►

Sign in to add a comment