UiRestrictions.RESTRICT_PHONE is not respected |
||
Issue descriptionCausing all tablet testers to fail: https://build.chromium.org/p/chromium.android/builders/KitKat%20Tablet%20Tester Example error: junit.framework.AssertionFailedError: R.id.toolbar is not a ToolbarPhone Suspected commit: [Restriction] Move device form factor Restrictions from //chrome to //ui https://chromium-review.googlesource.com/c/chromium/src/+/604756 Which is in the blamelist of the first failing build here: https://build.chromium.org/p/chromium.android/builders/KitKat%20Tablet%20Tester/builds/8832
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1244f50302e9ba5f1910bf053a133c97304cf3bd commit 1244f50302e9ba5f1910bf053a133c97304cf3bd Author: Shenghua Zhang <shenghuazhang@chromium.org> Date: Tue Aug 29 19:46:26 2017 [Restriction] Fix UiRestrictions failed at Tabstest UiRestritions and UiDisableIf are not added in ChromeInstrumentationTestRunner, so the chrome tests running with Junit3 failed when using Device Restrictions. This CL fixs the issue. Bug: 760193 Change-Id: I4a45cf6a862ef57b2a23d20c6bf39b6b8e04cbf0 Reviewed-on: https://chromium-review.googlesource.com/641917 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#498205} [modify] https://crrev.com/1244f50302e9ba5f1910bf053a133c97304cf3bd/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
,
Aug 30 2017
Looks fixed! Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by shenghua...@chromium.org
, Aug 29 2017