ARC++ window may leave backdrop in restored state |
||||||||||
Issue descriptionARC++ window may leave backdrop in restored state
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48c12fb9154ff9177f9a9a5e6ff2d035896d7a7b commit 48c12fb9154ff9177f9a9a5e6ff2d035896d7a7b Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Aug 30 00:26:36 2017 Update the backdrop when the widget state changes. Currently the window state is updated outside of commit so and we need to update upon the state change request from client. This should be changed when we move the window state change into commit. CL introduces parameterized test for bounds mode. R=reveman@chromium.org, mtomasz@chromium.org BUG= 760188 TEST=covered by unittest, also teted on device. Change-Id: I5afc791529756887de5a276cf15071ef3c3ba6e0 Reviewed-on: https://chromium-review.googlesource.com/641656 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#498303} [modify] https://crrev.com/48c12fb9154ff9177f9a9a5e6ff2d035896d7a7b/components/exo/shell_surface.cc [modify] https://crrev.com/48c12fb9154ff9177f9a9a5e6ff2d035896d7a7b/components/exo/shell_surface.h [modify] https://crrev.com/48c12fb9154ff9177f9a9a5e6ff2d035896d7a7b/components/exo/shell_surface_unittest.cc
,
Aug 30 2017
oshima@ can you please merge this to M61 if not already?
,
Aug 31 2017
,
Aug 31 2017
sorry forgot to add request label. I assume it's approve and will merge shortly.
,
Aug 31 2017
This bug requires manual review: We are only 4 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27e7ffb7b7cad522207a26570f136edc8a1541f5 commit 27e7ffb7b7cad522207a26570f136edc8a1541f5 Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Aug 31 04:58:16 2017 Update the backdrop when the widget state changes. Currently the window state is updated outside of commit so and we need to update upon the state change request from client. This should be changed when we move the window state change into commit. CL introduces parameterized test for bounds mode. R=reveman@chromium.org, mtomasz@chromium.org BUG= 760188 TEST=covered by unittest, also teted on device. (cherry picked from commit 48c12fb9154ff9177f9a9a5e6ff2d035896d7a7b) Change-Id: I5afc791529756887de5a276cf15071ef3c3ba6e0 Reviewed-on: https://chromium-review.googlesource.com/641656 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#498303} Reviewed-on: https://chromium-review.googlesource.com/645008 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1029} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/27e7ffb7b7cad522207a26570f136edc8a1541f5/components/exo/shell_surface.cc [modify] https://crrev.com/27e7ffb7b7cad522207a26570f136edc8a1541f5/components/exo/shell_surface.h [modify] https://crrev.com/27e7ffb7b7cad522207a26570f136edc8a1541f5/components/exo/shell_surface_unittest.cc
,
Aug 31 2017
,
Aug 31 2017
Approving merge to M61
,
Sep 4 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by keta...@chromium.org
, Aug 29 2017