http/tests/devtools/elements/styles-3/styles-change-node-while-editing.html failing on Linux |
||||||
Issue descriptionBuilds: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/4500 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/4499 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/4498 Started failing here: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/4469
,
Aug 29 2017
Related to https://chromium-review.googlesource.com/c/chromium/src/+/636451. The test was marked as failing in third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG. The CL moved it. I think we also need to update the location in the expectation file.
,
Aug 29 2017
,
Aug 29 2017
I submitted a CL to fix this expectation: https://chromium-review.googlesource.com/c/chromium/src/+/641910 I believe I have already updated the location in the LayoutNG feature flag test expectation file.
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c556f2438eed1bf86b39fbdbcd438fd1afb8cb3d commit c556f2438eed1bf86b39fbdbcd438fd1afb8cb3d Author: Will Chen <chenwilliam@chromium.org> Date: Tue Aug 29 17:47:30 2017 DevTools: set TestExpectations for virtual/mojo-loading/http/tests/devtools/elements/styles-3/styles-change-node-while-editing.html Bug: 760183 , 667560 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I081145d5764b8300e5eba3d61c55226f56c2499c Reviewed-on: https://chromium-review.googlesource.com/641910 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#498161} [modify] https://crrev.com/c556f2438eed1bf86b39fbdbcd438fd1afb8cb3d/third_party/WebKit/LayoutTests/TestExpectations
,
Sep 4 2017
,
Sep 4 2017
Hi chenwilliam@, I'm working on mojo-loading, and I would like to enable it by default on Desktop platforms. Currently some virtual/mojo-loading devtools related tests are failing, do you think it's blocking? Or (like many other devtools tests) is it just OK to add expectation lines? Thanks!
,
Sep 5 2017
I think it's ok to just add expectation lines. I recently converted a lot of tests into HTTP tests hence the new failures. Thanks.
,
Sep 6 2017
Thanks!
,
Dec 19 2017
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae0970857dffc4dcff92753d3f63795240d13b02 commit ae0970857dffc4dcff92753d3f63795240d13b02 Author: Will Chen <chenwilliam@chromium.org> Date: Thu Dec 21 23:26:25 2017 DevTools: fix flaky test http/tests/devtools/elements/styles-3/styles-change-node-while-editing.js Bug: 760183 Change-Id: I100ca5aaab5435de111f13c0dc3ed2caa5f2ccea Reviewed-on: https://chromium-review.googlesource.com/835005 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#525845} [modify] https://crrev.com/ae0970857dffc4dcff92753d3f63795240d13b02/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-change-node-while-editing-expected.txt |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tbansal@chromium.org
, Aug 29 2017