New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760183 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

http/tests/devtools/elements/styles-3/styles-change-node-while-editing.html failing on Linux

Project Member Reported by tbansal@chromium.org, Aug 29 2017

Issue description

From https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=fd59ebc4248b279d0c597871aa9b2f6ab99ea3fc&as=styles-change-node-while-editing-diff.txt:

--- /b/s/w/ioiX3_Oo/layout-test-results/retry_1/virtual/mojo-loading/http/tests/devtools/elements/styles-3/styles-change-node-while-editing-expected.txt
+++ /b/s/w/ioiX3_Oo/layout-test-results/retry_1/virtual/mojo-loading/http/tests/devtools/elements/styles-3/styles-change-node-while-editing-actual.txt
@@ -11,6 +11,6 @@
 
 [expanded] 
 element.style { ()
-    background: red;
+    color: red;
 
Cc: chenwilliam@chromium.org
Related to https://chromium-review.googlesource.com/c/chromium/src/+/636451.

The test was marked as failing in third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG. The CL moved it. I think we also need to update the location in the expectation file.
Cc: -chenwilliam@chromium.org
Labels: -Pri-2 Pri-1
Owner: chenwilliam@chromium.org
Status: Started (was: Untriaged)
I submitted a CL to fix this expectation: https://chromium-review.googlesource.com/c/chromium/src/+/641910

I believe I have already updated the location in the LayoutNG feature flag test expectation file.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c556f2438eed1bf86b39fbdbcd438fd1afb8cb3d

commit c556f2438eed1bf86b39fbdbcd438fd1afb8cb3d
Author: Will Chen <chenwilliam@chromium.org>
Date: Tue Aug 29 17:47:30 2017

DevTools: set TestExpectations for virtual/mojo-loading/http/tests/devtools/elements/styles-3/styles-change-node-while-editing.html

Bug:  760183 ,  667560 
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I081145d5764b8300e5eba3d61c55226f56c2499c
Reviewed-on: https://chromium-review.googlesource.com/641910
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498161}
[modify] https://crrev.com/c556f2438eed1bf86b39fbdbcd438fd1afb8cb3d/third_party/WebKit/LayoutTests/TestExpectations

Cc: yhirano@chromium.org
Components: Blink>Loader
Hi chenwilliam@, I'm working on mojo-loading, and I would like to enable it by default on Desktop platforms. Currently some virtual/mojo-loading devtools related tests are failing, do you think it's blocking? Or (like many other devtools tests) is it just OK to add expectation lines?

Thanks!
I think it's ok to just add expectation lines. I recently converted a lot of tests into HTTP tests hence the new failures. Thanks.

Thanks!
Status: Archived (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae0970857dffc4dcff92753d3f63795240d13b02

commit ae0970857dffc4dcff92753d3f63795240d13b02
Author: Will Chen <chenwilliam@chromium.org>
Date: Thu Dec 21 23:26:25 2017

DevTools: fix flaky test http/tests/devtools/elements/styles-3/styles-change-node-while-editing.js

Bug:  760183 
Change-Id: I100ca5aaab5435de111f13c0dc3ed2caa5f2ccea
Reviewed-on: https://chromium-review.googlesource.com/835005
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525845}
[modify] https://crrev.com/ae0970857dffc4dcff92753d3f63795240d13b02/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-3/styles-change-node-while-editing-expected.txt

Sign in to add a comment