New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Content_Browsertests Viz Process Separation

Project Member Reported by jonr...@chromium.org, Aug 29 2017

Issue description

As a part of the work to split services/viz into a separate process, the testing dependencies on it need to be updated.

We need to identify all locations with direct dependencies, and update them accordingly. These will be tracked in bugs that block this one.

We will also need to look into providing a test interface to FrameSinkManager so that we stub out this test boundary
 
Showing comments 9 - 108 of 108 Older
Status: WontFix (was: Started)
All content_browsertests are fine.
Huh? I don't think so?
Oh, a non viz include that is actually quite dangerous.

I'll investigate the usage of browser_test_utils::WaitForChildFrameSurfaceReady
Specifically we need to update SurfaceHitTestReadyNotifier 
Blockedon: 763449
Blockedon: 763452
Blockedon: 763458
Blockedon: 763462
Blockedon: 763464
Blockedon: 764790
Blockedon: 764792
Blockedon: 764793
Blockedon: 764801
Blockedon: 764802
Blockedon: 764805
Blockedon: 764806
Blockedon: 764808
Blockedon: 764873
Blocking: 601863

Comment 29 by fsamuel@google.com, Oct 10 2017

Cc: danakj@chromium.org piman@chromium.org samans@chromium.org creis@chromium.org rjkroege@chromium.org staraz@chromium.org lfg@chromium.org enne@chromium.org varkha@chromium.org nasko@chromium.org
 Issue 722510  has been merged into this issue.

Comment 30 by sky@chromium.org, Oct 19 2017

Blocking: 776513
 Issue 778537  has been merged into this issue.
Components: -Internals>Viz Internals>Services>Viz
Migrating from Internals>Viz to Internals>Services>Viz.
Blocking: -601863 730193
Project Member

Comment 34 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df214af3e816a797afe25fe345e77e5fbb968f4f

commit df214af3e816a797afe25fe345e77e5fbb968f4f
Author: Jonathan <jonross@chromium.org>
Date: Wed Nov 08 22:18:56 2017

Content_Browsertest with --enable-viz

This will enable content_browsertests --enable-viz on the
chromium_chromeos_rel_ng bot.

The filter file is a list of tests which fail, as they traditionally rely on
information that is now in a different process. We'll bring more online as we
create the appropriate test apis.

TBR=sky@chromium.org
TEST=viz_content_browsertests

Bug:  760181 
Change-Id: I4e015d93aec3526c0f0fe2aa0cccafff998fc5a7
Reviewed-on: https://chromium-review.googlesource.com/758603
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514969}
[modify] https://crrev.com/df214af3e816a797afe25fe345e77e5fbb968f4f/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/df214af3e816a797afe25fe345e77e5fbb968f4f/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/df214af3e816a797afe25fe345e77e5fbb968f4f/testing/buildbot/filters/BUILD.gn
[modify] https://crrev.com/df214af3e816a797afe25fe345e77e5fbb968f4f/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[add] https://crrev.com/df214af3e816a797afe25fe345e77e5fbb968f4f/testing/buildbot/filters/viz.content_browsertests.filter

Project Member

Comment 35 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e73f51d6324059b490e2a24ca1a1764bddebd23

commit 5e73f51d6324059b490e2a24ca1a1764bddebd23
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Nov 09 01:59:17 2017

Revert "Content_Browsertest with --enable-viz"

This reverts commit df214af3e816a797afe25fe345e77e5fbb968f4f.

Reason for revert: Failing on chromium.chromiumos waterfall: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/46590

Original change's description:
> Content_Browsertest with --enable-viz
> 
> This will enable content_browsertests --enable-viz on the
> chromium_chromeos_rel_ng bot.
> 
> The filter file is a list of tests which fail, as they traditionally rely on
> information that is now in a different process. We'll bring more online as we
> create the appropriate test apis.
> 
> TBR=sky@chromium.org
> TEST=viz_content_browsertests
> 
> Bug:  760181 
> Change-Id: I4e015d93aec3526c0f0fe2aa0cccafff998fc5a7
> Reviewed-on: https://chromium-review.googlesource.com/758603
> Commit-Queue: Jonathan Ross <jonross@chromium.org>
> Reviewed-by: Jonathan Ross <jonross@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#514969}

TBR=sky@chromium.org,jonross@chromium.org

Change-Id: Iffeb787272a63c3fb447e2f149c01274e7c6675d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  760181 
Reviewed-on: https://chromium-review.googlesource.com/759656
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515058}
[modify] https://crrev.com/5e73f51d6324059b490e2a24ca1a1764bddebd23/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/5e73f51d6324059b490e2a24ca1a1764bddebd23/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/5e73f51d6324059b490e2a24ca1a1764bddebd23/testing/buildbot/filters/BUILD.gn
[modify] https://crrev.com/5e73f51d6324059b490e2a24ca1a1764bddebd23/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[delete] https://crrev.com/0fb330ab50bc2097c3aa59a92f4b6bd9a3d50b45/testing/buildbot/filters/viz.content_browsertests.filter

Blockedon: 783434
Project Member

Comment 37 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9af2912b9c9d7693ddd4ccbaacf61e4019f5c3a

commit f9af2912b9c9d7693ddd4ccbaacf61e4019f5c3a
Author: Jonathan <jonross@chromium.org>
Date: Fri Nov 10 16:08:16 2017

Reland Content_Browsertest with --enable-viz
Revert "Revert "Content_Browsertest with --enable-viz""

This reverts commit 5e73f51d6324059b490e2a24ca1a1764bddebd23.

Additionally the failing test GpuProcessHostBrowserTest.Shutdown will be
disabled.

TEST=viz_content_browsertests

Bug:  760181 
Change-Id: I4b1755694c7adfa79c005550f2d84baf38583889
Reviewed-on: https://chromium-review.googlesource.com/761877
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515562}
[modify] https://crrev.com/f9af2912b9c9d7693ddd4ccbaacf61e4019f5c3a/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/f9af2912b9c9d7693ddd4ccbaacf61e4019f5c3a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/f9af2912b9c9d7693ddd4ccbaacf61e4019f5c3a/testing/buildbot/filters/BUILD.gn
[modify] https://crrev.com/f9af2912b9c9d7693ddd4ccbaacf61e4019f5c3a/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[add] https://crrev.com/f9af2912b9c9d7693ddd4ccbaacf61e4019f5c3a/testing/buildbot/filters/viz.content_browsertests.filter

Blockedon: 784943
Blockedon: 785013
Blockedon: -764873
Blockedon: 785023
Blockedon: -763458
Blockedon: 785257
Blockedon: 785268
Blockedon: 785308
Blockedon: 780279
Project Member

Comment 47 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4eda011e82a9b7f0310482fccdf74df9aaba327

commit f4eda011e82a9b7f0310482fccdf74df9aaba327
Author: Jonathan <jonross@chromium.org>
Date: Wed Nov 15 18:16:56 2017

Update viz_content_browsertests filter

I've gone and classified each of the failures currently occurring in
viz_content_browsertests.

This change updates the filter to have a bug assigned to each group of failing
tests.

A few have had bug fixes, so this turns some tests on.

TBR=sky@chromium.org
TEST=viz_content_browsertests

BUG:  760181 
Change-Id: I820b04a063069437735fdc4b1f827d5ab46c0a9c
Reviewed-on: https://chromium-review.googlesource.com/772091
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516747}
[modify] https://crrev.com/f4eda011e82a9b7f0310482fccdf74df9aaba327/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter

Project Member

Comment 48 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30c422041794f1ce13ece5480be2265f9e9962e3

commit 30c422041794f1ce13ece5480be2265f9e9962e3
Author: Jonathan <jonross@chromium.org>
Date: Wed Nov 15 23:08:00 2017

Enable Fixed viz_content_browsertests

The crash in RenderWidgetHostImpl::RequestCompositorFrameSink has been fixed.
So I'm enabling the affected tests.

TBR=sky@chromium.org
TEST=viz_content_browsertests

Bug:  784943 . 760181
Change-Id: Ifc6887ab36fb27cd78246768cd4d17f935e1ca8f
Reviewed-on: https://chromium-review.googlesource.com/773158
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516876}
[modify] https://crrev.com/30c422041794f1ce13ece5480be2265f9e9962e3/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter

Blockedon: 785986
Project Member

Comment 50 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6fd275c1f30f3c50759ed160e8cd41865fffc76

commit c6fd275c1f30f3c50759ed160e8cd41865fffc76
Author: Jonathan <jonross@chromium.org>
Date: Thu Nov 16 17:35:22 2017

Update viz_content_browsertests filter for new test

A new test
  WebRtcCaptureFromElementBrowserTest.CaptureFromCanvas2DHandlesContextLoss

was landed in https://chromium-review.googlesource.com/c/chromium/src/+/756474

It is consistently failing in viz_content_browsertests due to 785023. This
change updates the tests filters to include this new test. While also copying
the updates which the FYI bot received yesterday.

TBR=sky@chromium.org
TEST=viz_content_browsertests

Bug:  760181 
Change-Id: Idf6c9ff0239a7ec8dd871518a65e427aaf927577
Reviewed-on: https://chromium-review.googlesource.com/774978
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517115}
[modify] https://crrev.com/c6fd275c1f30f3c50759ed160e8cd41865fffc76/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/c6fd275c1f30f3c50759ed160e8cd41865fffc76/testing/buildbot/filters/viz.content_browsertests.filter

Blockedon: 786132
Blockedon: 786151
Project Member

Comment 53 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/535c294217db7aedd40dcc61a9a5428583ac9e8f

commit 535c294217db7aedd40dcc61a9a5428583ac9e8f
Author: kylechar <kylechar@chromium.org>
Date: Fri Nov 17 15:36:43 2017

Drop unneeded flags for viz_content_browsertests.

Try dropping two flags that shouldn't be needed. This only modifies the
FYI trybot to confirm there are no tests that flake without the flags.

TBR: sky@chromium.org
Bug:  760181 
Change-Id: I9918be273622e4acb016c56dbea3be32560e6040
Reviewed-on: https://chromium-review.googlesource.com/775753
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517399}
[modify] https://crrev.com/535c294217db7aedd40dcc61a9a5428583ac9e8f/testing/buildbot/chromium.fyi.json

Project Member

Comment 54 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b59f301a7fb8cff741485ad0e724bb753062d89

commit 9b59f301a7fb8cff741485ad0e724bb753062d89
Author: Jonathan <jonross@chromium.org>
Date: Fri Nov 17 23:37:53 2017

Expand viz_content_browsers coverage

This change updates the FYI filter to block a known failing test.
This change updates the main filter to match the FYI filter.
This change also adds viz_content_browsers to the Mojo Linux FYI bot to start
getting an idea of our current coverage/failures on Linux

TEST=viz_content_browsertests

Bug:  760181 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Id1744c21afdcce06312074962451e440bf6eb604
Reviewed-on: https://chromium-review.googlesource.com/776623
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517609}
[modify] https://crrev.com/9b59f301a7fb8cff741485ad0e724bb753062d89/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/9b59f301a7fb8cff741485ad0e724bb753062d89/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/9b59f301a7fb8cff741485ad0e724bb753062d89/testing/buildbot/filters/viz.content_browsertests.filter

Project Member

Comment 55 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f5815c429af3bb9013da8f99c7454730882e6f7

commit 4f5815c429af3bb9013da8f99c7454730882e6f7
Author: Jonathan <jonross@chromium.org>
Date: Mon Nov 20 15:28:49 2017

Fix viz_content_browsertests filters
Fix filter files. They were incorrectly setting the test suite to only one test

TBR=kylechar@chromium.org
TEST=viz_content_browsertests

Bug:  760181 
Change-Id: I2a1af50f7cbaf9f5a24ba3e3083448f0b70a21b9
Reviewed-on: https://chromium-review.googlesource.com/779222
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517826}
[modify] https://crrev.com/4f5815c429af3bb9013da8f99c7454730882e6f7/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/4f5815c429af3bb9013da8f99c7454730882e6f7/testing/buildbot/filters/viz.content_browsertests.filter

Project Member

Comment 56 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61bb5cc5255b50e27da51cd2e0a84e1a0d3dacb0

commit 61bb5cc5255b50e27da51cd2e0a84e1a0d3dacb0
Author: Jonathan <jonross@chromium.org>
Date: Tue Nov 21 16:57:38 2017

Enable more passing OOPIF tests

Enable more oopif tests on viz_content_browsertests. First on the FYI to check
for flakes

TBR=kylechar@chromium.org
TEST=viz_content_browsertests

Bug:  760181 
Change-Id: Ib8ce31aee9a93910a0fe0023b920ef15f057c0ea
Reviewed-on: https://chromium-review.googlesource.com/781405
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518282}
[modify] https://crrev.com/61bb5cc5255b50e27da51cd2e0a84e1a0d3dacb0/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter

Project Member

Comment 57 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97517b1bdca71b627cfc2d2338f57c83c1854e89

commit 97517b1bdca71b627cfc2d2338f57c83c1854e89
Author: Jonathan <jonross@chromium.org>
Date: Tue Nov 21 19:44:47 2017

Enable viz_content_browsertests on Linux CQ

We enabled viz_content_browsertests on the linux fyi bot over the weekend, with
no new flakes nor failures appearing.

This enables them as a part of the main linux test package.

TBR=sky@chromium.org
TEST=viz_content_browsertests

Bug:  760181 
Change-Id: If86e8e551bf007124aea88073a3f57b51fff27a3
Reviewed-on: https://chromium-review.googlesource.com/779221
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518338}
[modify] https://crrev.com/97517b1bdca71b627cfc2d2338f57c83c1854e89/testing/buildbot/chromium.linux.json

Blockedon: 787941
Blockedon: 787945
Project Member

Comment 60 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/440a0fd645b8e356dcb8585653f7e595fcb12067

commit 440a0fd645b8e356dcb8585653f7e595fcb12067
Author: Jonathan <jonross@chromium.org>
Date: Wed Nov 22 21:46:39 2017

Enable more SitePerProcessBrowserTests in viz_content_browsertests

A lot of the SitePerProcessBrowserTests actually pass after the latest OOPIF
work. This updates the filter to allow those to run. With new categorization of
the failures that are still occurring.

TBR=kylechar@chromium.org
TEST=viz_content_browsertests

Bug:  760181 
Change-Id: Id6b5010a6cdb27541ef481df0e50cb760612e19d
Reviewed-on: https://chromium-review.googlesource.com/786299
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518759}
[modify] https://crrev.com/440a0fd645b8e356dcb8585653f7e595fcb12067/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter

Status: Started (was: Assigned)
Project Member

Comment 62 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c5c053174d1b1ebd9e3ae5f78eff73e5e7b7b71

commit 8c5c053174d1b1ebd9e3ae5f78eff73e5e7b7b71
Author: Jonathan <jonross@chromium.org>
Date: Fri Nov 24 15:32:10 2017

Update viz_content_browsertests filter

Several OOPIF tests were enabled on the FYI bot to confirm that they work.
They've been passing, so now I'm enabling them on the CQ filter.

TBR=kylechar@chromium.org
TEST=viz_content_browsertests

Bug:  760181 
Change-Id: Ia963816b589babc2598dc42bdcbd22150a3ca7be
Reviewed-on: https://chromium-review.googlesource.com/789051
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519118}
[modify] https://crrev.com/8c5c053174d1b1ebd9e3ae5f78eff73e5e7b7b71/testing/buildbot/filters/viz.content_browsertests.filter

Project Member

Comment 63 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bafd3a4018c9156f0f09c37bf6046c9d1acdaa2

commit 2bafd3a4018c9156f0f09c37bf6046c9d1acdaa2
Author: Jonathan <jonross@chromium.org>
Date: Fri Dec 01 20:18:11 2017

Disable SitePerProcessInternalsBrowserTest on FYI bots

Newly added SitePerProcessInternalsBrowserTest doesn't work under Viz. So I'm
disabling it on the FYI bots which run viz_content_browsertests

TBR=kylechar@chromium.org
TEST=SitePerProcessInternalsBrowserTest

Bug:  760181 
Change-Id: I714080f41f7f5c45811348c8da0a28631c272a35
Reviewed-on: https://chromium-review.googlesource.com/803801
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521032}
[modify] https://crrev.com/2bafd3a4018c9156f0f09c37bf6046c9d1acdaa2/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter

Project Member

Comment 64 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a85eca1d64ed41568704004c6ba4b84e761cf81e

commit a85eca1d64ed41568704004c6ba4b84e761cf81e
Author: Jonathan <jonross@chromium.org>
Date: Sat Dec 02 00:33:13 2017

Remove viz_content_browsertests from Linux Mojo FYI bot

The Linux Mojo FYI bot is intended for testing just network services, in
preparation for moving the tests to the CQ. However in the interim this can
sometimes be ran on the CQ.

viz_content_browsertests that run on the FYI bots are intented to sometimes
fail, and are not CQ ready.

Due to this I'm removing them from this config until I can find a more
appropriate FYI bot.


TEST=viz_content_browsertests

Bug:  760181 
Change-Id: Ia5a5712162d24267b8ce5414d2c1e59b73106171
Reviewed-on: https://chromium-review.googlesource.com/803800
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521150}
[modify] https://crrev.com/a85eca1d64ed41568704004c6ba4b84e761cf81e/testing/buildbot/chromium.fyi.json

Blockedon: 791557
Project Member

Comment 66 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4e832242cfae1a1c8a5655f95cabcafc44a3969

commit e4e832242cfae1a1c8a5655f95cabcafc44a3969
Author: Jonathan <jonross@chromium.org>
Date: Tue Dec 05 18:55:06 2017

Update viz_content_browsertests filters

Synchronize the FYI and CQ filters, as flakes were recently only added to CQ.
Also enable another test which is working.

TBR=kylechar@chromium.org
TEST=viz_content_browsertests

Bug:  760181 
Change-Id: If57709368548f82fb8473cb5ce2008de76a4b6f1
Reviewed-on: https://chromium-review.googlesource.com/809230
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521766}
[modify] https://crrev.com/e4e832242cfae1a1c8a5655f95cabcafc44a3969/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/e4e832242cfae1a1c8a5655f95cabcafc44a3969/testing/buildbot/filters/viz.content_browsertests.filter

Blockedon: 793302
Project Member

Comment 68 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7a0c064e4607097ed3495e192aa2c47cf69ac7e

commit d7a0c064e4607097ed3495e192aa2c47cf69ac7e
Author: Jonathan Ross <jonross@chromium.org>
Date: Tue Dec 12 18:42:28 2017

Add viz_content_browsertests to a Win FYI bot

We want to get coverage of viz_content_browsertests on Windows.

This adds the test config to the FYI Mojo Windows bot. I've ran them
locally, and the current test filter is accurate.

TEST=viz_content_browsertests

Bug:  760181 
Change-Id: Idcb2069188a769a58ffc53e2171e2661a5e09540
Reviewed-on: https://chromium-review.googlesource.com/820161
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523487}
[modify] https://crrev.com/d7a0c064e4607097ed3495e192aa2c47cf69ac7e/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/d7a0c064e4607097ed3495e192aa2c47cf69ac7e/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/d7a0c064e4607097ed3495e192aa2c47cf69ac7e/testing/buildbot/test_suites.pyl

Project Member

Comment 69 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f3d6dedad0e82bc076754f88d28c66ea61a7856

commit 2f3d6dedad0e82bc076754f88d28c66ea61a7856
Author: Jonathan <jonross@chromium.org>
Date: Wed Dec 13 18:27:24 2017

Speculative Fix for missing test filter

The Mojo Windows bot cannot find the test filter. This change updates the path
to be more specific. Like that of the Cast Linux testing filter

TEST=viz_content_browsertest

Bug:  760181 
Change-Id: Ib2516b5c0dd5513b4acf56f8083e5bd47fe7719f
Reviewed-on: https://chromium-review.googlesource.com/822659
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523828}
[modify] https://crrev.com/2f3d6dedad0e82bc076754f88d28c66ea61a7856/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/2f3d6dedad0e82bc076754f88d28c66ea61a7856/testing/buildbot/waterfalls.pyl

Blockedon: 795033
Project Member

Comment 71 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae2267d900257e82fec3096631f652531cccf95f

commit ae2267d900257e82fec3096631f652531cccf95f
Author: Jonathan <jonross@chromium.org>
Date: Mon Dec 18 15:12:18 2017

Remove viz_content_browsertests exceptions

viz_content_browsertests has exceptions on 3 bots. This is just
because we never manually added them to these bots in the old format of
configuring bots.

TEST=ran the associated trybots for viz_content_browsertests

Bug:  760181 
Change-Id: I9c197c4ab906aad35522c49a0f618925d7ca258d
Reviewed-on: https://chromium-review.googlesource.com/829654
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524709}
[modify] https://crrev.com/ae2267d900257e82fec3096631f652531cccf95f/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/ae2267d900257e82fec3096631f652531cccf95f/testing/buildbot/chromium.sandbox.json
[modify] https://crrev.com/ae2267d900257e82fec3096631f652531cccf95f/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 72 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/036f31ff0b9e3291c45a80551b2fe6e6a3cb8ef1

commit 036f31ff0b9e3291c45a80551b2fe6e6a3cb8ef1
Author: Jonathan <jonross@chromium.org>
Date: Tue Dec 19 00:34:21 2017

Consolidate viz test configurations

The current configurations for viz_content_browsertests were spread out across
each of the bots. This change creates consolidates them all into viz_gtests and
viz_fyi_gtests. Allowing us to have one set of tests enabled on the main cq and
another that we are trying out on FYI bots.

This also lets us set the filter files without needing a long list of
exceptions for each individual bot.

This also adds viz_content_unittests to the FYI bots so that we can start
getting coverage there.

This also expands viz_browsertests to Linux and Chrome OS, from just Windows.

Bug:  760181 
Change-Id: Ie8ab7a9f9b689490eb9b2b1645f0b200ba717e37
Reviewed-on: https://chromium-review.googlesource.com/833148
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524882}
[modify] https://crrev.com/036f31ff0b9e3291c45a80551b2fe6e6a3cb8ef1/content/test/BUILD.gn
[modify] https://crrev.com/036f31ff0b9e3291c45a80551b2fe6e6a3cb8ef1/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/036f31ff0b9e3291c45a80551b2fe6e6a3cb8ef1/testing/buildbot/filters/BUILD.gn
[add] https://crrev.com/036f31ff0b9e3291c45a80551b2fe6e6a3cb8ef1/testing/buildbot/filters/viz.content_unittests.filter
[modify] https://crrev.com/036f31ff0b9e3291c45a80551b2fe6e6a3cb8ef1/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/036f31ff0b9e3291c45a80551b2fe6e6a3cb8ef1/testing/buildbot/waterfalls.pyl

Project Member

Comment 73 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1663dc2635b74978b02e921680992732f1a16b96

commit 1663dc2635b74978b02e921680992732f1a16b96
Author: Jonathan <jonross@chromium.org>
Date: Tue Dec 19 17:21:28 2017

Fix typo in FYI config

In my last change: https://chromium-review.googlesource.com/c/chromium/src/+/833148
there was a typo of the filter file. But since this was for FYI bots it isn't
caught at submission time.

Fixing the typo to clear up the FYI bots.

TBR=dpranke@chromium.org

Bug:  760181 
Change-Id: I0120f1ed36d452235622a133eca931947aaa5f06
Reviewed-on: https://chromium-review.googlesource.com/833420
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525067}
[modify] https://crrev.com/1663dc2635b74978b02e921680992732f1a16b96/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/1663dc2635b74978b02e921680992732f1a16b96/testing/buildbot/test_suites.pyl

Project Member

Comment 74 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c3b2ef54ceb57eeb14c316fb9ef56da16bc395e

commit 7c3b2ef54ceb57eeb14c316fb9ef56da16bc395e
Author: Jonathan <jonross@chromium.org>
Date: Thu Dec 21 19:19:39 2017

Update Viz test filters

New tests failed, this updates the filters for those failures. Bugs have been
associated with each.

TBR=kylechar@chromium.org

Bug:  760181 
Change-Id: I85a1ced34b932710bcf514223d31bf5a2ad7c93f
Reviewed-on: https://chromium-review.googlesource.com/840642
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525762}
[modify] https://crrev.com/7c3b2ef54ceb57eeb14c316fb9ef56da16bc395e/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/7c3b2ef54ceb57eeb14c316fb9ef56da16bc395e/testing/buildbot/filters/viz.content_browsertests.filter
[modify] https://crrev.com/7c3b2ef54ceb57eeb14c316fb9ef56da16bc395e/testing/buildbot/filters/viz.content_unittests.filter

Project Member

Comment 75 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fc212cb175d7168f646a112ed3d3228eb651fde

commit 5fc212cb175d7168f646a112ed3d3228eb651fde
Author: Jonathan <jonross@chromium.org>
Date: Tue Jan 09 18:09:59 2018

Update viz_content_browsertests filter

A new failing test was added and filtered on cq. I'm adding it to the FYI filter

TBR=kylechar@chromium.org
TEST=SitePerProcessBrowserTest.OverlapSurfaceHitTestTest

Bug:  760181 
Change-Id: Ifc5e6e3428407cd33aa3f3e2aa0c21d1e2f62ab2
Reviewed-on: https://chromium-review.googlesource.com/857582
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528043}
[modify] https://crrev.com/5fc212cb175d7168f646a112ed3d3228eb651fde/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter

Project Member

Comment 76 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b768fa508f99dd9a6a4cf7689d6ecccd1b66a5fb

commit b768fa508f99dd9a6a4cf7689d6ecccd1b66a5fb
Author: Jonathan <jonross@chromium.org>
Date: Thu Jan 11 22:19:45 2018

Update Viz FYI filter

New failures in viz_content_browsertests were filtered on main, but not the
FYI. This updates the FYI filter.

Also update the order in the main viz.content_browsertests filter.

TBR=kylechar@chromium.org

Bug:  760181 
Change-Id: Idef3a317011f86364a403e61bcf03c54697259a8
Reviewed-on: https://chromium-review.googlesource.com/862622
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528781}
[modify] https://crrev.com/b768fa508f99dd9a6a4cf7689d6ecccd1b66a5fb/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/b768fa508f99dd9a6a4cf7689d6ecccd1b66a5fb/testing/buildbot/filters/viz.content_browsertests.filter

Project Member

Comment 77 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42a02e6487dfce03d269431c1102a1ccd81e1908

commit 42a02e6487dfce03d269431c1102a1ccd81e1908
Author: Jonathan <jonross@chromium.org>
Date: Tue Jan 16 01:57:06 2018

Add viz_content_unittests and viz_content_browsertests to Win CQ

We've been testing both content_unittests and content_browserttests with
--enable-viz on a Windows FYI bot. Both have become stable. I'm adding them to
the main bots to get earlier coverage of bugs.

TBR=sky@chromium.org
TEST=viz_content_unittests, viz_content_browsertests

Bug:  760181 
Change-Id: I2a261bbe6d733c98bea636f87aa6fe89e99c094d
Reviewed-on: https://chromium-review.googlesource.com/867454
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529355}
[modify] https://crrev.com/42a02e6487dfce03d269431c1102a1ccd81e1908/testing/buildbot/chromium.win.json
[modify] https://crrev.com/42a02e6487dfce03d269431c1102a1ccd81e1908/testing/buildbot/test_suites.pyl

Project Member

Comment 78 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e1f0f71566c14ca0aaab840ff6a0d63fac64365

commit 4e1f0f71566c14ca0aaab840ff6a0d63fac64365
Author: jonross <jonross@chromium.org>
Date: Tue Jan 23 19:34:54 2018

Update viz test filters

Upadte viz filters for new failures.

TBR=kylechar@chromium.org
TEST=viz_browser_tests, viz_content_browsertests

Bug:  760181 
Change-Id: I7240da12372b5ebaf6774f21d42cadfdebecfd31
Reviewed-on: https://chromium-review.googlesource.com/881306
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531303}
[modify] https://crrev.com/4e1f0f71566c14ca0aaab840ff6a0d63fac64365/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/4e1f0f71566c14ca0aaab840ff6a0d63fac64365/testing/buildbot/filters/viz.browser_tests.filter

Project Member

Comment 79 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3922f113c0799059bbdf96bc4d4ea7620d56417e

commit 3922f113c0799059bbdf96bc4d4ea7620d56417e
Author: jonross <jonross@chromium.org>
Date: Thu Jan 25 17:26:55 2018

Update Viz FYI filter

I've updated the Viz FYI filter for content_browsertests to match the one used
on the CQ. To account for renamed tests.

TBR=kylechar@chromium.org

Bug:  760181 
Change-Id: I5c86a182c5240a324aaa7afa147f5373163b9930
Reviewed-on: https://chromium-review.googlesource.com/886659
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531930}
[modify] https://crrev.com/3922f113c0799059bbdf96bc4d4ea7620d56417e/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter

Project Member

Comment 80 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56e8e7caf6920f4c3ed31b2cfac7d4c6132bdcd6

commit 56e8e7caf6920f4c3ed31b2cfac7d4c6132bdcd6
Author: jonross <jonross@chromium.org>
Date: Mon Jan 29 16:07:00 2018

Add Viz FYI tests to Mac FYI

We want to gain FYI coverage of Viz on Mac. So that we can identify any flakes
before enabling on the CQ

TBR=sky@chromium.org
TEST=viz_browser_tests, viz_content_browsertests, viz_content_unittests

Bug:  760181 
Change-Id: Ic8abfafbd3bc66fbb9f5e5af45b9716301532e18
Reviewed-on: https://chromium-review.googlesource.com/886658
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532446}
[modify] https://crrev.com/56e8e7caf6920f4c3ed31b2cfac7d4c6132bdcd6/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/56e8e7caf6920f4c3ed31b2cfac7d4c6132bdcd6/testing/buildbot/test_suites.pyl

Project Member

Comment 81 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b56f01b89dc371b18c662ce1533878d811a801e

commit 5b56f01b89dc371b18c662ce1533878d811a801e
Author: jonross <jonross@chromium.org>
Date: Fri Feb 02 15:04:55 2018

Update Viz test filters for FYI failures

New tests began failing on the FYI bots, this updates the filters to reflect
that.

Also the tests have been added to Mac FYI bots, so I'm filtering the first set
of filters to look for further flakes. I will triage them and update filter
accordingly

TBBR=kylechar@chromium.org
TEST=viz_browser_tests, viz_content_browsertests, viz_content_unittests

Bug:  760181 
Change-Id: I02b93e7adafa545b01a13d0be67b838987fca1b5
Reviewed-on: https://chromium-review.googlesource.com/898609
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534050}
[modify] https://crrev.com/5b56f01b89dc371b18c662ce1533878d811a801e/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/5b56f01b89dc371b18c662ce1533878d811a801e/testing/buildbot/filters/viz.browser_tests.filter
[modify] https://crrev.com/5b56f01b89dc371b18c662ce1533878d811a801e/testing/buildbot/filters/viz.content_unittests.filter

Project Member

Comment 82 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c16d4b735b4d0736ee7d49f13c815f348719b50d

commit c16d4b735b4d0736ee7d49f13c815f348719b50d
Author: jonross <jonross@chromium.org>
Date: Thu Feb 08 15:10:55 2018

Update viz_browser_tests filter

Update the filter for FYI bots to address a new CopyOutputRequest failure,
along with some remaining Mac failures.

TBR=kylechar@chromium.org

Bug:  760181 
Change-Id: Ifa12410a93ff28cf8a79433eb5925ad0deaa125d
Reviewed-on: https://chromium-review.googlesource.com/908632
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535378}
[modify] https://crrev.com/c16d4b735b4d0736ee7d49f13c815f348719b50d/testing/buildbot/filters/viz.browser_tests.filter

Cc: gov...@chromium.org
Just to update:

Observed linux 64 browser test failed.

Link to the builder:
-------------------
https://uberchromegw.corp.google.com/i/official.desktop/builders/linux64/builds/1123

Error log path:
--------------
https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop%2Flinux64%2F1123%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests%2F0%2Fstdout#

Updating this issue fro tracking purpose.

Thanks..!
From the that builder it appears that two tests is the non-viz version of content_browsertests failed. It also looks like a flake as they only failed once.

We're using this issue to track what is needed to support content_browsertests with the VizDisplayCompositor feature on.

Could you file a separate issue for those flake and assign to the owner of the test? Thanks
Project Member

Comment 85 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba45d7e2aa517b33a35169c07a2fb3f06a772343

commit ba45d7e2aa517b33a35169c07a2fb3f06a772343
Author: jonross <jonross@chromium.org>
Date: Thu Mar 01 15:05:17 2018

Update Viz FYI Filters

More tests have been fixed, re-enabling on FYI to start to verify no flakes.

TBR=kylechar@chromium.org
TEST=viz_content_browsertests, viz_browser_tests

Bug:  760181 
Change-Id: I3d27ff8372fbe10b46efeb074f2bf07d60e14f43
Reviewed-on: https://chromium-review.googlesource.com/943243
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540157}
[modify] https://crrev.com/ba45d7e2aa517b33a35169c07a2fb3f06a772343/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/ba45d7e2aa517b33a35169c07a2fb3f06a772343/testing/buildbot/filters/viz.browser_tests.filter

Blockedon: 817827
Blockedon: 817830
Project Member

Comment 88 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a0533a54ecaa935b7f923b13d4dba8e80c158ff

commit 7a0533a54ecaa935b7f923b13d4dba8e80c158ff
Author: jonross <jonross@chromium.org>
Date: Fri Mar 02 16:13:18 2018

Update Viz FYI Filters for Mac

We've now triagged all of the Mac specific failures that have been seen when
running viz tests on Mac FYI bots. This updates the filter files to document
which bug is tracking the failures for which tests.

TBR=kylechar@chromium.org

Bug:  760181 
Change-Id: I0ef68761fd8be57619d35ed9a8de87dbfbd59132
Reviewed-on: https://chromium-review.googlesource.com/946127
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540527}
[modify] https://crrev.com/7a0533a54ecaa935b7f923b13d4dba8e80c158ff/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/7a0533a54ecaa935b7f923b13d4dba8e80c158ff/testing/buildbot/filters/viz.browser_tests.filter
[modify] https://crrev.com/7a0533a54ecaa935b7f923b13d4dba8e80c158ff/testing/buildbot/filters/viz.content_unittests.filter

Blockedon: 812012
Blockedon: 820437
Project Member

Comment 91 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54350857d70565e5004991e84c2b1a4e24afd22a

commit 54350857d70565e5004991e84c2b1a4e24afd22a
Author: jonross <jonross@chromium.org>
Date: Fri Mar 09 20:56:10 2018

Update Viz Filters

A series of tests across viz_browser_tests, viz_content_browsertests, and
viz_content_unittests have been fixed. This change re-enables them.

At the same time it updates the ordering of the filter files to reflect some
recent triaging. Grouping together similar root-cause issues.

TBR=kylechar@chromium.org

Bug:  760181 
Change-Id: Ib7040cd995cfdd7d92f3c3e677b87ebcaf920bc5
Reviewed-on: https://chromium-review.googlesource.com/957319
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542213}
[modify] https://crrev.com/54350857d70565e5004991e84c2b1a4e24afd22a/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/54350857d70565e5004991e84c2b1a4e24afd22a/testing/buildbot/filters/viz.browser_tests.filter
[modify] https://crrev.com/54350857d70565e5004991e84c2b1a4e24afd22a/testing/buildbot/filters/viz.content_browsertests.filter
[modify] https://crrev.com/54350857d70565e5004991e84c2b1a4e24afd22a/testing/buildbot/filters/viz.content_unittests.filter

Blockedon: -791557
Project Member

Comment 93 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58b49ba3c944e8e2952257981cef41d2ea9f32a2

commit 58b49ba3c944e8e2952257981cef41d2ea9f32a2
Author: jonross <jonross@chromium.org>
Date: Tue Mar 13 20:36:02 2018

Re-enable previously flaking Viz tests

A few tests had been flaking on viz configs. Some have since shown themselves to
be flaking everywhere. Others have been triaged to have been caused by now fixed
issues.

This change updates the filter to re-enable one on viz_browser_tests. While only
re-enabling some on the FYI bot for viz_content_browsertests.

TBR=kylerchar@chromium.org
TEST=viz_browser_tests, viz_content_browsertests

Bug:  760181 
Change-Id: I08e643dd8074ab3b7a4d6bbbe72063da81d21b04
Reviewed-on: https://chromium-review.googlesource.com/961262
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542900}
[modify] https://crrev.com/58b49ba3c944e8e2952257981cef41d2ea9f32a2/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/58b49ba3c944e8e2952257981cef41d2ea9f32a2/testing/buildbot/filters/viz.browser_tests.filter

Blockedon: 823276
Project Member

Comment 95 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2be0e102f2a639baec0e6bccc357148e386a8efa

commit 2be0e102f2a639baec0e6bccc357148e386a8efa
Author: jonross <jonross@chromium.org>
Date: Mon Mar 19 13:40:58 2018

Update Viz testing filters for Mac

Filter out new consisten Mac filters in viz_content_browsertests and
viz_browser_tests

TEST=viz_browser_tests, viz_content_browsertests_
TBR=kylechar@chromium.org

Bug:  760181 
Change-Id: Idde59c0abb342a19bf5539b4771ea7aca586bc51
Reviewed-on: https://chromium-review.googlesource.com/968545
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544019}
[modify] https://crrev.com/2be0e102f2a639baec0e6bccc357148e386a8efa/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/2be0e102f2a639baec0e6bccc357148e386a8efa/testing/buildbot/filters/viz.browser_tests.filter

Project Member

Comment 96 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/660a75731769882a06c5f67bdfb3d3c012b496cc

commit 660a75731769882a06c5f67bdfb3d3c012b496cc
Author: jonross <jonross@chromium.org>
Date: Mon Mar 19 16:58:09 2018

Fix racy TouchActionBrowserTest

The usage of RenderFrameSubmissionObserver in TouchActionBrowserTest is racy.
This change updates the ownership of the observer to avoid that.

Bug:  760181 
Change-Id: I23eaab201d478a6a8948893f10158e8c9c4c4d44
Reviewed-on: https://chromium-review.googlesource.com/964241
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544066}
[modify] https://crrev.com/660a75731769882a06c5f67bdfb3d3c012b496cc/content/browser/renderer_host/input/touch_action_browsertest.cc

Project Member

Comment 97 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb9d8f2850e74ff10c9e70301ba8d8b0842b30e

commit 7fb9d8f2850e74ff10c9e70301ba8d8b0842b30e
Author: jonross <jonross@chromium.org>
Date: Mon Mar 19 20:36:25 2018

Remove FYI Viz testing filter

viz_content_browsertests has stabilized. Due to this we no longer need a
separate filter for the FYI bots to first try out new tests for flakes. So I am
removing the FYI filter file. (We are already not using FYI filters for the
other viz tests)

This change updates the viz.content_browsertests.filter file with the
remaining differences from the FYI filter. Then removes the fyi one. Updating
the test configs to use the full one

TEST=viz_content_browsertests

Bug:  760181 
Change-Id: I949f0e74974f9f9cd847323e97c99d9a0b403b81
Reviewed-on: https://chromium-review.googlesource.com/968703
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544147}
[modify] https://crrev.com/7fb9d8f2850e74ff10c9e70301ba8d8b0842b30e/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/7fb9d8f2850e74ff10c9e70301ba8d8b0842b30e/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/432056bb7d5f8f0c8b2fa9661d22b60517d010f2/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
[modify] https://crrev.com/7fb9d8f2850e74ff10c9e70301ba8d8b0842b30e/testing/buildbot/filters/viz.content_browsertests.filter
[modify] https://crrev.com/7fb9d8f2850e74ff10c9e70301ba8d8b0842b30e/testing/buildbot/test_suites.pyl

Project Member

Comment 98 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da1ad7139d072ab49b3339295d9311d3968664e6

commit da1ad7139d072ab49b3339295d9311d3968664e6
Author: jonross <jonross@chromium.org>
Date: Tue Mar 20 17:49:56 2018

Update Viz filter for Mac

A test that is disabled completely on all non-mac bots for flakes fails under
Viz. It relies on ui::LatencyInfo which is not available. So I'm disabling it
to clear up the Mac bots.

TBR=kylechar@chromium.org
TEST=MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated

Bug:  760181 
Change-Id: I8b656c032b408738b7040f0dc8c52a03e9477b27
Reviewed-on: https://chromium-review.googlesource.com/971354
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544432}
[modify] https://crrev.com/da1ad7139d072ab49b3339295d9311d3968664e6/testing/buildbot/filters/viz.content_browsertests.filter

Project Member

Comment 99 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a3c45bfb30c112ca572eea8e5f46e998a42c52d

commit 2a3c45bfb30c112ca572eea8e5f46e998a42c52d
Author: Sahel Sharify <sahel@chromium.org>
Date: Mon Mar 26 14:19:23 2018

Remove accidental restoration of FYI Viz testing filter.

https://chromium-review.googlesource.com/931998 has accidentally added
testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter back
which was deleted in https://chromium-review.googlesource.com/968703.
This cl deletes the file again to undo the unwanted change.

Bug:  760181 
Change-Id: I67bb96e33b4f4e905c137f73400f44b52173fc41
Reviewed-on: https://chromium-review.googlesource.com/978851
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545781}
[delete] https://crrev.com/28d25db2f01ebe5e1b602a2678b24397ac55f9ee/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter

Project Member

Comment 100 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/217626a087e689a82a01994156e94b7898a476c0

commit 217626a087e689a82a01994156e94b7898a476c0
Author: jonross <jonross@chromium.org>
Date: Fri May 11 19:29:45 2018

Update Viz Filters for Mac

There had ben a series of Mac testing failures tracked by  issue 817827 ,  817830 .

These have been fixed, so re-enabling the tests.

TBR=fsamuel@chromium.org
TEST=viz_browser_tests, viz_content_browsertests

Bug:  760181 
Change-Id: I4df4a3cdb659a4226dcd9b2a3e174bf41e064052
Reviewed-on: https://chromium-review.googlesource.com/1055664
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557977}
[modify] https://crrev.com/217626a087e689a82a01994156e94b7898a476c0/testing/buildbot/filters/viz.browser_tests.filter
[modify] https://crrev.com/217626a087e689a82a01994156e94b7898a476c0/testing/buildbot/filters/viz.content_browsertests.filter

Cc: -varkha@chromium.org
Cc: -staraz@chromium.org
Blockedon: 842325
Blockedon: 842664
Blockedon: 847836
Blockedon: 849283
Project Member

Comment 107 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6199daf333a282a3bcc6df66d090025f551ffae3

commit 6199daf333a282a3bcc6df66d090025f551ffae3
Author: jonross <jonross@chromium.org>
Date: Wed Jun 13 19:55:58 2018

Update Viz Filter for generally disabled tests

Previously two tests were disabled on Viz due to flakiness. Since then it was
determined that these tests were flaking even without Viz and have been
disabled on the according platforms.

This removes them from the Viz testing filter.

TBR=kylechar@chromium.org
TEST=MouseLatencyBrowserTest.CoalescedMouseMovesCorrectlyTerminated
MainThreadEventQueueBrowserTest.MouseMove

Bug:  760181 
Change-Id: Ie686d7925cb0413542a68cf72bda68295500ca56
Reviewed-on: https://chromium-review.googlesource.com/1099716
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566959}
[modify] https://crrev.com/6199daf333a282a3bcc6df66d090025f551ffae3/testing/buildbot/filters/viz.content_browsertests.filter

Status: Fixed (was: Started)
All test utils that were affected by the split have been updated.

All tests that were affected by the split have been updated. We have full CQ coverage of these tests as well for our upcoming Finches.

There are separate issues tracking CQ work for future OSes.
The known failures are tracked separately.

So I'm marking this as fixed.
Showing comments 9 - 108 of 108 Older

Sign in to add a comment