New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760163 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

28.1% regression in blink_perf.bindings at 495809:495816

Project Member Reported by pmeenan@chromium.org, Aug 29 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 29 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=760163

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=8d45d58ec94c3777826272d15b00a006a6957d81e619eb23fb7ad74c591e0b31


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 29 2017

Cc: mlippautz@chromium.org
Owner: mlippautz@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author mlippautz@chromium.org ===

Hi mlippautz@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Michael Lippautz
  Commit : ac528b27b356ecddcf4c400c7de996eefd7f8e38
  Date   : Sat Aug 19 10:43:55 2017
  Subject: [wrapper-tracing] Enable use of mixins for values

Bisect Details
  Configuration: win_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : insert-before/insert-before
  Change       : 2.67% | 44.0169030707 -> 42.8422651974

Revision             Result                   N
chromium@495808      44.0169 +- 4.49456       21      good
chromium@495809      43.997 +- 1.5291         6       good
chromium@495810      42.8049 +- 1.13663       9       bad       <--
chromium@495812      42.6595 +- 0.696422      9       bad
chromium@495816      42.8423 +- 0.706132      14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8969912336097196624


For feedback, file a bug with component Speed>Bisection
mlippautz: any update on this bug?
Cc: -mlippautz@chromium.org
Status: WontFix (was: Assigned)
Thanks for pinging!

A small regression like this one is expected for this commit. The CL improves general infrastructure by generalizing the approach a bit.
Cc: jbroman@chromium.org
Thanks for the explanation. cc-ing test owner jbroman as FYI.

Sign in to add a comment