Blink-side UseCounter should only track http:// or https:// URLs. Drop file:// for now which matches the behaviour of browser-side UseCounter (for comparison reasons)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a03887f2fadc4123ee96e5bdf6a84a7488a37424 commit a03887f2fadc4123ee96e5bdf6a84a7488a37424 Author: Luna Lu <loonybear@chromium.org> Date: Mon Nov 20 21:30:47 2017 Match blink side UseCounter policy to page_load_metrics 1.Drop NTP Activities in UseCounter FeaturesHistogram - Plumbing through Page::DidCommitLoad > blink::LocalFrameClient(Impl)::ShouldTrackUseCounter > blink::WebFrameClient(content::RendererFrameImpl)::ShouldTrackUseCounter > ChromeContentRendererClient::ShouldTrackUseCounter > SearchBouncer::IsNewTabPage() - Added unit tests for ChromeContentRendererClient - Added browser tests in chrome/browser/ui/search/local_ntp_browsertest.cc 2.Drop counts for "file://" - Modified SchemeRegistry::ShouldTrackUsageMetricsForScheme 3.Moved third_party/WebKit/LayoutTests/fast/workers/shared-worker-usecounter.html to third_party/WebKit/LayoutTests/http/tests/workers/shared-worker-usecounter.html to use http:// scheme instead of file:// scheme TBR:nhiroki Bug: 760111 , 760115 Change-Id: I8768c5bbf8c146e100bc22114c0f5180fd42ee8b Reviewed-on: https://chromium-review.googlesource.com/766954 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#517932} [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/chrome/browser/ui/search/local_ntp_browsertest.cc [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/chrome/renderer/chrome_content_renderer_client.h [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/chrome/renderer/chrome_content_renderer_client_unittest.cc [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/content/public/renderer/content_renderer_client.cc [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/content/public/renderer/content_renderer_client.h [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/content/renderer/render_frame_impl.cc [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/content/renderer/render_frame_impl.h [rename] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/LayoutTests/http/tests/workers/resources/shared-worker-usecounter-window.html [rename] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/LayoutTests/http/tests/workers/resources/shared-worker-usecounter.js [rename] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/LayoutTests/http/tests/workers/shared-worker-usecounter.html [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/Source/core/frame/LocalFrameClient.h [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/Source/core/frame/UseCounterTest.cpp [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/Source/core/page/Page.cpp [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp [modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/public/web/WebFrameClient.h
Comment 1 by loonyb...@chromium.org
, Aug 29 2017