New issue
Advanced search Search tips

Issue 760111 link

Starred by 1 user
Status: Fixed
Owner:
loonyb...@chromium.org
Closed: Nov 2017
Cc:
rbyers@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Drop Blink-side UseCounter usage tracking in NTP activities

Project Member Reported by loonyb...@chromium.org, Aug 29 2017 
UseCounter should exclude chrome-only feature usage (e.g. chrome://, chrome-devtools:// URLs). Currently Blink-side UseCounter (to be deprecated) is tracking NTP activities and browser-side UseCounter is not. To verify that browser-side UseCounter is behaving similarly to the blink-side UseCounter (so that it can replace the blink-side one), drop NTP activities in blink-side UseCounter.

Comment 1 by cha...@chromium.org, Sep 8 2017

Components: -Blink>Infra>Predictability Internals>FeatureControl
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a03887f2fadc4123ee96e5bdf6a84a7488a37424

commit a03887f2fadc4123ee96e5bdf6a84a7488a37424
Author: Luna Lu <loonybear@chromium.org>
Date: Mon Nov 20 21:30:47 2017

Match blink side UseCounter policy to page_load_metrics

1.Drop NTP Activities in UseCounter FeaturesHistogram
- Plumbing through Page::DidCommitLoad
                 > blink::LocalFrameClient(Impl)::ShouldTrackUseCounter
                 > blink::WebFrameClient(content::RendererFrameImpl)::ShouldTrackUseCounter
                 > ChromeContentRendererClient::ShouldTrackUseCounter
                 > SearchBouncer::IsNewTabPage()
- Added unit tests for ChromeContentRendererClient
- Added browser tests in chrome/browser/ui/search/local_ntp_browsertest.cc

2.Drop counts for "file://"
- Modified SchemeRegistry::ShouldTrackUsageMetricsForScheme

3.Moved third_party/WebKit/LayoutTests/fast/workers/shared-worker-usecounter.html
to third_party/WebKit/LayoutTests/http/tests/workers/shared-worker-usecounter.html
to use http:// scheme instead of file:// scheme

TBR:nhiroki

Bug:  760111 , 760115 
Change-Id: I8768c5bbf8c146e100bc22114c0f5180fd42ee8b
Reviewed-on: https://chromium-review.googlesource.com/766954
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517932}
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/chrome/renderer/chrome_content_renderer_client.h
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/chrome/renderer/chrome_content_renderer_client_unittest.cc
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/content/renderer/render_frame_impl.h
[rename] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/LayoutTests/http/tests/workers/resources/shared-worker-usecounter-window.html
[rename] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/LayoutTests/http/tests/workers/resources/shared-worker-usecounter.js
[rename] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/LayoutTests/http/tests/workers/shared-worker-usecounter.html
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/Source/core/frame/UseCounterTest.cpp
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp
[modify] https://crrev.com/a03887f2fadc4123ee96e5bdf6a84a7488a37424/third_party/WebKit/public/web/WebFrameClient.h

Comment 3 by loonyb...@chromium.org, Nov 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment