Browser-side UseCounter track PageVisits |
|||
Issue descriptionTrack PageVisists in PageLoadMetricsObserver::OnCommit() (for every tracked page load). No render process ought to be brought up until commit for browser-initiated navigation ==> verify that no other feature usage is tracked before commit (PageVisits usage) Also check that PageVisists is tracked at most once per observer
,
Sep 8 2017
,
Sep 21 2017
loonybear@ Do you have an update on this? Is this actually P1?
,
Sep 22 2017
Sorry have been on vacation in early Sept. I am working on it at the moment.
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/309089e7dba0e7c7fe2f608f4fc9b3642c76fd4c commit 309089e7dba0e7c7fe2f608f4fc9b3642c76fd4c Author: Luna Lu <loonybear@chromium.org> Date: Thu Sep 28 15:26:05 2017 Browser-side UseCounter track kPageVisits in PageLoadMetricsObserver::OnCommit Bug: 760110 Change-Id: I7c8e70af3cb5b58939a762d577b5374c54638aed Reviewed-on: https://chromium-review.googlesource.com/687574 Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#505031} [modify] https://crrev.com/309089e7dba0e7c7fe2f608f4fc9b3642c76fd4c/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.cc [modify] https://crrev.com/309089e7dba0e7c7fe2f608f4fc9b3642c76fd4c/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.h [modify] https://crrev.com/309089e7dba0e7c7fe2f608f4fc9b3642c76fd4c/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/309089e7dba0e7c7fe2f608f4fc9b3642c76fd4c/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
,
Sep 28 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by loonyb...@chromium.org
, Aug 29 2017