The recent change made in crbug.com/754169 seems to introduce a new failure path with uncaught exception. Example log: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-importer%2F987%2F%2B%2Frecipes%2Fsteps%2FImport_changes_from_WPT_to_Chromium%2F0%2Fstdout When wait_for_try_jobs times out, the returned try_results is None and we try to filter them using dictionary comprehension, which leads to AttributeError.
Darn, I should have tested this case. Thanks for filing a bug ad linking to the log and describing the error :-) Fix CL: https://chromium-review.googlesource.com/641787
This also happened in https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/1022 (was about to file a new bug)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5f64803582b166ac7ffb10efd70c3e2e2e5b1b0 commit f5f64803582b166ac7ffb10efd70c3e2e2e5b1b0 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Fri Sep 01 20:36:17 2017 WPT import: Handle case where wait_for_try_jobs returns None Bug: 760108 Change-Id: I983d86b19c4a7659de170b21cbedb8202a381737 Reviewed-on: https://chromium-review.googlesource.com/641787 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#499282} [modify] https://crrev.com/f5f64803582b166ac7ffb10efd70c3e2e2e5b1b0/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_mock.py [modify] https://crrev.com/f5f64803582b166ac7ffb10efd70c3e2e2e5b1b0/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py [modify] https://crrev.com/f5f64803582b166ac7ffb10efd70c3e2e2e5b1b0/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
Comment 1 by qyears...@chromium.org
, Aug 29 2017Owner: qyears...@chromium.org
Status: Started (was: Available)