Reference: go/feature-flags-on-ios The function IsPhysicalWebEnabled() should be removed from experimental_flags and either replaced by a base::Feature or excised from the code along with all the physical web code.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e826d2feadcc2a76101a42bc13461c6e82b3a65f commit e826d2feadcc2a76101a42bc13461c6e82b3a65f Author: Eric Noyau <noyau@google.com> Date: Thu Aug 31 09:48:02 2017 Removing Physical web flags Bug: 760104 Change-Id: Ic6cbb67ff45c896d992aae86b0402e7a130753b3 Reviewed-on: https://chromium-review.googlesource.com/641491 Commit-Queue: Eric Noyau <noyau@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#498799} [modify] https://crrev.com/e826d2feadcc2a76101a42bc13461c6e82b3a65f/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/e826d2feadcc2a76101a42bc13461c6e82b3a65f/ios/chrome/browser/chrome_switches.cc [modify] https://crrev.com/e826d2feadcc2a76101a42bc13461c6e82b3a65f/ios/chrome/browser/chrome_switches.h [modify] https://crrev.com/e826d2feadcc2a76101a42bc13461c6e82b3a65f/ios/chrome/browser/experimental_flags.mm [modify] https://crrev.com/e826d2feadcc2a76101a42bc13461c6e82b3a65f/ios/chrome/browser/resources/Settings.bundle/Experimental.plist
Re-opening as the function still exists in experimental_flags.mm with a reference to this bug.
Hi Olivier, can you check if this is fixed? If not, can you clean it up? thanks!
Taking over this bug as part of removing Physical Web on iOS
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/6ebee3a832e617a48eb77e738f7ad46914132e4f commit 6ebee3a832e617a48eb77e738f7ad46914132e4f Author: Matt Reynolds <mattreynolds@google.com> Date: Tue Dec 05 09:51:11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc3004ac41e40f89f1a7edcf72243541c315bef6 commit fc3004ac41e40f89f1a7edcf72243541c315bef6 Author: Matt Reynolds <mattreynolds@google.com> Date: Fri Dec 15 22:00:47 2017 Remove Physical Web from Chrome for iOS BUG= 760104 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I09ef256cc8fd72827800b68925c8d95dc8586324 Reviewed-on: https://chromium-review.googlesource.com/795359 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#524479} [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/app/strings/ios_chromium_strings.grd [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/app/strings/ios_google_chrome_strings.grd [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/application_context.h [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/application_context_impl.cc [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/application_context_impl.h [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/chrome_url_constants.cc [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/chrome_url_constants.h [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/experimental_flags.h [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/experimental_flags.mm [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/physical_web/BUILD.gn [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/physical_web/create_physical_web_data_source.h [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/physical_web/create_physical_web_data_source.mm [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.mm [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/physical_web/physical_web_constants.h [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/physical_web/physical_web_initial_state_recorder.h [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/physical_web/physical_web_prefs_registration.cc [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/physical_web/physical_web_prefs_registration.h [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/physical_web/start_physical_web_discovery.h [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/physical_web/start_physical_web_discovery.mm [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/pref_names.cc [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/pref_names.h [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/prefs/BUILD.gn [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/prefs/browser_prefs.mm [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/ui/main/BUILD.gn [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/ui/main/browser_view_wrangler.mm [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/ui/settings/BUILD.gn [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/ui/settings/physical_web_collection_view_controller.h [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/ui/settings/physical_web_collection_view_controller.mm [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/ui/settings/physical_web_collection_view_controller_unittest.mm [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/ui/settings/privacy_collection_view_controller_unittest.mm [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/ui/webui/BUILD.gn [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/ui/webui/physical_web_ui.cc [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/browser/ui/webui/physical_web_ui.h [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/browser/ui/webui/web_ui_egtest.mm [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/common/BUILD.gn [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/common/physical_web/BUILD.gn [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/common/physical_web/DEPS [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/common/physical_web/OWNERS [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/common/physical_web/physical_web_device.h [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/common/physical_web/physical_web_device.mm [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/common/physical_web/physical_web_request.h [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/common/physical_web/physical_web_request.mm [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/common/physical_web/physical_web_scanner.h [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/common/physical_web/physical_web_scanner.mm [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/common/physical_web/physical_web_types.h [delete] https://crrev.com/299ee7d2fc333b82e1f7560ba2bddcb12f841daa/ios/chrome/common/physical_web/physical_web_types.mm [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/test/testing_application_context.h [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/ios/chrome/test/testing_application_context.mm [modify] https://crrev.com/fc3004ac41e40f89f1a7edcf72243541c315bef6/tools/metrics/histograms/enums.xml
Comment 1 by bugdroid1@chromium.org
, Aug 31 2017