New issue
Advanced search Search tips

Issue 760093 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

please add gerrit support to my_reviews.py

Project Member Reported by jochen@chromium.org, Aug 29 2017

Issue description

it appears to only support rietveld.
 
Cc: aga...@chromium.org
Components: -Infra Infra>Git
Status: WontFix (was: Untriaged)
my_activity.py shows Gerrit reviews
should we delete it then?
It's on my list of things to delete after Rietveld is 100% read-only. I'll probably wait a quarter to do so in case people want to use it for perf/okrs.

Comment 5 by groby@google.com, Sep 14 2017

Doesn't work for me. It even says in the output "Get rietveld stats about the review you done, or forgot to do."

Am I using it wrong?
Cc: nparker@chromium.org

Comment 7 by groby@google.com, Sep 14 2017

NM. I finally realized that you're saying my_activity lists Gerrit, as opposed to my_reviews. At least when I used the two scripts, they had slightly different capabilities. So before we throw one away, we might want to figure out what those differences were, and if we still need them.

(I used them in a script that's somewhat popular around perf time, for summaries - but can't test right now, since I'm OOO)

Sign in to add a comment