New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760090 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Count of content suggestions displayed in tab page resets to default on opening a suggestion URL in new tab page.

Project Member Reported by rakurati@chromium.org, Aug 29 2017

Issue description

App Version: 62.0.3199.0
iOS Version: 9.3.5, 10.3.3, 11.0 beta 8
Device: iPhone and iPad

Pre-condition:
Go to device settings>>Chrome canary>> Enable Suggestions UI>>Enabled

Steps to reproduce:
1. Launch chrome
2. Tap on content suggestions more button
3. Long press on any suggestions URL and select “Open in new tab”
4. Go to the new tab page and return to the tab page of step 3

Observed results:
The content suggestions that are loaded in step 2 are not displayed only the default(10) content suggestions are displayed.

Note: Reset of content suggestions also noticed, on open and close of tab switcher after step2.

Expected results:
The suggestions that are loaded on tapping more button shouldn’t reset until the app was force quit.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: No (For the above steps it will not reset suggestions, but the suggestions will reset when open NTP page after step2)
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): NA (new feature in M62)
Bug reproducible on the current beta channel build (App Version, iOS Version): NA (new feature in M62)

Link to video/image:

Chrome iOS behavior:
https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8d1hzaFBsRjFrRHc/view?usp=sharing

Chrome Android behavior:
https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8cEpLdmpQZzItRnM/view?usp=sharing

 

Comment 1 by sczs@chromium.org, Aug 30 2017

Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
gambard@ could you PTAL.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10ac2e60c91b8de6072949d72df9eb8e1febacfc

commit 10ac2e60c91b8de6072949d72df9eb8e1febacfc
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Aug 31 11:46:56 2017

Don't reload the home panel when shown

When the NTP is shown and is showing the Home panel, the panel doesn't
need to be reloaded.

Bug:  760090 
Change-Id: I1ece3049d8c8887bda8cf851c59c3aea3dd69af2
Reviewed-on: https://chromium-review.googlesource.com/645286
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498820}
[modify] https://crrev.com/10ac2e60c91b8de6072949d72df9eb8e1febacfc/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50e28850ec39a34de16740608220c1486ac49bb7

commit 50e28850ec39a34de16740608220c1486ac49bb7
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Sep 04 12:23:33 2017

Test that items are kept when switching tabs

Additional items (displayed when pressing more), must be kept when there
is a tab switch.

Bug:  760090 ,  749981 
Change-Id: I5fcf5b50c87c6cd9b4bba80f2b9047abdefc150d
Reviewed-on: https://chromium-review.googlesource.com/646328
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499485}
[modify] https://crrev.com/50e28850ec39a34de16740608220c1486ac49bb7/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm

Status: Verified (was: Fixed)
Verified the issue on 63.0.3213.0 canary tested on iPhone7+(iOS11).
The suggestions that are loaded on tapping more button are displayed on navigating back to ntp from newly opened tab,works fine.

Sign in to add a comment