Most popular icons are misaligned on rotating device from portrait to landscape and vice versa. |
|||
Issue descriptionApp Version: 62.0.3199.0 canary iOS Version: 10.3.3, 11 beta 8 Device: iPhone 6 plus only URL: Chrome Settings - NTP Precondition: 1. Force quit chrome canary to enable “Content suggestions” 2. Have most popular icons on NTP. Steps to reproduce: 1. Launch chrome in landscape orientation or portrait orientation. 2. Tap on tab switcher button. 3. Rotate the device to landscape orientation or portrait orientation 4. Tap on tab switcher button. Observed results: Notice that the most popular site icons are displayed vertically or horizontally in a straight line. Expected results: Most popular sites should display in 2 rows with 4 icons in each row. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): NA in M60 - New implementation in M62 Bug reproducible on the current beta channel build (App Version, iOS Version): NA in M61 - New implementation in M62 Link to video/image: https://drive.google.com/a/google.com/file/d/0Bz2uwV55gGwDSlBEanJ1YTdpMHc/view?usp=sharing
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78a9901480541606747a20b764f447f449c0bbd9 commit 78a9901480541606747a20b764f447f449c0bbd9 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Aug 30 15:18:31 2017 Relayout ContentSuggestions when presented ContentSuggestions might be changed will not being presented. For example when the device is rotated while the stack view is presented. In order to have the view adapted to its new layout, the layout needs to be recomputed when the view is shown. Bug: 760085 Change-Id: If0f9e7d5a13b84395d0b6710c0c9b7cc10011155 Reviewed-on: https://chromium-review.googlesource.com/642888 Reviewed-by: Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#498469} [modify] https://crrev.com/78a9901480541606747a20b764f447f449c0bbd9/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Aug 30 2017
,
Sep 27 2017
Verified on chrome beta version 62.0.3202.38 on iPhone 6 plus with iOS 11.0 and 10.3.3. Most popular icons aligned properly when device is rotated from landscape to portrait. Looks good. |
|||
►
Sign in to add a comment |
|||
Comment 1 by gambard@chromium.org
, Aug 29 2017Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)