New issue
Advanced search Search tips

Issue 760084 link

Starred by 1 user
Status: Assigned
Owner:
msramek@chromium.org
Cc:
ios-bugs@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: ----



Sign in to add a comment

The EnableNewClearBrowsingDataUI controls dead code.

Project Member Reported by noyau@chromium.org, Aug 29 2017 
The experimental flag EnableNewClearBrowsingDataUI controls code that has not been touched since early december last year. Last modification was before upstreaming in https://chromereviews.googleplex.com/552217014

Experimental flags on iOS are on their way out (go/feature-flags-on-ios) and are migrating to chrome://flags.

This bug is to remove all related code from experimental_flags.mm and either replacing it with a base::Feature and a chrome://flags or to remove all the dead code (including a test that I had to disable as it sets the user default).

Comment 1 by msramek@chromium.org, Aug 29 2017

Owner: msramek@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffe5650806eeab8a081e5638a1ba13751087c95f

commit ffe5650806eeab8a081e5638a1ba13751087c95f
Author: Eric Noyau <noyau@google.com>
Date: Tue Aug 29 13:33:33 2017

Removing the EnableNewClearBrowsingDataUI experimental flag.

Bug: 760084
Change-Id: I3ab84b964a9769b9122ac51c5ea5405185ef2f7b
Reviewed-on: https://chromium-review.googlesource.com/641191
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498094}
[modify] https://crrev.com/ffe5650806eeab8a081e5638a1ba13751087c95f/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/ffe5650806eeab8a081e5638a1ba13751087c95f/ios/chrome/browser/resources/Settings.bundle/Experimental.plist
[modify] https://crrev.com/ffe5650806eeab8a081e5638a1ba13751087c95f/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm

Comment 3 by noyau@chromium.org, Jan 26 2018 

Ping?
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b29a2cc4d079f0df865db9c765352aac01d8a0f

commit 1b29a2cc4d079f0df865db9c765352aac01d8a0f
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Sat Feb 10 01:56:20 2018

Remove code behind EnableNewClearBrowsingDataUI

The EnableNewClearBrowsingDataUI flag has been disabled for
one year, remove the code that can now be considered dead.

Bug: 760084
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I22502beef12c2ce121cfcd896f1593829ecc140b
Reviewed-on: https://chromium-review.googlesource.com/903245
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535927}
[modify] https://crrev.com/1b29a2cc4d079f0df865db9c765352aac01d8a0f/ios/chrome/browser/browsing_data/BUILD.gn
[delete] https://crrev.com/8e466cc1176ea479a372feebf7ad76d94586bcb7/ios/chrome/browser/browsing_data/browsing_data_change_listening.h
[delete] https://crrev.com/8e466cc1176ea479a372feebf7ad76d94586bcb7/ios/chrome/browser/browsing_data/browsing_data_counter_wrapper.cc
[delete] https://crrev.com/8e466cc1176ea479a372feebf7ad76d94586bcb7/ios/chrome/browser/browsing_data/browsing_data_counter_wrapper.h
[delete] https://crrev.com/8e466cc1176ea479a372feebf7ad76d94586bcb7/ios/chrome/browser/browsing_data/cache_counter.cc
[delete] https://crrev.com/8e466cc1176ea479a372feebf7ad76d94586bcb7/ios/chrome/browser/browsing_data/cache_counter.h
[delete] https://crrev.com/8e466cc1176ea479a372feebf7ad76d94586bcb7/ios/chrome/browser/browsing_data/cache_counter_unittest.cc
[delete] https://crrev.com/8e466cc1176ea479a372feebf7ad76d94586bcb7/ios/chrome/browser/browsing_data/ios_browsing_data_counter_factory.cc
[delete] https://crrev.com/8e466cc1176ea479a372feebf7ad76d94586bcb7/ios/chrome/browser/browsing_data/ios_browsing_data_counter_factory.h
[modify] https://crrev.com/1b29a2cc4d079f0df865db9c765352aac01d8a0f/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/1b29a2cc4d079f0df865db9c765352aac01d8a0f/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/1b29a2cc4d079f0df865db9c765352aac01d8a0f/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm
[modify] https://crrev.com/1b29a2cc4d079f0df865db9c765352aac01d8a0f/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm
[modify] https://crrev.com/1b29a2cc4d079f0df865db9c765352aac01d8a0f/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae6987e12b572be56b43368781235272817c0193

commit ae6987e12b572be56b43368781235272817c0193
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Mar 01 13:21:40 2018

Re-introduce new Clear Browsing Data UI

Partial manual revert of https://crrev.com/c/903245 to accomodate
the refactoring done in ios/chrome/browser/browsing_data.

Notable changes:

-   removed class IOSBrowsingDataCounterFactory that was used
    purely for namespacing a static function and instead used
    a free function in an anonymous namespace

-   use BrowsingDataRemoverObserver to watch for removal of
    browsing data instead of using subscription with the old
    global CallbackList

-   introduced chrome://flags#new-clear-browsing-data-ui
    flags (backed by a feature) to enable or disable the
    new UI

-   fix presubmit checks by converting uses of base::Bind to
    base::Bind{Repeating,Once}

-   re-enabled disabled tests

Bug: 760084
Change-Id: I18a59144f2ba461e096d1e009261a2e717e463b7
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/939624
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540144}
[modify] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/browsing_data/BUILD.gn
[add] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/browsing_data/browsing_data_counter_wrapper.cc
[add] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/browsing_data/browsing_data_counter_wrapper.h
[add] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/browsing_data/browsing_data_features.cc
[add] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/browsing_data/browsing_data_features.h
[add] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/browsing_data/cache_counter.cc
[add] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/browsing_data/cache_counter.h
[add] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/browsing_data/cache_counter_unittest.cc
[modify] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm
[modify] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm
[modify] https://crrev.com/ae6987e12b572be56b43368781235272817c0193/ios/chrome/browser/ui/settings/clear_browsing_data_egtest.mm

Comment 6 by eugene...@chromium.org, Sep 27

Components: UI>Browser>Mobile>Settings
►

Sign in to add a comment