New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760079 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 0
Type: Bug-Regression



Sign in to add a comment

Compile failure for Beta builds on Windows, Mac & linux on Continuous desktop builder

Project Member Reported by ranjitkan@chromium.org, Aug 29 2017

Issue description

Build URL:
==========
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/1146
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/1147

https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20beta/builds/1357
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20beta/builds/1358

https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20beta/builds/1394
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20beta/builds/1395

Log URL:
=========
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/1146/steps/compile/logs/stdio
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/1147/steps/compile/logs/stdio

https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20beta/builds/1357/steps/compile/logs/stdio
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20beta/builds/1358/steps/compile/logs/stdio

https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20beta/builds/1394/steps/compile/logs/stdio
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20beta/builds/1395/steps/compile/logs/stdio

Content from the Log:
=====================
FAILED: obj/third_party/WebKit/Source/core/dom/dom_1/Document.obj 
ninja -t msvc -e environment.x64 -- "c:\b\c\win_toolchain\vs_files\f53e4598951162bad6330f7a167486c7ae5db1e5\vc\bin\amd64/cl.exe" /nologo /showIncludes  @obj/third_party/WebKit/Source/core/dom/dom_1/Document.obj.rsp /c ../../third_party/WebKit/Source/core/dom/Document.cpp /Foobj/third_party/WebKit/Source/core/dom/dom_1/Document.obj /Fd"obj/third_party/WebKit/Source/core/dom/dom_1_cc.pdb"
../../third_party/WebKit/Source/core/dom/Document.cpp(5835): error C2039: 'OwnerDocument': is not a member of 'blink::DocumentInit'
C:\b\c\b\win64_beta\src\third_party\WebKit\Source\core/loader/DocumentLoader.h(63): note: see declaration of 'blink::DocumentInit'
../../third_party/WebKit/Source/core/dom/Document.cpp(5843): error C2039: 'OwnerDocument': is not a member of 'blink::DocumentInit'
C:\b\c\b\win64_beta\src\third_party\WebKit\Source\core/loader/DocumentLoader.h(63): note: see declaration of 'blink::DocumentInit'

Suspecting below change could be a possible culprit.

https://chromium.googlesource.com/chromium/src/+/cb54da8199ba125d94cfcdd8edec14bef1ce3cf1

@andypaicu: Assigning to you, kindly take a look into it. Please help us to find an owner if not with respect to your change. We have scheduled Beta release tomorrow. Tagging wth beta blocker.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3723f8976d6443fc83c8332127f68c0c8834f86

commit a3723f8976d6443fc83c8332127f68c0c8834f86
Author: Andy Paicu <andypaicu@chromium.org>
Date: Tue Aug 29 15:36:36 2017

Fixed build broken by 0ab2412a104d2f235d7b9fe19d30ef605a410832

Bug:  760079 
Change-Id: Iba1b476dd1d537cd2691bcabba92898dbd0a8f06
Reviewed-on: https://chromium-review.googlesource.com/641493
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#969}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/a3723f8976d6443fc83c8332127f68c0c8834f86/third_party/WebKit/Source/core/dom/Document.cpp

Status: Fixed (was: Assigned)
Apologies for this breakage, I will monitor the bots this time to make sure everything is alright

Comment 3 by ajha@chromium.org, Aug 30 2017

Status: Verified (was: Fixed)
Beta RC #61.0.3163.71 compiled successfully and there have been no such failures on the latest Win,Mac and Linux official.desktop.continuous builders.

Link to the builders:
======================
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/1166
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20beta/builds/1383
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20beta/builds/1416

Marking this as Verified, therefore.

Sign in to add a comment