New issue
Advanced search Search tips

Issue 760064 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 760035
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Global-buffer-overflow in media::VideoDecodeStatsReporter::GetFpsBucket

Project Member Reported by ClusterFuzz, Aug 29 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5162886766002176

Fuzzer: inferno_flicker
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Global-buffer-overflow READ 4
Crash Address: 0x61d2a924
Crash State:
  media::VideoDecodeStatsReporter::GetFpsBucket
  media::VideoDecodeStatsReporter::UpdateFrameRateStability
  media::VideoDecodeStatsReporter::UpdateStats
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=497874:497956

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5162886766002176

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 29 2017

Labels: M-62
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 29 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 29 2017

Labels: Pri-1
Cc: mlamouri@chromium.org
Components: Internals>Media
Owner: chcunningham@chromium.org
Status: Assigned (was: Untriaged)
Looks like it might be the same underlying cause as  Issue 760035 .

At a peek, is it safe to assign the result of std::round to an int, and then use that?
 Please take a look, thanks.


Project Member

Comment 5 by ClusterFuzz, Aug 29 2017

Labels: OS-Android
Mergedinto: 760035
Status: Duplicate (was: Assigned)
Project Member

Comment 7 by ClusterFuzz, Aug 30 2017

ClusterFuzz has detected this issue as fixed in range 498140:498349.

Detailed report: https://clusterfuzz.com/testcase?key=5162886766002176

Fuzzer: inferno_flicker
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Global-buffer-overflow READ 4
Crash Address: 0x61d2a924
Crash State:
  media::VideoDecodeStatsReporter::GetFpsBucket
  media::VideoDecodeStatsReporter::UpdateFrameRateStability
  media::VideoDecodeStatsReporter::UpdateStats
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=497874:497956
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=498140:498349

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5162886766002176

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: -ReleaseBlock-Stable
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 7 2017

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment