Two-finger tap not recognized after touching background of file list several times |
||||||||
Issue descriptionChrome Version: 62.0.3199 Chrome OS Version: 9844.0.0 Chrome OS Platform: Chromebook Plus Steps To Reproduce: (1) Open a directory containing 1 to 10 items, then resize the window so that it can show all the items without scrolling. (2) Tap the empty part of the right pane (below the list items) several times. (3) Tap one of the entries with two fingers. Expected Result: Selects the item and show context menu for it. The item is highlighted blue. Actual Result: It opens the context menu of previous selection. Since step 2 cancels all selection, it'll open context menu for the current directory. The tapped item is highlighted gray (but is not actually selected). How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Almost always. I sometimes needed to do step 2 several times. What is the impact to the user, and is there a workaround? If so, what is it? Other touch operations like single tap and long tap still works. Showing the context menu of the previous selection state would be confusing. If a new window is opened, it works normally in the new window until doing step 2 again.
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0333a724798b68ff5b99bd8af09b065d53da4ea commit e0333a724798b68ff5b99bd8af09b065d53da4ea Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Aug 30 06:13:49 2017 Reset some more state of FileTapHandler before tracking next touch. This fixes a bug where two-finger tap is not recognized after several taps, as well as duplicated call to the callback functions. This change also adds unit tests for some basic functions of the class in addition to cover the bugs above. Bug: 760058 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I376e4a2a5a5ca1fb2b577e7ee1fd81b99d97b73b Reviewed-on: https://chromium-review.googlesource.com/641291 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#498377} [modify] https://crrev.com/e0333a724798b68ff5b99bd8af09b065d53da4ea/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/e0333a724798b68ff5b99bd8af09b065d53da4ea/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler.js [add] https://crrev.com/e0333a724798b68ff5b99bd8af09b065d53da4ea/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler_unittest.html [add] https://crrev.com/e0333a724798b68ff5b99bd8af09b065d53da4ea/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler_unittest.js
,
Aug 30 2017
,
Aug 30 2017
This bug requires manual review: We are only 5 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 30 2017
Approving merge to M61.
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5689b14705e33924a95a91eddebfe371e6185150 commit 5689b14705e33924a95a91eddebfe371e6185150 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Aug 31 00:57:50 2017 Reset some more state of FileTapHandler before tracking next touch. This fixes a bug where two-finger tap is not recognized after several taps, as well as duplicated call to the callback functions. This change also adds unit tests for some basic functions of the class in addition to cover the bugs above. TBR=yamaguchi@chromium.org (cherry picked from commit e0333a724798b68ff5b99bd8af09b065d53da4ea) Bug: 760058 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I376e4a2a5a5ca1fb2b577e7ee1fd81b99d97b73b Reviewed-on: https://chromium-review.googlesource.com/641291 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#498377} Reviewed-on: https://chromium-review.googlesource.com/644587 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1023} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/5689b14705e33924a95a91eddebfe371e6185150/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/5689b14705e33924a95a91eddebfe371e6185150/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler.js [add] https://crrev.com/5689b14705e33924a95a91eddebfe371e6185150/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler_unittest.html [add] https://crrev.com/5689b14705e33924a95a91eddebfe371e6185150/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler_unittest.js
,
Sep 4 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by yamaguchi@chromium.org
, Aug 29 2017