New issue
Advanced search Search tips

Issue 760032 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security

Blocking:
issue 62400



Sign in to add a comment

Heap-buffer-overflow in CCodec_ProgressiveDecoder::ReSampleScanline

Project Member Reported by ClusterFuzz, Aug 29 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4965284925669376

Fuzzer: libFuzzer_pdf_codec_gif_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x6020000004b8
Crash State:
  CCodec_ProgressiveDecoder::ReSampleScanline
  CCodec_ProgressiveDecoder::GifReadScanline
  CGifContext::ReadScanline
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=400732:400874

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4965284925669376

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 29 2017

Labels: M-62
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 29 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 29 2017

Labels: Pri-1
Cc: tsepez@chromium.org
Components: Internals>Plugins>PDF
Owner: dsinclair@chromium.org
dsinclair: do you mind taking a look at this please?
Status: Assigned (was: Untriaged)
Cc: dsinclair@chromium.org
Owner: rharrison@chromium.org
rharrison@ can you ptal?
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 6 2017

Labels: -Security_Impact-Head Security_Impact-Beta
rharrison@, this is being tracked as a stable release blocker. Have you had a chance to take a look at this bug yet?
Labels: -Security_Impact-Beta -ReleaseBlock-Stable Security_Impact-None
Sorry about missing this, I didn't notice it was marked as high priority.

This shouldn't be a release blocker, since this a XFA only fuzzer and XFA isn't enabled.
Blocking: 62400
Labels: -M-62
Status: Started (was: Assigned)
Status: Fixed (was: Started)
No longer reproduces on HEAD. This issues looks similar to other issues recently resolved in the resampling GIF code paths.

Likely fixed by https://pdfium-review.googlesource.com/14630
Project Member

Comment 13 by ClusterFuzz, Sep 23 2017

ClusterFuzz has detected this issue as fixed in range 503743:503814.

Detailed report: https://clusterfuzz.com/testcase?key=4965284925669376

Fuzzer: libFuzzer_pdf_codec_gif_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x6020000004b8
Crash State:
  CCodec_ProgressiveDecoder::ReSampleScanline
  CCodec_ProgressiveDecoder::GifReadScanline
  CGifContext::ReadScanline
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=400732:400874
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=503743:503814

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4965284925669376

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 14 by ClusterFuzz, Sep 23 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4965284925669376 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 15 by sheriffbot@chromium.org, Sep 23 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 16 by sheriffbot@chromium.org, Dec 30 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment