factory: revise factory server url configuration |
|||||
Issue descriptionCurrently the factory server (shopfloor) URL was set in several places: - test list constant may define factory_server_enabled - test list options defined factory_server_url and timeout - goofy will read test list option and set URL to shopfloor module. - it also enables the session, but no one reads that flag - sync_factory_server takes arg server_url (which may come from locals) and set URL to shopfloor module. - goofy plugin 'instalog' reads server URL from shopfloor module (and need to restart if URL is changed) We probably want to revise this, for example: - decide if server url should live in options or constant - decide if we need 'enabled' and 'timeout' - decide if goofy should set URL - decide how instalog should receive "server url changed" and restart
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/3f585b9b503bdbd6239f079cbe9eba2b14dce316 commit 3f585b9b503bdbd6239f079cbe9eba2b14dce316 Author: Hung-Te Lin <hungte@chromium.org> Date: Wed Aug 30 17:09:02 2017 pytests: Remove shopfloor task from 'start' test. The 'start' used to support checking a scanned (or read from VPD) serial number and check if it is valid using shopfloor. This actually won't work because (1) Most shopfloor backends today do not support CheckSerialNumber API. (2) Most projects need to start with only MLB SN. (3) The reference test doesn't call 'start' anymore. As a result, we move the 'No server URL' warning to sync_factory_server and remove the shopfloor / VPD-SN tasks from start. BUG= chromium:760017 TEST=make test Change-Id: If9817a7c4b23a70fbc745282319d7f36684ac799 Reviewed-on: https://chromium-review.googlesource.com/641011 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org> [modify] https://crrev.com/3f585b9b503bdbd6239f079cbe9eba2b14dce316/po/zh-CN.po [modify] https://crrev.com/3f585b9b503bdbd6239f079cbe9eba2b14dce316/py/test/pytests/sync_factory_server.py [modify] https://crrev.com/3f585b9b503bdbd6239f079cbe9eba2b14dce316/py/test/shopfloor.py [modify] https://crrev.com/3f585b9b503bdbd6239f079cbe9eba2b14dce316/py/test/pytests/start/start.py
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/ac907f9b5101fc1f9e90e122730abd85e0b60f82 commit ac907f9b5101fc1f9e90e122730abd85e0b60f82 Author: Hung-Te Lin <hungte@chromium.org> Date: Wed Aug 30 17:09:03 2017 pytests: Remove unnecessary timeout sent to shopfloor instance. Ideally the "timeout for connection to shopfloor server" should be globally defined, or only specified by sync_factory_server. Individual pytests should not specify timeout unless it has special needs. BUG= chromium:760017 TEST=make test Change-Id: I65774f091149e18b33d72a78e300ec27a8c8d5f7 Reviewed-on: https://chromium-review.googlesource.com/641012 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org> [modify] https://crrev.com/ac907f9b5101fc1f9e90e122730abd85e0b60f82/py/test/pytests/check_image_version.py [modify] https://crrev.com/ac907f9b5101fc1f9e90e122730abd85e0b60f82/py/test/pytests/audio_quality.py
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/bda28ca6a677451745dc9edf2565bc87617e1df8 commit bda28ca6a677451745dc9edf2565bc87617e1df8 Author: Hung-Te Lin <hungte@chromium.org> Date: Wed Aug 30 17:09:02 2017 shopfloor: Remove deprecated or useless API from shopfloor module. The 'shopfloor' module has few APIs deprecated for a long time so we want to remove them first: - set_enabled (we check this by test list constants now) - is_enabled - check_serial_number (not feasible in common flow today) - get_hwid (v3 generates HWID instead of asking from server) - upload_report (done by sync_factory_server task now, or directly invoked UploadReport) - finalize (invoked directly now) - check_server_status (replaced by direct Ping) - server_api (no APIs now) BUG= chromium:760017 TEST=make test Change-Id: I2d6aaefd55ce65a11374b9d73482955139f6bcd1 Reviewed-on: https://chromium-review.googlesource.com/641730 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org> [modify] https://crrev.com/bda28ca6a677451745dc9edf2565bc87617e1df8/py/goofy/goofy.py [modify] https://crrev.com/bda28ca6a677451745dc9edf2565bc87617e1df8/py/test/shopfloor.py [modify] https://crrev.com/bda28ca6a677451745dc9edf2565bc87617e1df8/py/test/pytests/start/start.py
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/dbebbce9c30b4ac34cdab5d43b993b2b68944f97 commit dbebbce9c30b4ac34cdab5d43b993b2b68944f97 Author: Hung-Te Lin <hungte@chromium.org> Date: Wed Aug 30 17:09:02 2017 shopfloor: Remove 'detect' from shopfloor module. The 'detect' mechanism was designed to helper developers sharing same factory code with real manufacturing line, that when the DUT was imaged it may record where the imaging server was, thus deriving the factory server URL. However, this usually does not work today because (1) Most projects choose to hard code default factory server URL in test list, and (2) many projects choose to do copy-machine, or stage-specific factory servers (i.e., SMT needs different IP than FATP). As a result, the 'detection' should be deprecated. Reading server URL from environment variable is also removed. BUG= chromium:760017 TEST=make test Change-Id: Ib299d729267705e91ae95483f3ce744b7e13ccfb Reviewed-on: https://chromium-review.googlesource.com/641731 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org> [modify] https://crrev.com/dbebbce9c30b4ac34cdab5d43b993b2b68944f97/py/goofy/updater_unittest.py [modify] https://crrev.com/dbebbce9c30b4ac34cdab5d43b993b2b68944f97/py/goofy/goofy_rpc.py [modify] https://crrev.com/dbebbce9c30b4ac34cdab5d43b993b2b68944f97/py/test/shopfloor.py [modify] https://crrev.com/dbebbce9c30b4ac34cdab5d43b993b2b68944f97/py/goofy/plugins/system_log_manager.py [modify] https://crrev.com/dbebbce9c30b4ac34cdab5d43b993b2b68944f97/py/goofy/plugins/system_log_manager_unittest.py [modify] https://crrev.com/dbebbce9c30b4ac34cdab5d43b993b2b68944f97/py/goofy/updater.py [modify] https://crrev.com/dbebbce9c30b4ac34cdab5d43b993b2b68944f97/py/tools/time_sanitizer_unittest.py [modify] https://crrev.com/dbebbce9c30b4ac34cdab5d43b993b2b68944f97/py/test/pytests/vswr/vswr.py [modify] https://crrev.com/dbebbce9c30b4ac34cdab5d43b993b2b68944f97/py/test/pytests/check_image_version.py [modify] https://crrev.com/dbebbce9c30b4ac34cdab5d43b993b2b68944f97/py/tools/time_sanitizer.py [modify] https://crrev.com/dbebbce9c30b4ac34cdab5d43b993b2b68944f97/py/goofy/goofy.py [modify] https://crrev.com/dbebbce9c30b4ac34cdab5d43b993b2b68944f97/py/test/pytests/shopfloor_service.py
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/ace696710ca677ae58f80c101b0da7474b4b8913 commit ace696710ca677ae58f80c101b0da7474b4b8913 Author: Hung-Te Lin <hungte@chromium.org> Date: Wed Aug 30 23:13:15 2017 factory_server: A new 'server_proxy' module to access factory server. Move the creation of server proxy object from 'shopfloor' module to 'server_proxy', which now reads and writes JSON config 'factory_server' for server connection configuration. Also removed all the 'session' management in shopfloor module so it does not need to depend on Goofy state server (no shared data saved). Storing server information in JSON config is also faster. On Eve, calling get_server_url() 100 times need 0.214s, and calling GetServerURL() 100 times need 0.124s. BUG= chromium:760017 TEST=make test Change-Id: Id8e6cb0e58b1ca00205c2d64011e35845f4f711e Reviewed-on: https://chromium-review.googlesource.com/642627 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org> [modify] https://crrev.com/ace696710ca677ae58f80c101b0da7474b4b8913/py/test/shopfloor.py [modify] https://crrev.com/ace696710ca677ae58f80c101b0da7474b4b8913/py/shopfloor/factory_server.schema.json [add] https://crrev.com/ace696710ca677ae58f80c101b0da7474b4b8913/py/test/factory_server.schema.json [add] https://crrev.com/ace696710ca677ae58f80c101b0da7474b4b8913/py/test/factory_server.json [modify] https://crrev.com/ace696710ca677ae58f80c101b0da7474b4b8913/py/shopfloor/factory_server.json [add] https://crrev.com/ace696710ca677ae58f80c101b0da7474b4b8913/py/test/server_proxy.py
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/41ff8f3b960ac56d4357616f2b6bdfda0a6d30ec commit 41ff8f3b960ac56d4357616f2b6bdfda0a6d30ec Author: Hung-Te Lin <hungte@chromium.org> Date: Wed Aug 30 23:13:15 2017 Change reference to 'shopfloor' by 'server_proxy'. For programs calling 'shopfloor.get_instance' without using the helper functions (hwid, auxlog) in shopfloor module, we can easily change them to new server_proxy.GetServerProxy. BUG= chromium:760017 TEST=make test Change-Id: Ied56fde78fc73cafc22f66f07c36795a5cf68523 Reviewed-on: https://chromium-review.googlesource.com/642628 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/41ff8f3b960ac56d4357616f2b6bdfda0a6d30ec/py/test/pytests/shopfloor_service.py [modify] https://crrev.com/41ff8f3b960ac56d4357616f2b6bdfda0a6d30ec/py/test/pytests/finalize/finalize.py [modify] https://crrev.com/41ff8f3b960ac56d4357616f2b6bdfda0a6d30ec/py/goofy/plugins/instalog.py [modify] https://crrev.com/41ff8f3b960ac56d4357616f2b6bdfda0a6d30ec/py/tools/time_sanitizer_unittest.py [modify] https://crrev.com/41ff8f3b960ac56d4357616f2b6bdfda0a6d30ec/py/tools/ghost.py [modify] https://crrev.com/41ff8f3b960ac56d4357616f2b6bdfda0a6d30ec/py/tools/time_sanitizer.py [modify] https://crrev.com/41ff8f3b960ac56d4357616f2b6bdfda0a6d30ec/py/test/pytests/sync_factory_server.py [modify] https://crrev.com/41ff8f3b960ac56d4357616f2b6bdfda0a6d30ec/py/goofy/plugins/time_sanitizer.py [modify] https://crrev.com/41ff8f3b960ac56d4357616f2b6bdfda0a6d30ec/py/test/test_lists/generic_grt.test_list.json
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/30feb78c8025cac411c8df38a3c090d66973aca2 commit 30feb78c8025cac411c8df38a3c090d66973aca2 Author: Hung-Te Lin <hungte@chromium.org> Date: Wed Aug 30 23:13:15 2017 pytests: Change 'skip_shopfloor' to 'enable_factory_server'. The argument names should not be "true negative" ("skip_xxx"), and should be "factory_server" instead of "shopfloor". BUG= chromium:760017 TEST=make test Change-Id: I9277e8fb90fbfd11d5d28af1ca792cc3a4f8654a Reviewed-on: https://chromium-review.googlesource.com/642632 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/30feb78c8025cac411c8df38a3c090d66973aca2/py/test/test_lists/generic_common.test_list.json [modify] https://crrev.com/30feb78c8025cac411c8df38a3c090d66973aca2/py/test/test_lists/manager_unittest/a.test_list.json [modify] https://crrev.com/30feb78c8025cac411c8df38a3c090d66973aca2/py/test/pytests/verify_components_unittest.py [modify] https://crrev.com/30feb78c8025cac411c8df38a3c090d66973aca2/py/test/pytests/verify_components.py [modify] https://crrev.com/30feb78c8025cac411c8df38a3c090d66973aca2/py/test/pytests/hwid_v3.py
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/8563eb4abb4250f3dafd9a50bed02f62eb0ad9ea commit 8563eb4abb4250f3dafd9a50bed02f62eb0ad9ea Author: Hung-Te Lin <hungte@chromium.org> Date: Wed Aug 30 23:13:15 2017 pytests: Change 'enable_shopfloor' and 'use_shopfloor' to 'enable_factory_server'. Unify test argument name. BUG= chromium:760017 TEST=make test Change-Id: I9979409d28f02987b6b94dc419c5c6b0b2468788 Reviewed-on: https://chromium-review.googlesource.com/642633 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/8563eb4abb4250f3dafd9a50bed02f62eb0ad9ea/po/zh-CN.po [modify] https://crrev.com/8563eb4abb4250f3dafd9a50bed02f62eb0ad9ea/py/test/pytests/rf_graphyte/rf_graphyte.py [modify] https://crrev.com/8563eb4abb4250f3dafd9a50bed02f62eb0ad9ea/py/test/pytests/rf_graphyte/README.md [modify] https://crrev.com/8563eb4abb4250f3dafd9a50bed02f62eb0ad9ea/py/test/test_lists/manager_unittest/override_args.test_list.json [modify] https://crrev.com/8563eb4abb4250f3dafd9a50bed02f62eb0ad9ea/py/test/pytests/audio_quality.py
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/22b5b279aabcfa7c3b07317776656027a3313d95 commit 22b5b279aabcfa7c3b07317776656027a3313d95 Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Aug 31 07:24:12 2017 pytests: Fix failure when syncing time in sync_factory_server. In CL:642628 the time_sanitizer module has changed function SyncWithShopfloor to SyncWithFactoryServer but time_utils didn't change the reference to sanitizer. BUG= chromium:760017 TEST=make test Change-Id: I3174cdb9e14f7ddca844fb5ed419914a3f729a77 Reviewed-on: https://chromium-review.googlesource.com/644827 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org> [modify] https://crrev.com/22b5b279aabcfa7c3b07317776656027a3313d95/py/test/pytests/sync_factory_server.py [modify] https://crrev.com/22b5b279aabcfa7c3b07317776656027a3313d95/py/test/utils/time_utils.py [modify] https://crrev.com/22b5b279aabcfa7c3b07317776656027a3313d95/py/test/pytests/audio_quality.py
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/4efa72c1f8caea817f312532efeeac3877c2dce5 commit 4efa72c1f8caea817f312532efeeac3877c2dce5 Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Aug 31 09:37:04 2017 goofy: Change goofy_rpc to use server_proxy instead of shopfloor. The 'shopfloor' that Goofy RPC talks to is actually the factory server. BUG= chromium:760017 TEST=make test Change-Id: I0ed5dba448e40d725cea306f8f612dad0e1c37bd Reviewed-on: https://chromium-review.googlesource.com/644828 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org> [modify] https://crrev.com/4efa72c1f8caea817f312532efeeac3877c2dce5/py/goofy/goofy_rpc.py [modify] https://crrev.com/4efa72c1f8caea817f312532efeeac3877c2dce5/py/goofy/js/goofy.js
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/5dc447e61e24ca6c8ccb844f607bb8408dc52b03 commit 5dc447e61e24ca6c8ccb844f607bb8408dc52b03 Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Aug 31 09:37:04 2017 goofy: Change plugin 'system_log_manager' to use sever_proxy. The system_log_manager is talking to factory server instead of shopfloor backends. Moreover, the timeout for "getting instance" is not really important because it should be using the global default settings (usually we want to override the timeout for particular special functions, especially SaveAuxLog). BUG= chromium:760017 TEST=make test Change-Id: I11dab30ca8d07e36b0d0be7c26625d1db556ca7c Reviewed-on: https://chromium-review.googlesource.com/644829 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org> [modify] https://crrev.com/5dc447e61e24ca6c8ccb844f607bb8408dc52b03/py/goofy/plugins/system_log_manager.py [modify] https://crrev.com/5dc447e61e24ca6c8ccb844f607bb8408dc52b03/py/goofy/plugins/system_log_manager_unittest.py
,
Aug 31 2017
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/d151bf313ea5011830de8e68b1855796c928353f commit d151bf313ea5011830de8e68b1855796c928353f Author: Hung-Te Lin <hungte@chromium.org> Date: Fri Sep 01 10:04:57 2017 test_lists: Remove options 'shopfloor_server_url' and 'shopfloor_timeout_secs'. The 'shopfloor_*' settings in test list options is misleading and should be more flexible for test list to decide, for example allowing different server URLs for different stations (even phases). This change removed test list options 'shopfloor_server_url', 'shopfloor_timeout_secs', and added new constants 'default_factory_server_url'. The only place to set server URL is now ``sync_factory_server`` test. Test list may override 'constants.default_factory_server_url' if it has only one factory server for whole manufacturing process, or override the locals in different test groups. BUG= chromium:760017 TEST=make test; started goofy. Change-Id: I46f4671dbedf6005913d908481cd31a57044f17f Reviewed-on: https://chromium-review.googlesource.com/642428 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org> [modify] https://crrev.com/d151bf313ea5011830de8e68b1855796c928353f/py/test/factory.py [modify] https://crrev.com/d151bf313ea5011830de8e68b1855796c928353f/py/goofy/goofy.py [modify] https://crrev.com/d151bf313ea5011830de8e68b1855796c928353f/py/test/test_lists/generic_common.test_list.json [modify] https://crrev.com/d151bf313ea5011830de8e68b1855796c928353f/py/test/test_lists/generic_main.test_list.json
,
Sep 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/31104f717fc2b11e006d4018d646d5acec751d2f commit 31104f717fc2b11e006d4018d646d5acec751d2f Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Sep 04 13:30:41 2017 test: New update_utils for deploying updates from factory server. A new library to help updating components from factory server. The new Updater() is an object instead of context manager, with callbacks that can be extended for processing downloaded resource. BUG= chromium:760017 TEST=make test; tried to run update_utils.UpdateHWIDDatabase(remote_dut). Change-Id: Ie33f0a7995eaffbfb9686039cff49974a74905fd Reviewed-on: https://chromium-review.googlesource.com/645106 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/31104f717fc2b11e006d4018d646d5acec751d2f/py/goofy/updater_unittest.py [modify] https://crrev.com/31104f717fc2b11e006d4018d646d5acec751d2f/py/test/shopfloor.py [modify] https://crrev.com/31104f717fc2b11e006d4018d646d5acec751d2f/py/test/pytests/finalize/finalize.py [modify] https://crrev.com/31104f717fc2b11e006d4018d646d5acec751d2f/py/goofy/updater.py [modify] https://crrev.com/31104f717fc2b11e006d4018d646d5acec751d2f/py/test/pytests/update_firmware.py [modify] https://crrev.com/31104f717fc2b11e006d4018d646d5acec751d2f/py/test/pytests/check_image_version.py [modify] https://crrev.com/31104f717fc2b11e006d4018d646d5acec751d2f/py/test/pytests/verify_components.py [modify] https://crrev.com/31104f717fc2b11e006d4018d646d5acec751d2f/py/test/pytests/hwid_v3.py [add] https://crrev.com/31104f717fc2b11e006d4018d646d5acec751d2f/py/test/utils/update_utils.py
,
Sep 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/2cc8558b4c246fe7c3db0c4a716dda548545df92 commit 2cc8558b4c246fe7c3db0c4a716dda548545df92 Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Sep 04 13:30:41 2017 pytests: Remove reference to old shopfloor module. The 'shopfloor' is confusing because what we are really using is the factory server, which provides additional functions than a real shopfloor backend. Many pytests call shopfloor just to (1) get parameters, or (2) save aux logs. We think (1) should be done by retrieve_config pytest + station based test, and (2) should be done by testlog. In this change, we only replaced 'shopfloor' by 'server_proxy' which still creates the reference to factory server. Few tests are still calling factory sever 'shopfloor', or remove the parameter / auxlog thing. BUG= chromium:760017 TEST=make test Change-Id: I02d53e299e3f3e7d4f733c562f490aeb6a047227 Reviewed-on: https://chromium-review.googlesource.com/646991 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/2cc8558b4c246fe7c3db0c4a716dda548545df92/py/test/pytests/retrieve_config.py [modify] https://crrev.com/2cc8558b4c246fe7c3db0c4a716dda548545df92/py/test/pytests/rf_graphyte/rf_graphyte.py [modify] https://crrev.com/2cc8558b4c246fe7c3db0c4a716dda548545df92/py/test/pytests/verify_components_unittest.py [modify] https://crrev.com/2cc8558b4c246fe7c3db0c4a716dda548545df92/py/test/pytests/bluetooth.py [modify] https://crrev.com/2cc8558b4c246fe7c3db0c4a716dda548545df92/py/test/pytests/als_fixture.py [modify] https://crrev.com/2cc8558b4c246fe7c3db0c4a716dda548545df92/py/test/pytests/vswr/vswr.py [delete] https://crrev.com/31104f717fc2b11e006d4018d646d5acec751d2f/py/test/shopfloor.py [modify] https://crrev.com/2cc8558b4c246fe7c3db0c4a716dda548545df92/py/test/pytests/touchscreen_calibration/touchscreen_calibration.py [modify] https://crrev.com/2cc8558b4c246fe7c3db0c4a716dda548545df92/py/test/pytests/robot_movement.py [modify] https://crrev.com/2cc8558b4c246fe7c3db0c4a716dda548545df92/py/test/pytests/offline_test/shell/fetch_log.py [modify] https://crrev.com/2cc8558b4c246fe7c3db0c4a716dda548545df92/py/test/pytests/robot_movement_unittest.py [modify] https://crrev.com/2cc8558b4c246fe7c3db0c4a716dda548545df92/py/test/fixture/robot/algorithm.py [modify] https://crrev.com/2cc8558b4c246fe7c3db0c4a716dda548545df92/py/test/pytests/audio_quality.py
,
Sep 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/b3b6ba9896a17a6d2bfdfd5b737eef2008cc7488 commit b3b6ba9896a17a6d2bfdfd5b737eef2008cc7488 Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Sep 04 13:30:41 2017 utils: Add a wrapper for webservice_utils to handle calls without callRemote. webservice_utils is now also used by server_proxy and other objects doing XMLRPC, so we do want to enable the implicit RPC using attributes, without explicit call to callRemote. BUG= chromium:760017 TEST=make test Change-Id: Ica195599de9cf20304ce92f1939ebab8c607db7e Reviewed-on: https://chromium-review.googlesource.com/647052 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Youcheng Syu <youcheng@chromium.org> [modify] https://crrev.com/b3b6ba9896a17a6d2bfdfd5b737eef2008cc7488/py/utils/webservice_utils_unittest.py [modify] https://crrev.com/b3b6ba9896a17a6d2bfdfd5b737eef2008cc7488/py/utils/webservice_utils.py
,
Sep 5 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hungte@chromium.org
, Aug 29 2017