New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760003 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Blink of 'Take photo' & 'Choose a file' options are seen at Search settings while scrolling downwards in chrome://settings/changePicture page

Project Member Reported by mmanchala@chromium.org, Aug 29 2017

Issue description

Chrome Version: 62.0.3198.0 /9887.0.0 dev-channel Daisy, Kip & Minnie
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to user -> Go to chrome://settings/changePicture page 
(2)Now scroll using mouse wheel or by Touch pad continuously and observe 
blink of 'Take photo' & 'Choose a file' options are seen at Search settings (Please refer Video and screenshot)

Expected: No such blink should be seen while scrolling
Actual: Instead Blink of 'Take photo' & 'Choose a file' options are seen

This is Regression Issue as same is working fine in 62.0.3197.0/9885.0.0 dev-channel Minnie

@stevenjb : Please confirm the Issue
 
Actual.webm
2.2 MB View Download
Actual.jpg
132 KB View Download
Expected.webm
2.4 MB View Download
Cc: steve...@chromium.org
Owner: reve...@chromium.org
Labels: -M-62 M-61
stevenjb@ Is this issue seen on 61 and 62? or just 61? reveman@ do you have any CLs in progress for this issue?
Labels: -ReleaseBlock-Stable
mmanchala@, thank you for reporting the issue. I've uploaded a fix for this here: https://chromium-review.googlesource.com/c/chromium/src/+/641617
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31bcd3433529c16f7619b140aa0f1ee530bf0222

commit 31bcd3433529c16f7619b140aa0f1ee530bf0222
Author: David Reveman <reveman@chromium.org>
Date: Wed Aug 30 17:50:41 2017

Change Picture: Fix rendering glitch for picture list scrolling.

Use static instead of relative position for iron-icon elements.

Relative position is causing these elements to be promoted to
layers on the change picture page where an ancestor has an
absolute position. The overflow-y property is for some reason
not handled by the compositor when accelerating scrolling of
child layers so we often see a few frames of the element outside
the overflow region before main thread gets a chance to update
the contents.

Not having these layers promoted to layers is desirable in general
and it happens to also avoid this rendering glitch.

Bug:  760003 
Test: manual

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I759c065dc3ec9ef91ba368526af8387f55a685bd
Reviewed-on: https://chromium-review.googlesource.com/641617
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498530}
[modify] https://crrev.com/31bcd3433529c16f7619b140aa0f1ee530bf0222/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.html

Labels: Merge-Request-61
Status: Fixed (was: Assigned)
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 30 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 5 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Approving merge to M61.
Labels: -Merge-Review-61 Merge-Approved-61
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 30 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5863ea7cff0392e8c7aa23734bfe94e00f2ff83

commit b5863ea7cff0392e8c7aa23734bfe94e00f2ff83
Author: David Reveman <reveman@chromium.org>
Date: Wed Aug 30 23:47:14 2017

Change Picture: Fix rendering glitch for picture list scrolling.

Use static instead of relative position for iron-icon elements.

Relative position is causing these elements to be promoted to
layers on the change picture page where an ancestor has an
absolute position. The overflow-y property is for some reason
not handled by the compositor when accelerating scrolling of
child layers so we often see a few frames of the element outside
the overflow region before main thread gets a chance to update
the contents.

Not having these layers promoted to layers is desirable in general
and it happens to also avoid this rendering glitch.

Bug:  760003 
Test: manual

TBR=reveman@chromium.org

(cherry picked from commit 31bcd3433529c16f7619b140aa0f1ee530bf0222)

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I759c065dc3ec9ef91ba368526af8387f55a685bd
Reviewed-on: https://chromium-review.googlesource.com/641617
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498530}
Reviewed-on: https://chromium-review.googlesource.com/644529
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1018}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/b5863ea7cff0392e8c7aa23734bfe94e00f2ff83/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.html

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment