Issue metadata
Sign in to add a comment
|
Voiceover is heard for text behind the omnibox. |
||||||||||||||||||||||||
Issue descriptionApp Version: 62.0.3198.0 canary iOS Version: 10.3.5,IOS 11 beta 7 Device : iPhone,iPad Precondition : 1. Enable content suggestions. 2. Enable Voice over from device settings. Steps to reproduce: 1. Launch chrome. 2. Scroll the content suggestions behind the omnibox. 3. Scroll the cursor on the omnibox. 4. Slightly scroll the cursor upwards in omnibox. Observed results: Text behind the omnibox is heard. Expected results: Text behind the omnibox should not be heard. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: N/A, Safari: N/A Bug reproducible on current stable build (App Version, iOS Version): NA, New Feature in M62 Bug reproducible on the current beta channel build (App Version, iOS Version): NA, New Feature in M62 Link to video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpWS13N2o5WmdzWms/view?usp=sharing
,
Sep 4 2017
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13c981c4f6d5b02826130ffbc1730a580aad64b2 commit 13c981c4f6d5b02826130ffbc1730a580aad64b2 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Sep 15 09:57:57 2017 Add an accessibility label for the fake omnibox This CL adds a view used only to present an accessible element of the size of the fake omnibox. Before this CL, only the label was accessible, allowing the selection of the content visually hidden by the omnibox using the margin between the label and the border of the fake omnibox. Bug: 760002 Change-Id: I3ac5f1105709d57290f2a98963434e8fb22457a6 Reviewed-on: https://chromium-review.googlesource.com/660537 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#502218} [modify] https://crrev.com/13c981c4f6d5b02826130ffbc1730a580aad64b2/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/13c981c4f6d5b02826130ffbc1730a580aad64b2/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
,
Sep 15 2017
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b98755f1b057076453fa5914243fc6e2c687ede5 commit b98755f1b057076453fa5914243fc6e2c687ede5 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 20 11:53:20 2017 Tapping fake omnibox focuses the real omnibox Adding a view to have the whole fake omnibox be accessible prevented interactions with it, as the accessibility view is intercepting the the touches. This CL changes the accessibility view to a UIButton, letting it handle the tap directly. Bug: 760002 , 766455 Change-Id: I34a4297eee16f5811f10a8d8fe0c3b0fa3d6b045 Reviewed-on: https://chromium-review.googlesource.com/671019 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#503115} [modify] https://crrev.com/b98755f1b057076453fa5914243fc6e2c687ede5/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/b98755f1b057076453fa5914243fc6e2c687ede5/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm [modify] https://crrev.com/b98755f1b057076453fa5914243fc6e2c687ede5/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/311802b73383bf1f868c640a39e7b386a424b329 commit 311802b73383bf1f868c640a39e7b386a424b329 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Sep 20 18:54:08 2017 Tapping fake omnibox focuses the real omnibox Adding a view to have the whole fake omnibox be accessible prevented interactions with it, as the accessibility view is intercepting the the touches. This CL changes the accessibility view to a UIButton, letting it handle the tap directly. Bug: 760002 , 766455 Change-Id: I34a4297eee16f5811f10a8d8fe0c3b0fa3d6b045 Reviewed-on: https://chromium-review.googlesource.com/671019 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#503115}(cherry picked from commit b98755f1b057076453fa5914243fc6e2c687ede5) Reviewed-on: https://chromium-review.googlesource.com/675963 Reviewed-by: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/branch-heads/3220@{#3} Cr-Branched-From: 2b71773e89aab44ac10b383e3c86f1fda47bae12-refs/heads/master@{#502993} [modify] https://crrev.com/311802b73383bf1f868c640a39e7b386a424b329/ios/chrome/browser/content_suggestions/content_suggestions_header_view_controller.mm [modify] https://crrev.com/311802b73383bf1f868c640a39e7b386a424b329/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm [modify] https://crrev.com/311802b73383bf1f868c640a39e7b386a424b329/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
,
Oct 3 2017
Verified in 63.0.3231.0 Canary, iPhone 6 iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11 Voiceover is heard for the text highlighted. Looks good |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sczs@chromium.org
, Aug 30 2017Status: Assigned (was: Untriaged)