Regression when using float with break-word
Reported by
m...@rcel.cz,
Aug 29 2017
|
|||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3132.0 Safari/537.36 Example URL: Steps to reproduce the problem: 1. Open the sample file in Chrome 61 or newer What is the expected behavior? Stable versions of Chrome 60, Firefox 55.0.3, MS Edge 40.15063.0.0, IE 11 work all the same. What went wrong? Since Chrome 61 Beta (including newer branches like Dev/Canary) there's difference in rendering of this particular case - 2 divs: 1 with float:left and another containing text with word-wrap:break-word. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes 60.0.3112.113 Does this work in other browsers? Yes Chrome version: 61.0.3163.59 Channel: beta OS Version: 10.0 Flash Version:
,
Aug 29 2017
Trying myself the Chromium snapshot builds, it happened somewhere between 488788 - 488818. 479609 ok 486994 ok 487502 ok 487765 ok 488144 ok 488549 ok 488668 ok 488788 ok 488818 fail 488823 fail 488858 fail 488958 fail 491852 fail 496768 fail
,
Aug 29 2017
URGENT - PTAL. M61 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Note: Plan is to cut M61 Stable RC for Desktop on this Thursday (08/31/17).
,
Aug 29 2017
You are probably looking for a change made after 488812 (known good), but no lat er than 488813 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/7440d469bf97caaf649c5affecb9ba2cab642a7f..14ec221a9013017a9007181bb7414464ee63f1b4
,
Aug 29 2017
https://chromium.googlesource.com/chromium/src/+/14ec221a9013017a9007181bb7414464ee63f1b4 was requested by an internal team in issue 746222 , in that sense "Hotlist-Google". It is a small change which would be safe to revert on 61. However, I am not sure what the expected behaviour for the test case in #1 should be. kojii@ or eae@ can help with that.
,
Aug 29 2017
I did briefly check Mac Safari and Mac FF nightly and they do not break the word Chrome after every character but keep it as one in the yellow box.
,
Aug 29 2017
Let's revert it while we figure it out.
,
Aug 29 2017
,
Aug 29 2017
eae@ please post the revert when ready and request for approval for merge to M61.
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01e06953c7cf0b0db8f69b145a424efafee91aeb commit 01e06953c7cf0b0db8f69b145a424efafee91aeb Author: Emil A Eklund <eae@chromium.org> Date: Tue Aug 29 22:33:36 2017 Revert "Adjust the mid-word-break heuristic limit to 4em for Emoji ZWJ sequence" This reverts r488813 (commit 14ec221a9013017a9007181bb7414464ee63f1b4), as it caused a regression when combining floats, word-wrap: break-word. Bug: 760000 Change-Id: I9a01ec116b2c541ef9d28522c4bc21707187f442 Tbr: kojii@chromium.org Reviewed-on: https://chromium-review.googlesource.com/641920 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#498258} [modify] https://crrev.com/01e06953c7cf0b0db8f69b145a424efafee91aeb/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
,
Aug 30 2017
Tested the issue on Windows-7 & 10, Ubuntu 14.04 and Mac OS 10.12.6 using chrome latest Canary M62-62.0.3200.0 by following steps mentioned in the original comment. Observed that chrome word is displaying as expected. Hence adding TE-Verified label. Please find the screen shot(Linux) for reference. Thank you!
,
Aug 30 2017
,
Aug 30 2017
This bug requires manual review: We are only 5 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 30 2017
Approving merge to M61 branch 3163 per comments #7, #11 & per offline chat with eae@. Please merge ASAP. Thank you.
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09b2204eba07687fde6808249df1f145d9270334 commit 09b2204eba07687fde6808249df1f145d9270334 Author: Emil A Eklund <eae@chromium.org> Date: Wed Aug 30 16:13:20 2017 Revert "Adjust the mid-word-break heuristic limit to 4em for Emoji ZWJ sequence" This reverts r488813 (commit 14ec221a9013017a9007181bb7414464ee63f1b4), as it caused a regression when combining floats, word-wrap: break-word. TBR=eae@chromium.org (cherry picked from commit 01e06953c7cf0b0db8f69b145a424efafee91aeb) Bug: 760000 Change-Id: I9a01ec116b2c541ef9d28522c4bc21707187f442 Tbr: kojii@chromium.org Reviewed-on: https://chromium-review.googlesource.com/641920 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#498258} Reviewed-on: https://chromium-review.googlesource.com/643787 Cr-Commit-Position: refs/branch-heads/3163@{#996} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/09b2204eba07687fde6808249df1f145d9270334/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
,
Aug 30 2017
Merged to M61 branch 3163.
,
Aug 31 2017
Thank you Emil for when I was on vacation.
,
Sep 5 2017
Rechecked this issue on Windows 10, Ubuntu 14.04, Mac 10.12.6 using chrome version 61.0.3163.79. Merge is working as intended. Adding TE-Verified labels for M61. Thanks.!
,
Sep 5 2017
Android: Works as per expected behavior, Verified on 61.0.3163.79 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by schenney@chromium.org
, Aug 29 2017Labels: -Type-Bug -Pri-2 Needs-Bisect ReleaseBlock-Stable M-61 OS-Linux Pri-1 Type-Bug-Regression
Status: Untriaged (was: Unconfirmed)