Disable NEON support for ARMv6 |
||||
Issue descriptionARMv6 chips do not support NEON. Clang deliberately errors when attempting to use NEON intrinsics when targeting ARMv6: /b/build/slave/Android_Cronet_ARMv6_Builder/build/src/third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:28:2: error: "NEON support not enabled" #error "NEON support not enabled" NEON support should be marked disabled for ARMv6 targets.
,
Aug 29 2017
,
Aug 29 2017
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c53d7a2dff27ede9ab0643064e7764de606bcd0d commit c53d7a2dff27ede9ab0643064e7764de606bcd0d Author: Chris Blume <cblume@google.com> Date: Tue Aug 29 20:46:00 2017 Disable NEON support on ARMv6 build targets. ARMv6 does not support NEON. Despite this, inside a BUILD.gn "if (arm_use_neon)" will be entered for builds targeting ARMv6. This means any build that perhaps includes different files for NEON builds will work incorrectly for ARMv6 targets. As an example, Clang deliberately errors when attempting to use NEON intrinsics when targeting ARMv6: /b/build/slave/Android_Cronet_ARMv6_Builder/build/src/third_party/llvm-build/Release+Asserts/lib/clang/6.0.0/include/arm_neon.h:28:2: error: "NEON support not enabled" This probably happens in GCC as well but I haven't confirmed that. Either way, the build should correctly set target features. BUG= 759993 Change-Id: I0b099823604d25fae20c80a72f7fca28ab6b5121 Reviewed-on: https://chromium-review.googlesource.com/639931 Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#498220} [modify] https://crrev.com/c53d7a2dff27ede9ab0643064e7764de606bcd0d/build/config/arm.gni
,
Aug 29 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by cblume@chromium.org
, Aug 29 2017