New issue
Advanced search Search tips

Issue 759980 link

Starred by 1 user
Status: Fixed
Owner:
mbonadei@chromium.org
Closed: Oct 2017
Cc:
oprypin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

Setup Windows "more configs" bot.

Project Member Reported by kjellander@chromium.org, Aug 29 2017 
After the recent regression in https://bugs.chromium.org/p/webrtc/issues/detail?id=8169 it is obvious we need to cover some of these non-default build configurations also on Windows.

This bug tracks setting up such a bot (previous ones are on Android and Linux only).

Comment 1 by kjellander@chromium.org, Sep 25 2017

Labels: OS-Windows
Owner: ----
Status: Available (was: Assigned)
Let's assign this as part of our upcoming "Chrome infra training" effort instead.

Comment 2 by mbonadei@chromium.org, Oct 17 2017

Owner: mbonadei@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c9b7837556829cd47b335a427e97b84c52227c21

commit c9b7837556829cd47b335a427e97b84c52227c21
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Tue Oct 17 18:03:15 2017

Fixing master configuration for: Win (more configs).

Bug:  759980 
Change-Id: I68655632ccb254918077399f9a964620af396373
Reviewed-on: https://chromium-review.googlesource.com/723619
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>

[modify] https://crrev.com/c9b7837556829cd47b335a427e97b84c52227c21/masters/master.client.webrtc.fyi/master_win_cfg.py
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/a811027990e7eb674f1c89e09c524530947c26d2

commit a811027990e7eb674f1c89e09c524530947c26d2
Author: Mirko Bonadei <mbonadei@webrtc.org>
Date: Wed Oct 18 12:28:58 2017

Fixing warning C4267 on Win (more_configs).

We added a new bot to client.webrtc.fyi (https://build.chromium.org/p/client.webrtc.fyi/builders/Win%20%28more%20configs%29).

It seems it is spotting some unsafe conversions and this CL is a test to see if we can use rtc::dchecked_cast to fix them:
../../modules/audio_coding/neteq/neteq_unittest.cc(547): error C2220: warning treated as error - no 'object' file generated
../../modules/audio_coding/neteq/neteq_unittest.cc(547): warning C4267: '=': conversion from 'size_t' to 'uint16_t', possible loss of data
../../modules/audio_coding/neteq/neteq_unittest.cc(548): warning C4267: '=': conversion from 'size_t' to 'uint32_t', possible loss of data
../../modules/audio_coding/neteq/neteq_unittest.cc(977): warning C4267: '+=': conversion from 'size_t' to 'uint32_t', possible loss of data
../../modules/audio_coding/neteq/neteq_unittest.cc(979): warning C4267: '+=': conversion from 'size_t' to 'uint32_t', possible loss 

Bug:  chromium:759980 
Change-Id: Icd0f32ccf620c7c6642fadff797dc2482918648d
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/12921
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20335}
[modify] https://crrev.com/a811027990e7eb674f1c89e09c524530947c26d2/modules/audio_coding/neteq/neteq_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/737e073f8da15cd05db43ca7da22ba030e14d27a

commit 737e073f8da15cd05db43ca7da22ba030e14d27a
Author: Mirko Bonadei <mbonadei@webrtc.org>
Date: Thu Oct 19 07:39:22 2017

Fixing warning C4267 on Win (more_configs).

This is a follow-up of https://webrtc-review.googlesource.com/c/src/+/12921.

Bug:  chromium:759980 
Change-Id: Ifd39adb6541c0c7e0337f587a8b34b84a07331ed
Reviewed-on: https://webrtc-review.googlesource.com/13122
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20341}
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/acm2/acm_receiver_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/acm2/audio_coding_module_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/audio_network_adaptor/bitrate_controller_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/codecs/builtin_audio_encoder_factory_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/codecs/isac/unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/codecs/legacy_encoded_audio_frame_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/codecs/opus/opus_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/neteq/audio_multi_vector_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/neteq/audio_vector_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/neteq/expand_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/neteq/neteq_impl_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/neteq/red_payload_splitter_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/neteq/sync_buffer_unittest.cc
[modify] https://crrev.com/737e073f8da15cd05db43ca7da22ba030e14d27a/modules/audio_coding/neteq/tools/input_audio_file_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/ea7a3f82256fc2e7cc0b8f4244e74f502d9c54bd

commit ea7a3f82256fc2e7cc0b8f4244e74f502d9c54bd
Author: Mirko Bonadei <mbonadei@webrtc.org>
Date: Thu Oct 19 10:59:50 2017

Fixing unsafe conversion

The bot "Win (more_configs)" has spotted another unsafe type conversion.

This CL is a follow-up of:
- https://webrtc-review.googlesource.com/c/src/+/12921
- https://webrtc-review.googlesource.com/c/src/+/13122

Bug:  chromium:759980 
Change-Id: I3634c3e20fcd9f4e106914399ac40ca87d4c6137
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/13622
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20349}
[modify] https://crrev.com/ea7a3f82256fc2e7cc0b8f4244e74f502d9c54bd/modules/audio_coding/neteq/neteq_impl_unittest.cc
[modify] https://crrev.com/ea7a3f82256fc2e7cc0b8f4244e74f502d9c54bd/modules/audio_processing/aec/system_delay_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 23 2017 

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/b7e17884663086f5dea7e4dc1fe467bd889c2b66

commit b7e17884663086f5dea7e4dc1fe467bd889c2b66
Author: Mirko Bonadei <mbonadei@webrtc.org>
Date: Mon Oct 23 07:59:39 2017

Fixing other unsafe conversions.

The bot "Win (more_configs)" has spotted another unsafe type conversion.

This CL is a follow-up of:
- https://webrtc-review.googlesource.com/c/src/+/12921
- https://webrtc-review.googlesource.com/c/src/+/13122
- https://webrtc-review.googlesource.com/c/src/+/13622

Bug:  chromium:759980 
Change-Id: I9a4268e7ea938cc85376211b40767fd8465f37fd
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/13623
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20381}
[modify] https://crrev.com/b7e17884663086f5dea7e4dc1fe467bd889c2b66/modules/audio_coding/neteq/neteq_impl_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1c1f12e37048c5077a2b79330b95f04bff753172

commit 1c1f12e37048c5077a2b79330b95f04bff753172
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Tue Oct 24 11:53:44 2017

Promoting win_more_configs from client.webrtc.fyi to client.webrtc.

After [1] we can promote the win_more_configs trybot to the main
waterfall in order to avoid regressions.

[1] - https://build.chromium.org/p/client.webrtc.fyi/builders/Win%20%28more%20configs%29/builds/49

Bug:  759980 
Change-Id: I084b74a17f35336b1948094ffeab2dfa6ff64024
Reviewed-on: https://chromium-review.googlesource.com/732120
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/1c1f12e37048c5077a2b79330b95f04bff753172/masters/master.client.webrtc/master_win_cfg.py
[modify] https://crrev.com/1c1f12e37048c5077a2b79330b95f04bff753172/masters/master.client.webrtc.fyi/slaves.cfg
[modify] https://crrev.com/1c1f12e37048c5077a2b79330b95f04bff753172/scripts/slave/README.recipes.md
[modify] https://crrev.com/1c1f12e37048c5077a2b79330b95f04bff753172/masters/master.client.webrtc.fyi/master_win_cfg.py
[modify] https://crrev.com/1c1f12e37048c5077a2b79330b95f04bff753172/scripts/slave/recipes/webrtc/more_configs.py
[rename] https://crrev.com/1c1f12e37048c5077a2b79330b95f04bff753172/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Win__more_configs_.json
[modify] https://crrev.com/1c1f12e37048c5077a2b79330b95f04bff753172/masters/master.client.webrtc/slaves.cfg
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 25 2017 

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/d71997941a5c1e76beb3206d7c25eff30fb8b73d

commit d71997941a5c1e76beb3206d7c25eff30fb8b73d
Author: Mirko Bonadei <mbonadei@webrtc.org>
Date: Wed Oct 25 11:51:36 2017

Adding win_more_configs to CQ

Bug:  chromium:759980 
Change-Id: Ie33931eae67b90a648735856a26e3b86dcf7c0e1
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/14960
Reviewed-by: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20426}
[modify] https://crrev.com/d71997941a5c1e76beb3206d7c25eff30fb8b73d/infra/config/cq.cfg

Comment 12 by mbonadei@chromium.org, Oct 25 2017

Status: Fixed (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/7b600d036db71f4f7bc7e1c6b1f962a96f036dfc

commit 7b600d036db71f4f7bc7e1c6b1f962a96f036dfc
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Tue Oct 31 01:13:05 2017

WebRTC: Schedule builds for Win (more configs) bot.

TBR=phoglund@chromium.org

Bug:  759980 
Change-Id: Ib524d7a256a721e3be3980433a4eeb33bc724d47
Reviewed-on: https://chromium-review.googlesource.com/745561
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/7b600d036db71f4f7bc7e1c6b1f962a96f036dfc/masters/master.client.webrtc/master_win_cfg.py
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ddacaf91eccdd4d198725bcd1d3023130e840432

commit ddacaf91eccdd4d198725bcd1d3023130e840432
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Tue Oct 31 01:33:43 2017

Add Win (more configs) to WebRTC lkgr finder.

TBR=phoglund@chromium.org

Bug:  759980 
Change-Id: Ie9452c663c17c274d9ee0fba294fa64c765b013b
Reviewed-on: https://chromium-review.googlesource.com/745621
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/ddacaf91eccdd4d198725bcd1d3023130e840432/infra/services/lkgr_finder/config/webrtc_cfg.pyl
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f7c44fce70c6156a0f7d9e6aaf808f98fe8deb3c

commit f7c44fce70c6156a0f7d9e6aaf808f98fe8deb3c
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Fri Jan 26 12:46:00 2018

WebRTC (more configs): Build each config in a different out dir

in hopes to make win_more_configs less flaky and faster

Bug:  chromium:759980 
Change-Id: I586b34a21426d00907b0f9d8a9a89de0dc8aea20
Reviewed-on: https://chromium-review.googlesource.com/883365
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/f7c44fce70c6156a0f7d9e6aaf808f98fe8deb3c/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Android32__more_configs_.json
[modify] https://crrev.com/f7c44fce70c6156a0f7d9e6aaf808f98fe8deb3c/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_android_more_configs.json
[modify] https://crrev.com/f7c44fce70c6156a0f7d9e6aaf808f98fe8deb3c/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Linux__more_configs_.json
[modify] https://crrev.com/f7c44fce70c6156a0f7d9e6aaf808f98fe8deb3c/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_win_more_configs.json
[modify] https://crrev.com/f7c44fce70c6156a0f7d9e6aaf808f98fe8deb3c/scripts/slave/README.recipes.md
[modify] https://crrev.com/f7c44fce70c6156a0f7d9e6aaf808f98fe8deb3c/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_linux_more_configs.json
[modify] https://crrev.com/f7c44fce70c6156a0f7d9e6aaf808f98fe8deb3c/scripts/slave/recipes/webrtc/more_configs.py
[modify] https://crrev.com/f7c44fce70c6156a0f7d9e6aaf808f98fe8deb3c/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Win__more_configs_.json
►

Sign in to add a comment