luci-py's 'client' subtree mirror is broken |
|||
Issue descriptionSource repo: https://chromium.googlesource.com/infra/luci/luci-py Subtree repo: https://chromium.googlesource.com/infra/luci/client-py gsubtreed fails [1] with CalledProcessError: Command ('git', 'cat-file', '-t', '90e593fb1aa7750826a931f50fb6a8809b406267:client') returned non-zero exit status 128: STDERR ======================================== fatal: git cat-file: could not get object info Probably because 'client' at rev 90e593fb1aa is a submodule. (Though it also a submodule at older and newer revisions, it's not clear what makes 90e593fb1aa so special). Anyhow, it is odd that gsubtreed looks so deep into the history. It probably wants to rewrite it all using 'Cr-Mirrored-From: https://chromium.googlesource.com/infra/luci/luci-py' instead of 'Cr-Mirrored-From: https://github.com/luci/luci-py' headers. This is probably not OK, since we want to preserve the history (?). [1] https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fgsubtreed-luci-py%2F147520%2F%2B%2Frecipes%2Fsteps%2Fgsubtreed%2F0%2Fstdout
,
Aug 29 2017
Ugh, so... I forget when, but at somepoint, someone 'optimized' gsubtreed so that it never does a fetch of the subrepos. When we moved the source of truth to googlesource, the bot made an empty repo for the client repo and never did a fetch. I ssh'd to the bot and ran `git fetch` in /mnt/data/b/build/slave/gsubtreed-luci-py/build/gsubtreed-work-dir/chromium.googlesource.com-infra-luci-client--py , and now the bot's failing with a permission error.
,
Aug 29 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/b0335df5079c0c251ec83d56669f65fff0649cd2 commit b0335df5079c0c251ec83d56669f65fff0649cd2 Author: Robert Iannucci <iannucci@google.com> Date: Tue Aug 29 17:48:41 2017
,
Aug 29 2017
Fixed :)
,
Aug 29 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vadimsh@chromium.org
, Aug 29 2017