New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759945 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Improve Splash Screen for standalone Web Apps.

Project Member Reported by piotrs@chromium.org, Aug 29 2017

Issue description

This is a bug for improving what can be done with splash screen for standalone Web Apps.

For overview of the direction we want to take please consult this github comment: https://github.com/w3c/manifest/issues/589#issuecomment-323232119
 
Components: UI>Browser>WebAppInstalls
Cc: mlamouri@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22ab02c0f78249eda17b082ab7d852826d2b6a04

commit 22ab02c0f78249eda17b082ab7d852826d2b6a04
Author: Piotr Swigon <piotrs@chromium.org>
Date: Fri Nov 03 02:50:06 2017

[WebApps] Adds parsing of splash_screen_url attribute to ManifestParser.

This is a foundation for introducing HTML splash screens for Web Apps.
To avoid unnecessary duplication I pushed more logic into ParseURL method.

HTML splash screen were discussed here (Googlers only, sorry):
https://docs.google.com/document/d/1LLALh25-UkREqbr8qlMZIui09XEg3KU-OM4-an2989g/edit#

And on Web App Manifest github page here:
https://github.com/w3c/manifest/issues/589#issuecomment-323232119

Bug: 759945
Change-Id: I10e0a81e0822d45ea735403da68234ca18c66ffe
Reviewed-on: https://chromium-review.googlesource.com/737254
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513659}
[modify] https://crrev.com/22ab02c0f78249eda17b082ab7d852826d2b6a04/content/public/common/manifest.cc
[modify] https://crrev.com/22ab02c0f78249eda17b082ab7d852826d2b6a04/content/public/common/manifest.h
[modify] https://crrev.com/22ab02c0f78249eda17b082ab7d852826d2b6a04/content/public/common/manifest_struct_traits.cc
[modify] https://crrev.com/22ab02c0f78249eda17b082ab7d852826d2b6a04/content/public/common/manifest_struct_traits.h
[modify] https://crrev.com/22ab02c0f78249eda17b082ab7d852826d2b6a04/content/renderer/manifest/manifest_parser.cc
[modify] https://crrev.com/22ab02c0f78249eda17b082ab7d852826d2b6a04/content/renderer/manifest/manifest_parser.h
[modify] https://crrev.com/22ab02c0f78249eda17b082ab7d852826d2b6a04/content/renderer/manifest/manifest_parser_unittest.cc
[modify] https://crrev.com/22ab02c0f78249eda17b082ab7d852826d2b6a04/third_party/WebKit/public/platform/modules/manifest/manifest.mojom

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98256a78627e834fd38f9ec635c560ef1be2a6f5

commit 98256a78627e834fd38f9ec635c560ef1be2a6f5
Author: Piotr Swigon <piotrs@chromium.org>
Date: Fri Nov 03 03:44:56 2017

[WebApps] Plumbs splash_screen_url from a Manifest to a WebappInfo.

This is just plumbing without intent to affect any user journey.

This patch explicitly does not target WebAPKs, only legacy web app flow for
now. WebAPKs will require plumbing through the minting server and checking
for updates, and will come at a later stage.

Bug: 759945
Change-Id: Ica35839ad68d6dece46266e4d9b37220f256893c
Reviewed-on: https://chromium-review.googlesource.com/737756
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513669}
[modify] https://crrev.com/98256a78627e834fd38f9ec635c560ef1be2a6f5/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/98256a78627e834fd38f9ec635c560ef1be2a6f5/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
[modify] https://crrev.com/98256a78627e834fd38f9ec635c560ef1be2a6f5/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java
[modify] https://crrev.com/98256a78627e834fd38f9ec635c560ef1be2a6f5/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java
[modify] https://crrev.com/98256a78627e834fd38f9ec635c560ef1be2a6f5/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java
[modify] https://crrev.com/98256a78627e834fd38f9ec635c560ef1be2a6f5/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java
[modify] https://crrev.com/98256a78627e834fd38f9ec635c560ef1be2a6f5/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java
[modify] https://crrev.com/98256a78627e834fd38f9ec635c560ef1be2a6f5/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java
[modify] https://crrev.com/98256a78627e834fd38f9ec635c560ef1be2a6f5/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/98256a78627e834fd38f9ec635c560ef1be2a6f5/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/98256a78627e834fd38f9ec635c560ef1be2a6f5/chrome/browser/android/shortcut_info.h
[modify] https://crrev.com/98256a78627e834fd38f9ec635c560ef1be2a6f5/chrome/browser/android/shortcut_info_unittest.cc

Comment 6 by piotrs@chromium.org, Dec 26 2017

Owner: ----
Status: Available (was: Started)
Unassigning myself, as I won't be able to finish this.

Here is my handoff doc, Googlers only, sorry:
https://docs.google.com/document/d/1rP-Q4sZXEJY2ICyHgoqJeS1omod43j_hl8vI2cNfQWo/edit
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 27

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment