Build fails for M61 debug binary |
|||||||
Issue description
Originally reported by lgcheng@:
On M61 release branch, Chrome for Chrome OS debug build is broken for the following error:
../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc:88:74: error: chosen constructor is explicit in copy-initialization
OnReadDirectoryOnUIThread(callback, base::File::FILE_ERROR_SECURITY, {});
^~
../../build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/debug/vector:79:7: note: explicit constructor declared here
vector(const _Allocator& __a = _Allocator())
^
../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc:40:57: note: passing argument to parameter 'files' here
std::vector<ArcDocumentsProviderRoot::ThinFileInfo> files) {
^
../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc:95:75: error: chosen constructor is explicit in copy-initialization
OnReadDirectoryOnUIThread(callback, base::File::FILE_ERROR_NOT_FOUND, {});
^~
../../build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/debug/vector:79:7: note: explicit constructor declared here
vector(const _Allocator& __a = _Allocator())
^
../../chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc:40:57: note: passing argument to parameter 'files' here
std::vector<ArcDocumentsProviderRoot::ThinFileInfo> files) {
Here is args.gn to reproduce:
target_os = "chromeos"
is_component_build = true
use_goma = true
is_debug = true
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5642080681119fd0c742dc67c64719ad9868c0a2 commit 5642080681119fd0c742dc67c64719ad9868c0a2 Author: Shuhei Takahashi <nya@chromium.org> Date: Tue Aug 29 04:23:11 2017 chromeos: Fix build on M61 release branch. Bug: 759922 Test: Builds on M61 release branch checkout Change-Id: I596d83d4c744b0b1a0090284cdc053c7dcc33ff4 Reviewed-on: https://chromium-review.googlesource.com/640033 Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#498022} [modify] https://crrev.com/5642080681119fd0c742dc67c64719ad9868c0a2/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc [modify] https://crrev.com/5642080681119fd0c742dc67c64719ad9868c0a2/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc [modify] https://crrev.com/5642080681119fd0c742dc67c64719ad9868c0a2/chrome/browser/chromeos/fileapi/recent_arc_media_source.cc
,
Aug 29 2017
,
Aug 29 2017
This bug requires manual review: We are only 6 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 29 2017
Note: Build succeeds on ToT, so regardless of whether this change is cherry-picked to M61 branch or not, I will revert the change on ToT later.
,
Aug 29 2017
Approving merge to M61.
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e394b4aa2d5aa0338a7654193e946eeeec1fa592 commit e394b4aa2d5aa0338a7654193e946eeeec1fa592 Author: Shuhei Takahashi <nya@chromium.org> Date: Tue Aug 29 16:17:18 2017 chromeos: Fix build on M61 release branch. TBR=nya@chromium.org (cherry picked from commit 5642080681119fd0c742dc67c64719ad9868c0a2) Bug: 759922 Test: Builds on M61 release branch checkout Change-Id: I596d83d4c744b0b1a0090284cdc053c7dcc33ff4 Reviewed-on: https://chromium-review.googlesource.com/640033 Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#498022} Reviewed-on: https://chromium-review.googlesource.com/641295 Reviewed-by: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#970} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/e394b4aa2d5aa0338a7654193e946eeeec1fa592/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc [modify] https://crrev.com/e394b4aa2d5aa0338a7654193e946eeeec1fa592/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc [modify] https://crrev.com/e394b4aa2d5aa0338a7654193e946eeeec1fa592/chrome/browser/chromeos/fileapi/recent_arc_media_source.cc
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9c317474b98bcf67b483f5f3552c377cec524dc commit c9c317474b98bcf67b483f5f3552c377cec524dc Author: Shuhei Takahashi <nya@chromium.org> Date: Tue Aug 29 16:18:57 2017 Revert "chromeos: Fix build on M61 release branch." This reverts commit 5642080681119fd0c742dc67c64719ad9868c0a2. Reason for revert: The fix has been cherry-picked to M61 release branch. Original change's description: > chromeos: Fix build on M61 release branch. > > Bug: 759922 > Test: Builds on M61 release branch checkout > Change-Id: I596d83d4c744b0b1a0090284cdc053c7dcc33ff4 > Reviewed-on: https://chromium-review.googlesource.com/640033 > Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Commit-Queue: Shuhei Takahashi <nya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#498022} TBR=mtomasz@chromium.org,hidehiko@chromium.org,nya@chromium.org Change-Id: I7e79bb8cbcff4707089883ae8682a88c336fe7cd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 759922 Reviewed-on: https://chromium-review.googlesource.com/641810 Reviewed-by: Shuhei Takahashi <nya@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#498130} [modify] https://crrev.com/c9c317474b98bcf67b483f5f3552c377cec524dc/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc [modify] https://crrev.com/c9c317474b98bcf67b483f5f3552c377cec524dc/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc [modify] https://crrev.com/c9c317474b98bcf67b483f5f3552c377cec524dc/chrome/browser/chromeos/fileapi/recent_arc_media_source.cc
,
Aug 29 2017
Cherry-picked to M61 release branch, and the patch on ToT was reverted.
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nya@chromium.org
, Aug 29 2017