New issue
Advanced search Search tips

Issue 759921 link

Starred by 1 user
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Sep 2017
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Failing CSS values WPT needs waitUntilDone

Project Member Reported by ericwilligers@chromium.org, Aug 29 2017 
external/wpt/css/css-values-3/vh_not_refreshing_on_chrome.html
doesn't wait until callbacks and transitions have completed.

If we waitUntilDone for 2.5s in the test and reference, the test passes.

The test could also read offsetTop (to force style recalc/layout) in a loop that updates height, instead of having many setTimeout callbacks.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1de4db070869cd5b1450258b94794d9015089e9d

commit 1de4db070869cd5b1450258b94794d9015089e9d
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Wed Aug 30 06:15:30 2017

Enable css-values-3 web platform tests

We now run the css-values-3 web platform tests,
skipping only those known to fail (see bugs).

BUG=246571, 421909 , 759914 , 759921 

Change-Id: I85db92c0249aa262e6aaa38afd2c3a53e1ec45cc
Reviewed-on: https://chromium-review.googlesource.com/640032
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498379}
[modify] https://crrev.com/1de4db070869cd5b1450258b94794d9015089e9d/third_party/WebKit/LayoutTests/NeverFixTests
[add] https://crrev.com/1de4db070869cd5b1450258b94794d9015089e9d/third_party/WebKit/LayoutTests/external/wpt/css/css-values-3/OWNERS
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c2c9f76f60c3fdd3de589af0d6930f71b3fb4ce

commit 8c2c9f76f60c3fdd3de589af0d6930f71b3fb4ce
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Fri Sep 01 03:30:22 2017

CSS: Enable vh_not_refreshing_on_chrome test

The web platform test was not waiting for the animations
to complete.

We now use reftest-wait, and only remove this class from
the document when properties have finished changing.

BUG= 759921 

Change-Id: Ied0d597b17da076ff50a18b9dd459ce91ae29af6
Reviewed-on: https://chromium-review.googlesource.com/644669
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499122}
[modify] https://crrev.com/8c2c9f76f60c3fdd3de589af0d6930f71b3fb4ce/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/8c2c9f76f60c3fdd3de589af0d6930f71b3fb4ce/third_party/WebKit/LayoutTests/external/wpt/css/css-values-3/reference/vh_not_refreshing_on_chrome-ref.html
[modify] https://crrev.com/8c2c9f76f60c3fdd3de589af0d6930f71b3fb4ce/third_party/WebKit/LayoutTests/external/wpt/css/css-values-3/reference/vh_not_refreshing_on_chrome_iframe-ref.html
[modify] https://crrev.com/8c2c9f76f60c3fdd3de589af0d6930f71b3fb4ce/third_party/WebKit/LayoutTests/external/wpt/css/css-values-3/support/vh_not_refreshing_on_chrome_iframe.html
[modify] https://crrev.com/8c2c9f76f60c3fdd3de589af0d6930f71b3fb4ce/third_party/WebKit/LayoutTests/external/wpt/css/css-values-3/vh_not_refreshing_on_chrome.html

Comment 3 by ericwilligers@chromium.org, Sep 1 2017

Status: Fixed (was: Started)
►

Sign in to add a comment