Use exact path matching for chrome://interstitials |
|||||
Issue descriptionRight now, the following both show the same as chrome://ssl : chrome://interstitials/ssllooww chrome://interstitials/ssl-superfish The first is a silly example, but the second could be misleading. It would be better to match the path (excluding query and fragment) exactly, like servers do. Found while reviewing crrev.com/c/639343
,
Sep 1 2017
Assigning to get out of triage queue.
,
Sep 10 2017
I'm going to take this as a starter bug for Carlos next week.
,
Sep 11 2017
,
Sep 11 2017
carlosil@ is taking this, but waiting till he gets his chromium account and edit bugs access before I can assign it to him.
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/347624883210ae4aa94bfc6b0c84e9faf5ecca2b commit 347624883210ae4aa94bfc6b0c84e9faf5ecca2b Author: Carlos IL <carlosil@google.com> Date: Tue Sep 12 20:01:59 2017 Interstitial URLs now use exact path matching URLs for manually opening chrome interstitials (chrome://interstitials/...) now use exact path matching instead of only checking that the first characters match (e.g. chrome://interstitials/ssl--invalid-- will not open chrome://interstitials/ssl). Added a test that verifies this change. R=estark@chromium.org Bug: 759915 Change-Id: I0d83709e54b83784c3f26a8d0511a77511d5fb63 Reviewed-on: https://chromium-review.googlesource.com/663204 Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Carlos Joan Rafael Ibarra Lopez <carlosil@google.com> Cr-Commit-Position: refs/heads/master@{#501370} [modify] https://crrev.com/347624883210ae4aa94bfc6b0c84e9faf5ecca2b/chrome/browser/ui/webui/interstitials/interstitial_ui.cc [modify] https://crrev.com/347624883210ae4aa94bfc6b0c84e9faf5ecca2b/chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc
,
Sep 12 2017
\o/ |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by lgar...@chromium.org
, Aug 29 2017