New issue
Advanced search Search tips

Issue 759909 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Move applist related functions in Shell to AppList

Project Member Reported by minch@chromium.org, Aug 29 2017

Issue description

Move app list related functions in Shell to /ui/app_list/presenter/app_list.h. eg. ShowAppList(*)

Only keep the getter app_list() in Shell
 

Comment 1 by minch@chromium.org, Aug 30 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4af35c13b726ee353f63b971464e11f87b1b874a

commit 4af35c13b726ee353f63b971464e11f87b1b874a
Author: MinChen <minch@chromium.org>
Date: Wed Sep 06 18:45:27 2017

Only keep the getter app_list() in Shell, remove all the other app list
related functions.

Changes,
1. Remove all the app list related functions in Shell, except the getter.
2. Updated the logic of Show() in AppListPresenterImpl.
If we have multiple displays, show the app list in the second display
when the app list is already opened in the first display should close
the app list in the first display. This is used to keep the behavior
consistency with AppListPresenterDelegate::OnGestureEvent, which will
dismiss the app list when there is one ET_GESTURE_TAP,
ET_GESTURE_TWO_FINGER_TAP or ET_GESTURE_LONG_PRESS be triggered.

Bug:  759909 
Test: ash_unittests
Change-Id: Ic4750802ebbbaea604de5fd3ffc3909cd1e7b956
Reviewed-on: https://chromium-review.googlesource.com/644724
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500021}
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/accelerators/accelerator_filter_unittest.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/accelerators/accelerator_router.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/shelf/app_list_button.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/shelf/app_list_shelf_item_delegate.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/shell.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/shell.h
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/shell/app_list.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/system/tray_drag_controller.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ui/app_list/presenter/app_list.cc
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ui/app_list/presenter/app_list.h
[modify] https://crrev.com/4af35c13b726ee353f63b971464e11f87b1b874a/ui/app_list/presenter/app_list_presenter_impl.cc

Comment 3 by minch@chromium.org, Sep 6 2017

Labels: M-62
Status: Fixed (was: Started)

Sign in to add a comment