New issue
Advanced search Search tips

Issue 759905 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Tests from MetricsCollectorTest are failing on Win7 dbg

Project Member Reported by tbansal@chromium.org, Aug 29 2017

Issue description

Build:
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62729

Failing tests:
MetricsCollectorTest.FromBackgroundedToFirstNonPersistentNotificationCreatedUMA5MinutesTimeout
MetricsCollectorTest.FromBackgroundedToFirstAudioStartsUMA5MinutesTimeout
MetricsCollectorTest.FromBackgroundedToFirstTitleUpdatedUMA5MinutesTimeout
MetricsCollectorTest.FromBackgroundedToFirstFaviconUpdatedUMA5MinutesTimeout
MetricsCollectorTest.FromBackgroundedToFirstTitleUpdatedUMA
MetricsCollectorTest.FromBackgroundedToFirstAudioStartsUMA
MetricsCollectorTest.FromBackgroundedToFirstNonPersistentNotificationCreatedUMA
MetricsCollectorTest.FromBackgroundedToFirstFaviconUpdatedUMA
MetricsCollectorTest.FromBackgroundedToFirstAlertFiredUMA5MinutesTimeout
MetricsCollectorTest.FromBackgroundedToFirstAlertFiredUMA


https://chromium-review.googlesource.com/c/chromium/src/+/627594 seeme suspicious.

 
Reverting the suspicious CL in https://chromium-review.googlesource.com/c/chromium/src/+/639851
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/882c1f822459b38b69332ad5370b1eff6d7e482c

commit 882c1f822459b38b69332ad5370b1eff6d7e482c
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Aug 29 00:52:42 2017

Speculatively revert "[GRC] Add heuristics UKM and refactor MetricsCollector."

This reverts commit e31b0b47faf7f774b7ad91d33b828218cc375c17.

Reason for speculative revert:
Suspected for breaking tests in build:
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62729


Original change's description:
> [GRC] Add heuristics UKM and refactor MetricsCollector.
> 
> This patch:
> 1. adds heuristics UKM;
> 2. rafactors MetricsCollector to unify background tabs metrics report;
> 3. moved metrics report 5-minutes timeout logic to MetricsCollector;
> 4. adds more unit tests.
> 
> BUG= 731270 , 753486
> 
> Change-Id: Ica08674bf6b95d88f8de571ef025a7eaf58515d7
> Reviewed-on: https://chromium-review.googlesource.com/627594
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: lpy <lpy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#497900}

TBR=dcheng@chromium.org,chrisha@chromium.org,holte@chromium.org,lpy@chromium.org

Change-Id: I40e09c00036adc133c5c4ab14e94aeea2bffe3e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  731270 , 753486, 759905
Reviewed-on: https://chromium-review.googlesource.com/639851
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497964}
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/BUILD.gn
[delete] https://crrev.com/dfb14c872c50f0a3728422c6243e560963aa0d06/services/resource_coordinator/coordination_unit/background_metrics_reporter.h
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/coordination_unit_impl.cc
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/coordination_unit_impl.h
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/metrics_collector.cc
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/metrics_collector.h
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/services/resource_coordinator/public/interfaces/signals.mojom
[modify] https://crrev.com/882c1f822459b38b69332ad5370b1eff6d7e482c/tools/metrics/ukm/ukm.xml

Comment 3 by l...@chromium.org, Aug 30 2017

Status: Fixed (was: Assigned)
Since it was reverted, I will mark this as fixed.

Comment 4 by l...@chromium.org, Aug 31 2017

Cc: chrisha@chromium.org
Labels: Hotlist-GRC
Status: Assigned (was: Fixed)
Summary: Tests from MetricsCollectorTest are failing on Win7 dbg (was: Tests from MetricsCollectorTest are failing)
reopened this bug.

I suspect that it is because the SimpleTestTickClock https://cs.chromium.org/chromium/src/base/test/simple_test_tick_clock.h is not advanced correctly on Win 7.

Will dig more once the windows 7 machine arrives.

Comment 5 by l...@chromium.org, Sep 5 2017

Labels: Hotlist-TooManyTabs

Comment 7 by l...@chromium.org, Jan 15 2018

Owner: ----
Status: Available (was: Assigned)
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment