New issue
Advanced search Search tips

Issue 759904 link

Starred by 1 user
Status: Fixed
Owner:
mahmadi@chromium.org
Closed: Sep 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

testNavigationByTappingReturn is broken on iOS11 iPad device.

Project Member Reported by gch...@chromium.org, Aug 29 2017 
SCPaymentEditorTestCase's testNavigationByTappingReturn (part of showcase egtests) is consistently broken on iOS11 iPad x64 device.

Here is a sample run: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad11-device-x64/builds/94

https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad11-device-x64/builds/94/steps/ios_showcase_egtests%20%28iPad%20Air%202%20iOS%2011.0%29%20on%20iOS-11.0/logs/SCPaymentsEditorTestCase%26%23x2f%3BtestNavigationByTappingReturn

Here is a copy of relevant logs:
SCPaymentsEditorTestCase/testNavigationByTappingReturn: 
2017-08-28 17:16:10.243 ios_showcase_egtests[4014:232220] Attempting to type key
.
2017-08-28 17:16:10.250 ios_showcase_egtests[4014:232220] Tapping on key: Next.
2017-08-28 17:16:12.789 ios_showcase_egtests[4014:232220] Attempting to type key
.
2017-08-28 17:16:12.791 ios_showcase_egtests[4014:232220] Tapping on key: Next.
../../ios/showcase/payments/sc_payments_editor_egtest.mm:60: error: -[SCPaymentsEditorTestCase testNavigationByTappingReturn] : Exception: TimeoutException

Exception Name: TimeoutException
Exception Reason: Couldn't assert that ([firstResponder isKindOfClass:[UITextField class]]) is true.
Exception Details: Timed out waiting for app to idle. {
  "Error Code" : "0",
  "App UI Hierarchy" : "========== Window 1 ==========
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f015eef9c978486160a0df8d98f6139abae200b

commit 4f015eef9c978486160a0df8d98f6139abae200b
Author: Gregory Chatzinoff <gchatz@chromium.org>
Date: Tue Aug 29 01:28:56 2017

Disable testNavigationByTappingReturn on iOS11 iPads.

Disables SCPaymentsEditorTestCase's testNavigationByTappingReturn
on iOS11 iPads because it is broken on device.

TBR=edchin

Bug:  759904 
Change-Id: Ice811c2b9bb59e54082196307ae8bc253771daa9
Reviewed-on: https://chromium-review.googlesource.com/639735
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497974}
[modify] https://crrev.com/4f015eef9c978486160a0df8d98f6139abae200b/ios/showcase/payments/sc_payments_editor_egtest.mm

Comment 2 by sczs@chromium.org, Aug 30 2017

Owner: mahmadi@chromium.org
Status: Assigned (was: Untriaged)
mahmadi@ could you PTAL.

Comment 3 by cma...@chromium.org, Aug 30 2017

Labels: -M-62 M-63
This should be blocking M63 instead, to give more time to mahmadi@ to work on this.

Comment 4 by cma...@chromium.org, Sep 15 2017 

mahmadi@ please update this bug

Comment 5 by mahmadi@chromium.org, Sep 18 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15b10725b21145a19e3f743a0fd013e115611bec

commit 15b10725b21145a19e3f743a0fd013e115611bec
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Tue Sep 26 16:22:38 2017

Fixes SCPaymentsEditorTestCase.testNavigationByTappingReturn

Bug:  759904 
Change-Id: I1a66f126cc2c47b76e1fdb2acbf9eeec61d96ea9
Reviewed-on: https://chromium-review.googlesource.com/677985
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504386}
[modify] https://crrev.com/15b10725b21145a19e3f743a0fd013e115611bec/ios/showcase/payments/sc_payments_editor_egtest.mm
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0aa3b52972b70225b76f6e0da61fbb0cf439366

commit b0aa3b52972b70225b76f6e0da61fbb0cf439366
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Sep 27 16:07:24 2017

Fix SCPaymentsEditorTestCase/testNavigationByTappingReturn

On iOS9, Next button is spelled "next".

Bug:  759904 
Change-Id: Ifa2d9048f8fec9354c9bda1f8d79a70c9d5078ec
Reviewed-on: https://chromium-review.googlesource.com/686818
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504691}
[modify] https://crrev.com/b0aa3b52972b70225b76f6e0da61fbb0cf439366/ios/showcase/payments/sc_payments_editor_egtest.mm

Comment 8 by mahmadi@chromium.org, Sep 27 2017

Status: Fixed (was: Started)

Comment 9 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled
Labels: Test-Disabled
►

Sign in to add a comment