New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 759899 link

Starred by 1 user
Status: Fixed
Owner:
ssid@chromium.org
Closed: Sep 2017
Cc:
primiano@chromium.org
█ hjd@chromium.org
█ picksi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Crash when running tracing

Project Member Reported by ssid@chromium.org, Aug 29 2017 
Background context: go/memory-infra

I ran tracing with some trace config and got this crash. I can't find the config anymore. Not a critical issue.
Maybe FinalizeGlobalMemoryDumpIfAllManagersReplied() is called on wrong thread sometimes?

[27959:27959:0828/171148.630198:FATAL:coordinator_impl.cc(281)] Check failed: false. No current dump request.
#0 0x7fccf4b563bd base::debug::StackTrace::StackTrace()
#1 0x7fccf4b5478c base::debug::StackTrace::StackTrace()
#2 0x7fccf4be4caa logging::LogMessage::~LogMessage()
#3 0x7fccee0a1b23 memory_instrumentation::CoordinatorImpl::PerformNextQueuedGlobalMemoryDump()
#4 0x7fccebbcfc7d _ZN4base8internal13FunctorTraitsIMN7content14NetworkContextEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_
#5 0x7fccebbcfbc4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content14NetworkContextEFvvEJPS5_EEEvOT_DpOT0_
#6 0x7fccee0b6c65 _ZN4base8internal7InvokerINS0_9BindStateIMN22memory_instrumentation15CoordinatorImplEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#7 0x7fccee0b6bac _ZN4base8internal7InvokerINS0_9BindStateIMN22memory_instrumentation15CoordinatorImplEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#8 0x7fccf4b01851 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv
#9 0x7fccf4b5b007 base::debug::TaskAnnotator::RunTask()
#10 0x7fccf4c0e893 base::MessageLoop::RunTask()
#11 0x7fccf4c0eb17 base::MessageLoop::DeferOrRunPendingTask()
#12 0x7fccf4c0f804 base::MessageLoop::DoWork()
#13 0x7fccf4c16cbc base::MessagePumpGlib::HandleDispatch()
#14 0x7fccf4c17461 base::(anonymous namespace)::WorkSourceDispatch()
#15 0x7fccdda13e04 g_main_context_dispatch

Comment 1 by ssid@chromium.org, Sep 7 2017

Cc: hjd@chromium.org
Owner: ssid@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c99b14d356a1b25cab8c365706f70c4df032e018

commit c99b14d356a1b25cab8c365706f70c4df032e018
Author: Siddhartha <ssid@chromium.org>
Date: Thu Sep 07 19:02:24 2017

Memory-infra: Do not remove queued requests before completion

When a process terminates, the next queued dump can be removed if no
requests are pending and the associated queued dump is already finished.

BUG= 759899 

Change-Id: I389216df7dfee557297af10091ccd4d953f1b2a2
Reviewed-on: https://chromium-review.googlesource.com/653850
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Hector Dearman <hjd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500352}
[modify] https://crrev.com/c99b14d356a1b25cab8c365706f70c4df032e018/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/c99b14d356a1b25cab8c365706f70c4df032e018/services/resource_coordinator/memory_instrumentation/coordinator_impl.h

Comment 3 by ssid@chromium.org, Sep 7 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment