New issue
Advanced search Search tips

Issue 759866 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 908611
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: ----



Sign in to add a comment

performance_browser_tests flaky on chromium.perf/Win 7 Intel GPU Perf

Project Member Reported by martiniss@chromium.org, Aug 28 2017

Issue description

performance_browser_tests flaky on chromium.perf/Win 7 Intel GPU Perf

Builders failed on: 
- Win 7 Intel GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20Intel%20GPU%20Perf

Example builds:
https://chromium-swarm.appspot.com/task?id=3834fc003b645710&refresh=10&show_raw=1
https://chromium-swarm.appspot.com/task?id=3832ebd2bb744010&refresh=10&show_raw=1
https://chromium-swarm.appspot.com/task?id=3841d3c9643f5510&refresh=10&show_raw=1

The test failing is "CastV2PerformanceTest.Performance/0". It's the first test run, might not be a bad test? I'm not sure.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9431c7d1bd1c040eb7a94152b5f846aee8afddde

commit 9431c7d1bd1c040eb7a94152b5f846aee8afddde
Author: Sami Kyostila <skyostil@chromium.org>
Date: Tue Oct 24 17:21:30 2017

perf: Disable flaky CastV2PerformanceTest on Windows

BUG= 759866 
TBR=miu@chromium.org

Change-Id: Ib6348be6ee26d88854bc02b58963c8a77f7c7cb7
Reviewed-on: https://chromium-review.googlesource.com/735353
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511190}
[modify] https://crrev.com/9431c7d1bd1c040eb7a94152b5f846aee8afddde/chrome/browser/extensions/api/cast_streaming/performance_test.cc

Comment 2 by m...@chromium.org, Oct 25 2017

I've been meaning to look into this, but have not had the chance. That said, all the other tests pass just fine, and we desperately need to keep this performance monitoring in-place right now. We have been landing replacement implementation for tab capture and need to know which CLs, if any, cause performance regressions.

Thus, I'm reverting the disable.

I'll put this at the top of my priority list. FWIW, the logs seems to indicate the first test is taking a very long time to start up; but it does start up. The problem is that the watchdog interrupts the test in the middle with a timeout once it finally does start running.

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9107561f33516cb764da2d59e30de08517f537bc

commit 9107561f33516cb764da2d59e30de08517f537bc
Author: Yuri Wiitala <miu@chromium.org>
Date: Wed Oct 25 03:10:19 2017

Revert "perf: Disable flaky CastV2PerformanceTest on Windows"

This reverts commit 9431c7d1bd1c040eb7a94152b5f846aee8afddde.

Reason for revert: We desperately need this performance monitoring and do not want to disable all 8 tests when only the first one is flaky (at a rate of 1 out of 5 runs). Further discussion in  crbug.com/759866 .

Original change's description:
> perf: Disable flaky CastV2PerformanceTest on Windows
> 
> BUG= 759866 
> TBR=miu@chromium.org
> 
> Change-Id: Ib6348be6ee26d88854bc02b58963c8a77f7c7cb7
> Reviewed-on: https://chromium-review.googlesource.com/735353
> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#511190}

TBR=miu@chromium.org,skyostil@chromium.org

Change-Id: I3627f6c850a744641d50a59c5dd2ebcda8ad98a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  759866 
Reviewed-on: https://chromium-review.googlesource.com/736655
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511339}
[modify] https://crrev.com/9107561f33516cb764da2d59e30de08517f537bc/chrome/browser/extensions/api/cast_streaming/performance_test.cc

Comment 4 by m...@chromium.org, Oct 25 2017

Labels: -Pri-2 M-64 Pri-1
Perhaps all we need to do to fix this is increase the watchdog timeout? I'll try changing the flags for that... Though, this would be a short-term fix. I'd like to understand why the test is taking so long to start up.

Comment 5 by m...@chromium.org, Oct 25 2017

Status: Started (was: Assigned)
Got a change to the command line in code review: https://chromium-review.googlesource.com/c/chromium/src/+/737370

It just occurred to me: These symptoms seem possibly related to bug 416072.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa998e1d021aae14a08ec427a57119e1578a0567

commit aa998e1d021aae14a08ec427a57119e1578a0567
Author: Yuri Wiitala <miu@chromium.org>
Date: Thu Oct 26 06:42:13 2017

Extend performance_browser_tests watchdog timeout to 2 minutes.

According to the perf bot builder logs, the first of 8 tests is flaky in
that it simply takes much longer to start up. This only happens in
approx. 1 out of 5 runs. When examining the build logs, it seems that
the test does start running successfully. However, because it took so
long to start up, the test launcher watchdog kills the test before it
finishes its 15-second performance sampling period.

As a short-term fix, I am increasing the watchdog timeout to eliminate
the flakes. In the long-term, I plan to revisit and try to figure out
whether this is a problem with the test, or an environmental issue
(i.e., it very much "smells" like it's related to crbug.com/416072).

Bug:  759866 
Change-Id: I00c8b476b62fade9e96958f037ed569ae76652e6
Reviewed-on: https://chromium-review.googlesource.com/737370
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511751}
[modify] https://crrev.com/aa998e1d021aae14a08ec427a57119e1578a0567/testing/buildbot/gn_isolate_map.pyl

Comment 7 by m...@chromium.org, Nov 3 2017

Cc: m...@chromium.org
 Issue 780883  has been merged into this issue.

Comment 8 by m...@chromium.org, Nov 3 2017

Interesting: The build logs from duplicate  bug 780883  indicate the first test runs now, still after taking about 15 seconds to launch and start the benchmark part of the test. With my fix (see comment 6), the benchmark now fully completes and outputs all the result data. However, after that, it still freezes permanently and the watchdog has to kill it.

I've just got my Windows machine set up again after my multi-moves; so, I'll try running locally and see what's up.

Paste of relevant log:

Command: c:\infra-system\bin\python.exe ..\..\testing\scripts\run_gtest_perf_test.py performance_browser_tests --test-launcher-print-test-stdio=always --test-launcher-timeout=120000 --gtest_filter=TabCapturePerformanceTest.*:CastV2PerformanceTest.* --test-launcher-jobs=1 --enable-gpu --isolated-script-test-output=c:\b\s\w\iooozouv\output.json --isolated-script-test-perf-output=c:\b\s\w\iooozouv\perftest-output.json
Running ['.\\performance_browser_tests.exe', '--test-launcher-print-test-stdio=always', '--test-launcher-timeout=120000', '--gtest_filter=TabCapturePerformanceTest.*:CastV2PerformanceTest.*', '--test-launcher-jobs=1', '--enable-gpu', '--verbose'] in None (env: {'TMP': 'C:\\Users\\CHROME~1\\AppData\\Local\\Temp', 'LC_NUMERIC': 'English_United States.UTF-8', 'COMPUTERNAME': 'BUILD166-M1', 'VS110COMNTOOLS': 'C:\\Program Files (x86)\\Microsoft Visual Studio 11.0\\Common7\\Tools\\', 'USERDOMAIN': 'GOLO', 'LC_CTYPE': 'English_United States.UTF-8', 'PSMODULEPATH': 'C:\\Windows\\system32\\WindowsPowerShell\\v1.0\\Modules\\', 'COMMONPROGRAMFILES': 'C:\\Program Files\\Common Files', 'PROCESSOR_IDENTIFIER': 'Intel64 Family 6 Model 60 Stepping 3, GenuineIntel', 'PROGRAMFILES': 'C:\\Program Files', 'PROCESSOR_REVISION': '3c03', 'HOME': 'c:\\Users\\chrome-bot', 'BOTO_CONFIG': 'c:\\Users\\chrome-bot\\.boto', 'PATH': 'C:\\ProgramData\\chocolatey\\bin;C:\\Windows\\system32;C:\\Windows;C:\\Windows\\System32\\Wbem;C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\;c:\\tools;c:\\b\\depot_tools;C:\\Program Files\\Microsoft SQL Server\\110\\Tools\\Binn\\;C:\\Program Files (x86)\\Windows Kits\\8.1\\Windows Performance Toolkit\\;C:\\Program Files (x86)\\Microsoft SDKs\\TypeScript\\1.0\\;C:\\Program Files (x86)\\QuickTime\\QTSystem\\;C:\\Program Files\\Puppet Labs\\Puppet\\bin', 'SWARMING_BOT_ID': 'build166-m1', 'PROGRAMFILES(X86)': 'C:\\Program Files (x86)', 'COMSPEC': 'C:\\Windows\\system32\\cmd.exe', 'LANG': 'en_US.UTF-8', 'SWARMING_SERVER': 'https://chromium-swarm.appspot.com', 'TEMP': 'c:\\b\\s\\w\\itfl_nx9', 'LC_MONETARY': 'English_United States.UTF-8', 'CHROME_DEVEL_SANDBOX': '/opt/chromium/chrome_sandbox', 'COMMONPROGRAMFILES(X86)': 'C:\\Program Files (x86)\\Common Files', 'PROCESSOR_ARCHITECTURE': 'AMD64', 'CHOCOLATEYINSTALL': 'C:\\ProgramData\\chocolatey', 'PATHEXT': '.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC', 'SWARMING_HEADLESS': '1', 'ALLUSERSPROFILE': 'C:\\ProgramData', 'LOCALAPPDATA': 'C:\\Users\\chrome-bot\\AppData\\Local', 'HOMEPATH': '\\Users\\chrome-bot', 'LUCI_CONTEXT': 'c:\\b\\s\\w\\itfl_nx9\\luci_ctx.w0vsl0.json', 'VS120COMNTOOLS': 'C:\\Program Files (x86)\\Microsoft Visual Studio 12.0\\Common7\\Tools\\', 'PROGRAMW6432': 'C:\\Program Files', 'USERNAME': 'chrome-bot', 'LOGONSERVER': '\\\\AD2', 'SYSTEMROOT': 'C:\\Windows', 'WINDOWS_TRACING_FLAGS': '3', 'PROGRAMDATA': 'C:\\ProgramData', 'SWARMING_TASK_ID': '399518f5f7c48c11', 'PROMPT': '$P$G', 'USERDNSDOMAIN': 'GOLO.CHROMIUM.ORG', 'NO_GCE_CHECK': 'False', 'SESSIONNAME': 'Console', 'LC_ALL': 'English_United States.UTF-8', 'LC_COLLATE': 'English_United States.UTF-8', 'FP_NO_HOST_CHECK': 'NO', 'WINDIR': 'C:\\Windows', 'GIT_USER_AGENT': 'git/2.10.0.windows.1 win32 build166-m1.golo.chromium.org', 'WINDOWS_TRACING_LOGFILE': 'C:\\BVTBin\\Tests\\installpackage\\csilogfile.log', 'HOMEDRIVE': 'C:', 'SYSTEMDRIVE': 'C:', 'NUMBER_OF_PROCESSORS': '8', 'APPDATA': 'C:\\Users\\chrome-bot\\AppData\\Roaming', 'PROCESSOR_LEVEL': '6', 'LC_TIME': 'English_United States.UTF-8', 'COMMONPROGRAMW6432': 'C:\\Program Files\\Common Files', 'OS': 'Windows_NT', 'PUBLIC': 'C:\\Users\\Public', 'USERPROFILE': 'C:\\Users\\chrome-bot'})
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = CastV2PerformanceTest.Performance/0
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from CastV2PerformanceTest
[ RUN      ] CastV2PerformanceTest.Performance/0
[5720:5716:1102/035949.410:ERROR:gpu_process_transport_factory.cc(1051)] Lost UI shared context.
[5720:5716:1102/035949.524:WARNING:chrome_browser_main_win.cc(613)] Command line too long for RegisterApplicationRestart:  --enable-gpu --gtest_also_run_disabled_tests --gtest_filter=CastV2PerformanceTest.Performance/0 --single_process --test-launcher-jobs=1 --test-launcher-output="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir4400_22810\results4400_5782\test_results.xml" --test-launcher-print-test-stdio=always --test-launcher-timeout=120000 --user-data-dir="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir4400_22810\d4400_26719" --verbose --disable-offline-auto-reload --allow-file-access-from-files --window-size=2000,1500 --whitelisted-extension-id=ddchlicdkolnonkihahngkmmmjnjlkkf --disable-renderer-backgrounding --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --force-color-profile=srgb --disable-features=NetworkPrediction --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[5720:5716:1102/040004.155:INFO:CONSOLE(57)] "Started tab capture.", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (57)
[5720:5716:1102/040004.160:INFO:CONSOLE(100)] "Started Cast Streaming.", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (100)
[5720:5716:1102/040004.161:INFO:CONSOLE(114)] "Running test for 15000 ms.", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance.js (114)
[5720:3464:1102/040004.207:ERROR:audio_manager_base.cc(316)] Invalid audio output parameters received; using fake audio path. Channels: 0, Sample Rate: 0, Bits Per Sample: 0, Frames Per Buffer: 0
Still waiting for the following processes to finish:
	".\performance_browser_tests.exe" --enable-gpu --gtest_also_run_disabled_tests --gtest_filter=CastV2PerformanceTest.Performance/0 --single_process --test-launcher-jobs=1 --test-launcher-output="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir4400_22810\results4400_5782\test_results.xml" --test-launcher-print-test-stdio=always --test-launcher-timeout=120000 --user-data-dir="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir4400_22810\d4400_26719" --verbose
[5720:5716:1102/040019.162:INFO:user_input_monitor_win.cc(157)] RegisterRawInputDevices() failed for RIDEV_REMOVE: The parameter is incorrect. (0x57)
[5720:3464:1102/040019.162:ERROR:audio_manager_base.cc(316)] Invalid audio output parameters received; using fake audio path. Channels: 0, Sample Rate: 0, Bits Per Sample: 0, Frames Per Buffer: 0
[5720:5716:1102/040019.163:INFO:CONSOLE(0)] "[SUCCESS] sendTestPatterns", source: chrome-extension://ddchlicdkolnonkihahngkmmmjnjlkkf/performance24.html?port=51685&autoThrottling=false&aesKey=000102030405060708090A0B0C0D0E0F&aesIvMask=0F0E0D0C0B0A09080706050403020100 (0)
[5720:5716:1102/040019.205:INFO:performance_test.cc(448)] Retrieved 360 events for: Capture
*RESULT CastV2Performance_gpu_24fps: time_between_captures= {41.635315,8.686362} ms
*RESULT CastV2Performance_gpu_24fps: av_sync= {37.834790,3.831934} ms
[5720:5716:1102/040019.205:INFO:performance_test.cc(193)] Jitter analysis on 1491 values.
*RESULT CastV2Performance_gpu_24fps: audio_jitter= {0.000106,0.000307} ms
[5720:5716:1102/040019.205:INFO:performance_test.cc(193)] Jitter analysis on 358 values.
*RESULT CastV2Performance_gpu_24fps: video_jitter= {0.818803,2.506347} ms
*RESULT CastV2Performance_gpu_24fps: playout_resolution= {1080.000000,0.000000} lines
*RESULT CastV2Performance_gpu_24fps: resolution_changes= 1 count
[5720:5716:1102/040019.205:INFO:performance_test.cc(448)] Retrieved 360 events for: Capture
[5720:5716:1102/040019.206:INFO:performance_test.cc(448)] Retrieved 360 events for: OnBufferReceived
[5720:5716:1102/040019.207:INFO:performance_test.cc(448)] Retrieved 360 events for: ConsumeVideoFrame
[5720:5716:1102/040019.208:INFO:performance_test.cc(448)] Retrieved 360 events for: InsertRawVideoFrame
[5720:5716:1102/040019.209:INFO:performance_test.cc(448)] Retrieved 360 events for: VideoFrameEncoded
[5720:5716:1102/040019.210:INFO:performance_test.cc(448)] Retrieved 360 events for: PullEncodedVideoFrame
[5720:5716:1102/040019.210:INFO:performance_test.cc(448)] Retrieved 360 events for: VideoFrameDecoded
[5720:5716:1102/040019.211:INFO:performance_test.cc(448)] Retrieved 360 events for: VideoFramePlayout
*RESULT CastV2Performance_gpu_24fps: frame_drop_rate= 0.000000 percent
*RESULT CastV2Performance_gpu_24fps: total_latency= {31.738058,1.942158} ms
*RESULT CastV2Performance_gpu_24fps: capture_duration= {13.785545,1.702834} ms
*RESULT CastV2Performance_gpu_24fps: send_to_renderer= {0.136651,0.025557} ms
*RESULT CastV2Performance_gpu_24fps: encode= {6.162692,0.244941} ms
*RESULT CastV2Performance_gpu_24fps: transmit= {0.420029,0.075076} ms
*RESULT CastV2Performance_gpu_24fps: decode= {11.224731,0.688950} ms
*RESULT CastV2Performance_gpu_24fps: cast_latency= {17.815862,0.757545} ms
[5720:5716:1102/040019.281:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
Still waiting for the following processes to finish:
	".\performance_browser_tests.exe" --enable-gpu --gtest_also_run_disabled_tests --gtest_filter=CastV2PerformanceTest.Performance/0 --single_process --test-launcher-jobs=1 --test-launcher-output="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir4400_22810\results4400_5782\test_results.xml" --test-launcher-print-test-stdio=always --test-launcher-timeout=120000 --user-data-dir="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir4400_22810\d4400_26719" --verbose
[1/19] CastV2PerformanceTest.Performance/0 (TIMED OUT)

Comment 9 by m...@chromium.org, Feb 1 2018

Components: Internals>Media>Capture

Comment 10 by m...@chromium.org, Feb 7 2018

Components: Internals>Media>ScreenCapture

Comment 11 by m...@chromium.org, Feb 7 2018

Components: -Internals>Media>Capture

Comment 12 by m...@chromium.org, Feb 7 2018

Labels: -Pri-1 Pri-2
Components: Tests>Flaky
Mergedinto: 908611
Status: Duplicate (was: Started)

Sign in to add a comment