New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759860 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Enable SearchResultListViewTest and SearchResultPageViewTest for fullscreen launcher

Project Member Reported by warx@chromium.org, Aug 28 2017

Issue description

This CL is preparation for  issue 758737 , we would better have SearchBoxView constructed for the tests. Thus, inside these tests, app_list_view_ is created for testing.

We can also remove SearchResultListViewDelegate.
 

Comment 1 by warx@chromium.org, Aug 28 2017

Blocking: 759779
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00

commit 2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00
Author: Qiang Xu <warx@chromium.org>
Date: Thu Aug 31 20:17:40 2017

app_list: Enable SearchResultListViewTest and SearchResultPageViewTest for
fullscreen launcher

changes:
- remove SearchResultListViewDelegate.
- Enable SearchResultListViewTest and SearchResultPageViewTest for new
launcher.

Test: covered by tests.
Bug:  759860 
Change-Id: Ie8630b8df960cc62925fcfcb105fcc82b265dbca
Reviewed-on: https://chromium-review.googlesource.com/638443
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498973}
[modify] https://crrev.com/2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00/ui/app_list/BUILD.gn
[modify] https://crrev.com/2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00/ui/app_list/views/app_list_main_view.cc
[modify] https://crrev.com/2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00/ui/app_list/views/app_list_main_view.h
[modify] https://crrev.com/2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00/ui/app_list/views/contents_view.cc
[modify] https://crrev.com/2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00/ui/app_list/views/contents_view.h
[modify] https://crrev.com/2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00/ui/app_list/views/search_result_answer_card_view_unittest.cc
[modify] https://crrev.com/2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00/ui/app_list/views/search_result_list_view.cc
[modify] https://crrev.com/2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00/ui/app_list/views/search_result_list_view.h
[delete] https://crrev.com/cf1c597e7a016c4d05e68059bd968403e7850516/ui/app_list/views/search_result_list_view_delegate.h
[modify] https://crrev.com/2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00/ui/app_list/views/search_result_list_view_unittest.cc
[modify] https://crrev.com/2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00/ui/app_list/views/search_result_page_view_unittest.cc
[modify] https://crrev.com/2539a5cf3b68ebd17e5d656f350b83cc5c1c8c00/ui/app_list/views/search_result_tile_item_list_view_unittest.cc

Comment 3 by warx@chromium.org, Aug 31 2017

Cc: vadimt@chromium.org
This CL is aimed at tests. Should be safe to be merged to m61 if we want.

Comment 4 by vadimt@chromium.org, Aug 31 2017

Maybe, not.
It's just a test, with a non-empty "main code" change. I'd suggest not merging it.

Comment 5 by warx@chromium.org, Aug 31 2017

Labels: -M-61
Status: Fixed (was: Assigned)
OK!

Comment 6 by vadimt@chromium.org, Oct 17 2017

Blocking: -759779

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment