Access to Machine Provider UI should be permitted to non-admins |
||||||
Issue descriptionAccess to Machine Provider UI is currently protected by auth.is_admin (https://chromium.googlesource.com/infra/luci/luci-py/+/master/appengine/machine_provider/handlers_frontend.py#27), which is mdb/chrome-troopers on prod. That means nobody from Fuchsia can access the UI to see the machine catalog or lease requests, which is really needed once we migrate to MP. Ideally, the UI access should be governed by auth service so granting access to the UI doesn't require adding Fuchsia developers to mdb/chrome-troopers.
,
Aug 29 2017
,
Aug 29
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 30
This sounds like a useful feature request.
,
Aug 30
,
Aug 30
The UI isn't very useful, which is why I haven't granted access to anyone that isn't in the administrators group on chrome-infra-auth.
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/c7e126890e1c3da72fc0ae49a379945137129d3d commit c7e126890e1c3da72fc0ae49a379945137129d3d Author: smut <smut@google.com> Date: Thu Aug 30 22:51:40 2018 [Machine Provider] Create dedicated catalog viewer group Also made minor UI changes: Disabled suggestion to login in favor of installing a login redirect. Updated LUCI URLs from github.com to chromium.googlesource.com. Bug: 759852 Change-Id: Ifc449b87f254baedda46cf213a336b1bf45afa0c Reviewed-on: https://chromium-review.googlesource.com/1197746 Commit-Queue: smut <smut@google.com> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/c7e126890e1c3da72fc0ae49a379945137129d3d/appengine/machine_provider/acl.py [modify] https://crrev.com/c7e126890e1c3da72fc0ae49a379945137129d3d/appengine/machine_provider/handlers_frontend.py [modify] https://crrev.com/c7e126890e1c3da72fc0ae49a379945137129d3d/appengine/machine_provider/templates/root.html |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by no...@chromium.org
, Aug 29 2017