New issue
Advanced search Search tips

Issue 759851 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"Shut down gracefully" button on bot ui page incorrectly fills "user:" field

Project Member Reported by bpastene@chromium.org, Aug 28 2017

Issue description

For example: https://chromium-swarm.appspot.com/task?id=3843ae1a782f2810

Under details, it shows "user:user:bpastene@google.com"

I think that's one too many "user:" strings?
 

Comment 1 by no...@chromium.org, Aug 29 2017

Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)

Comment 2 by mar...@chromium.org, Aug 29 2017

Yep it's very user: friendly. :)

Comment 3 by kjlubick@google.com, Aug 29 2017

This seems to be due to 
https://chromium.googlesource.com/infra/luci/luci-py/+/master/appengine/swarming/server/task_request.py#780

Which calls to https://chromium.googlesource.com/infra/luci/luci-py/+/master/client/auth.py#44

Is it sensible enough to split the string at ":" and take the second part?

Or should the fix handle the possibility of a bot:something

Comment 4 by mar...@chromium.org, Aug 29 2017

Humm I'd say in this case user should probably be None. It's not meant to be an authenticated account.

Comment 5 by mar...@chromium.org, Aug 29 2017

Owner: mar...@chromium.org
Status: Assigned (was: Available)
I can take it, it's trivial.

Comment 6 by kjlubick@google.com, Aug 29 2017

I do like to see who shut down the bots, so I can ask them why or be aware of the fact.

Comment 7 by kjlubick@google.com, Aug 29 2017

But maybe user: is not the appropriate way to send that info.

Comment 8 by mar...@chromium.org, Aug 29 2017

The authenticated tag is already there.

There's no automatic tag yet for authenticated user, you'd like one?

Comment 9 by kjlubick@google.com, Aug 29 2017

Never mind, I missed Authenticated, which is totally fine.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/142222728b572da798b7b9e60650e997785d4238

commit 142222728b572da798b7b9e60650e997785d4238
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Tue Aug 29 19:58:35 2017

Trim user from termination task

The authenticated user is not meant to be copied to the user field.

R=kjlubick@chromium.org
Bug:759851
Change-Id: I9349503093b855896842ab0e8c2ac6244899fcb7
Reviewed-on: https://chromium-review.googlesource.com/642117
Reviewed-by: Kevin Lubick <kjlubick@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/142222728b572da798b7b9e60650e997785d4238/appengine/swarming/server/task_request.py

Status: Fixed (was: Assigned)
Live on prod

Sign in to add a comment