"Shut down gracefully" button on bot ui page incorrectly fills "user:" field |
|||
Issue descriptionFor example: https://chromium-swarm.appspot.com/task?id=3843ae1a782f2810 Under details, it shows "user:user:bpastene@google.com" I think that's one too many "user:" strings?
,
Aug 29 2017
Yep it's very user: friendly. :)
,
Aug 29 2017
This seems to be due to https://chromium.googlesource.com/infra/luci/luci-py/+/master/appengine/swarming/server/task_request.py#780 Which calls to https://chromium.googlesource.com/infra/luci/luci-py/+/master/client/auth.py#44 Is it sensible enough to split the string at ":" and take the second part? Or should the fix handle the possibility of a bot:something
,
Aug 29 2017
Humm I'd say in this case user should probably be None. It's not meant to be an authenticated account.
,
Aug 29 2017
I can take it, it's trivial.
,
Aug 29 2017
I do like to see who shut down the bots, so I can ask them why or be aware of the fact.
,
Aug 29 2017
But maybe user: is not the appropriate way to send that info.
,
Aug 29 2017
The authenticated tag is already there. There's no automatic tag yet for authenticated user, you'd like one?
,
Aug 29 2017
Never mind, I missed Authenticated, which is totally fine.
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/142222728b572da798b7b9e60650e997785d4238 commit 142222728b572da798b7b9e60650e997785d4238 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Tue Aug 29 19:58:35 2017 Trim user from termination task The authenticated user is not meant to be copied to the user field. R=kjlubick@chromium.org Bug:759851 Change-Id: I9349503093b855896842ab0e8c2ac6244899fcb7 Reviewed-on: https://chromium-review.googlesource.com/642117 Reviewed-by: Kevin Lubick <kjlubick@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/142222728b572da798b7b9e60650e997785d4238/appengine/swarming/server/task_request.py
,
Aug 30 2017
Live on prod |
|||
►
Sign in to add a comment |
|||
Comment 1 by no...@chromium.org
, Aug 29 2017Status: Available (was: Untriaged)