Make audit app file monorail bugs when a violation is detected. |
|||||
Issue descriptionAs discussed with the infra team: Inside the transaction that updates the datastore to save the results of auditing each commit, also create taskqueue tasks that will file bugs to monorail. Note that up to 25 of these tasks can be created by a single transaction. These tasks should - Create a bug for the commit violation if one doesn't already exist. - Point the appropriate datastore entity to the bug.
,
Sep 6 2017
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/db69fd8be468686c632e0d71bd29ab19e9bb2f6b commit db69fd8be468686c632e0d71bd29ab19e9bb2f6b Author: Roberto Carrillo <robertocn@google.com> Date: Fri Sep 08 21:43:29 2017 [cr-audit-commits] Monorail connectivity check Adding a test to the smoke test page to check if we can connect to monorail. R=stgao,chanli,iannucci Bug:759841 Change-Id: I417c76bdb2e351587685e2a604380b2c61e360e2 Reviewed-on: https://chromium-review.googlesource.com/651350 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> [modify] https://crrev.com/db69fd8be468686c632e0d71bd29ab19e9bb2f6b/go/src/infra/appengine/cr-audit-commits/app/utils.go [modify] https://crrev.com/db69fd8be468686c632e0d71bd29ab19e9bb2f6b/go/src/infra/appengine/cr-audit-commits/app/smoke.go
,
Sep 12 2017
,
Sep 18 2017
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/6d8df7fb4f385e72bcf2d1868537c0d6cd68bf50 commit 6d8df7fb4f385e72bcf2d1868537c0d6cd68bf50 Author: Roberto Carrillo <robertocn@google.com> Date: Tue Sep 19 00:16:15 2017 [cr-audit-commits] Use monorail to file bugs when violations are detected. The new handler ViolationNotifier queries the datastore for relevant commits that have their status as auditCompletedWithViolation but have an IssueID equal to 0 (indicating that no bug has been filed for that CL), to avoid duplication before filing a bug, we check that a bug with the same subject doesn't already exist. R=chanli,stgao Bug:759841 Change-Id: I2e10ca7b688ef50895706ca208a9ac7822813f03 Reviewed-on: https://chromium-review.googlesource.com/656340 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Chan Li <chanli@chromium.org> [modify] https://crrev.com/6d8df7fb4f385e72bcf2d1868537c0d6cd68bf50/go/src/infra/appengine/cr-audit-commits/app/utils.go [modify] https://crrev.com/6d8df7fb4f385e72bcf2d1868537c0d6cd68bf50/go/src/infra/appengine/cr-audit-commits/app/commit_scanner.go [modify] https://crrev.com/6d8df7fb4f385e72bcf2d1868537c0d6cd68bf50/go/src/infra/appengine/cr-audit-commits/app/test_utils.go [modify] https://crrev.com/6d8df7fb4f385e72bcf2d1868537c0d6cd68bf50/go/src/infra/appengine/cr-audit-commits/app/rules_config.go [add] https://crrev.com/6d8df7fb4f385e72bcf2d1868537c0d6cd68bf50/go/src/infra/appengine/cr-audit-commits/app/notifier_test.go [modify] https://crrev.com/6d8df7fb4f385e72bcf2d1868537c0d6cd68bf50/go/src/infra/appengine/cr-audit-commits/app/commit_auditor.go [add] https://crrev.com/6d8df7fb4f385e72bcf2d1868537c0d6cd68bf50/go/src/infra/appengine/cr-audit-commits/app/notifier.go [modify] https://crrev.com/6d8df7fb4f385e72bcf2d1868537c0d6cd68bf50/go/src/infra/appengine/cr-audit-commits/app/model.go
,
Sep 19 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by robert...@chromium.org
, Aug 28 2017Status: Assigned (was: Untriaged)