New issue
Advanced search Search tips

Issue 759818 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Try to drop the symlink from chromeos-firmware-kahlee to the master configuration

Project Member Reported by sjg@chromium.org, Aug 28 2017

Issue description

There is a symlink to model.dtsi which we should try to drop.

We should be able to find the configuration another way

 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3a9ebbb9bafea0aaeb240f42628bf08a6f12ce15

commit 3a9ebbb9bafea0aaeb240f42628bf08a6f12ce15
Author: Simon Glass <sjg@chromium.org>
Date: Sat Sep 09 00:36:17 2017

cros-unibuild: Avoid needing a model.dtsi symlink

The master configuration is always installed by an ebuild called
chromeos-config-bsp. Adjust the implementation of get_dtb() to take
advantage of this. It is only called from ebuilds in the same overlay
and at the the same level.

BUG= chromium:759818 
TEST=emerge-coral chromeos-firmware-coral

Change-Id: I652301c9fd697efc77d110b7ad59c8055caab16f
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/657267
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/3a9ebbb9bafea0aaeb240f42628bf08a6f12ce15/eclass/cros-unibuild.eclass

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 9 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 9 2017

Comment 5 by sjg@chromium.org, Sep 18 2017

Status: Fixed (was: Assigned)
This has been droped
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 19 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 19 2017

Sign in to add a comment