New issue
Advanced search Search tips

Issue 759802 link

Starred by 1 user
Status: Duplicate
Merged: issue 633572
Owner: ----
Closed: Aug 2017
Cc:
aga...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Bug


Previous locations:
gerrit:7108


Sign in to add a comment

git cl upload -c --tbrs foo@chromium.org --send-mail doesn't result in CQ

Project Member Reported by gab@chromium.org, Aug 28 2017 
This happened to me (again) @ https://chromium-review.googlesource.com/c/chromium/src/+/639231.

1) git cl upload -c --tbrs foo@chromium.org --send-mail

Expected:
Uploads, sets TBR, sends email, CQs.

Actual:
Uploads, CQs (commit queue +2), sets TBR, sends email.

Setting the TBR after the CQ+2 changes the CL description which in turn cancels the CQ request (pretty sure that's what is happening, see message log on the reference CL).

Comment 1 by jrn@google.com, Aug 28 2017

Owner: aga...@chromium.org
This appears to be a "git cl" issue. How do I move this to the chromium issue tracker?

Comment 2 by aga...@chromium.org, Aug 28 2017 

(You move issues with the "more actions" dropdown in the lower right of the edit area.)

Comment 3 by aga...@chromium.org, Aug 28 2017

Project: chromium
Moved issue gerrit:7108 to now be  issue chromium:759802 .

Comment 4 by aga...@chromium.org, Aug 28 2017

Cc: aga...@chromium.org
Components: Infra>SDK
Labels: -Priority-3 Proj-Gerrit-Migration
Mergedinto: 633572
Owner: ----
Status: Duplicate (was: New)
It's not the --tbrs which creates the new patchset. It's a PRESUBMIT.py post-upload hook which modifies the commit description to include the Cq-Include-Trybots line.
►

Sign in to add a comment