New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759800 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 753158
issue 759774



Sign in to add a comment

Implement cron job to scan the git log periodically and schedule audits.

Project Member Reported by robert...@chromium.org, Aug 28 2017

Issue description

This handler should periodically get the log from the latest known commit and schedule audits for those commits that are of interest to the audit app (those that are either authored or committed by a monitored account)
 
Blocking: 753158 759774
Status: Started (was: Untriaged)
Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/507e6c2a6a90c130c74752cc2b6bc46a025d53a7

commit 507e6c2a6a90c130c74752cc2b6bc46a025d53a7
Author: Roberto Carrillo <robertocn@google.com>
Date: Fri Sep 08 00:25:22 2017

[cr-audit-app] Make clients mockable and tests for commit scanner.

The change allows tests to mock the gitiles and gerrit clients by providing
interfaces for them that tests can use to inject fake clients.

Also implement unittests for commit scanner handler.

R=iannucci,stgao,chanli
Bug:  759800 
Change-Id: Id97c67ed29757d660db20f342e442ead8f445ba8
Reviewed-on: https://chromium-review.googlesource.com/648638
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/507e6c2a6a90c130c74752cc2b6bc46a025d53a7/go/src/infra/appengine/cr-audit-commits/app/commit_scanner.go
[modify] https://crrev.com/507e6c2a6a90c130c74752cc2b6bc46a025d53a7/go/src/infra/appengine/cr-audit-commits/app/rules_config.go
[modify] https://crrev.com/507e6c2a6a90c130c74752cc2b6bc46a025d53a7/go/src/infra/appengine/cr-audit-commits/app/commit_auditor.go
[modify] https://crrev.com/507e6c2a6a90c130c74752cc2b6bc46a025d53a7/go/src/infra/appengine/cr-audit-commits/app/model.go
[add] https://crrev.com/507e6c2a6a90c130c74752cc2b6bc46a025d53a7/go/src/infra/appengine/cr-audit-commits/app/commit_scanner_test.go
[modify] https://crrev.com/507e6c2a6a90c130c74752cc2b6bc46a025d53a7/go/src/infra/appengine/cr-audit-commits/app/utils.go

Sign in to add a comment