New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 759790 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[ARC++ optin] Some of the re-skin changes to Google Play terms of service, is still not present.

Project Member Reported by mkarkada@chromium.org, Aug 28 2017

Issue description

Chrome OS version: 9765.45.0, 61.0.3163.67 dev build
Tested on M-61 dev channel caroline device.

This issue is related to launch bug Issue 746569
Steps to reproduce the problem:

1. During ARC++ opt-in for device owner as well as non- device owner. 
2. On Google Play terms of service page, click on the 'Learn more' links for Diagnostic and usage data, back and Restore data, Location services data
3. You see a dialog box open up. In each of the cases, the Header/ Title is missing.

Expected behavior:
As per attachments Expected_1.png/ Expected_2.png: needs to be shown with the Title.

Actual behavior:
Title is missing and just the content is shown.

Please refer the attachments.

 
Expected_1.png
266 KB View Download
Expected_2.png
255 KB View Download
Actual_1.png
1.5 MB View Download
Sorry, this issue was seen on Chrome OS version: 9765.45.0, 61.0.3163.67 beta build (not dev).
One more issue to report:

When dialog box opens up for Diagnostic, Back up and Location data, background should turn to black screen. I still see it as a white background. I believe this background color change should be fixed.

Comment 3 by lgcheng@google.com, Aug 29 2017

Cc: elizabethchiu@chromium.org
This behavior is currently shared with opt-in and oobe opt-in (No Header/title text in popup dialog background dim).

Add elizabethchiu@ to see we need fix this together. 
This issue still not fixed on M-61 beta build (9765.61.0/61.0.3163.87). Checked on eve.
During OOBE, when clicked on Google TOS and Google Privacy policy links, the pages  looked as per the attachments. The entire desktop background turned to white. 

Checked on M-61 beta build (9765.63.0/61.0.3163.90)
IMG_1660.jpg
1.9 MB View Download
IMG_1659.jpg
1.6 MB View Download

Comment 6 by lgcheng@google.com, Sep 14 2017

Re #5

OOBE opt-in is a fullscreen page with OOBE dialog in center while opt-in is a windowed Chrome app(can be moved around).

I think the mock was made with OOBE when opt-in reskin was not done yet. You can also see the "X" on the right top was also not available in the mock.
@Igcheng, thank you for the clarification. 
So, looking at the issue in #5, I believe only the background color needs to be fixed (i.e. to black background). 
I also see wallpaper loaded in the background. Is this expected one?

I believe 'X' button is expected (from the main bug discussions). Please confirm?

Thank you!

Comment 8 by lgcheng@google.com, Sep 15 2017

-wallpaper loaded in the background.
I think it's expected. 

-I believe 'X' button is expected (from the main bug discussions).
Yes.

Comment 9 Deleted

Comment 10 Deleted

1. The background should be dimmed. 
2. Adding the title back to the dialog and the close button.

We should have existing dialog components, or do we need additional spec for this?
Owner: mkarkada@chromium.org
Labels: -M-61 M-68
Owner: lgcheng@google.com
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment