[ARC++ optin] New UI for Playstore notification is still not available. |
||||||||
Issue descriptionChrome OS version: 9765.45.0, 61.0.3163.67 dev build Tested on M-61 dev channel caroline device. This issue is related to launch bug Issue 746569 Steps to reproduce the problem: 1. Perform ARC++ opt-in for device owner as well as non- device owner. 2. A playstore notification pops up. Expected behavior: Re-skinned version of playstore notification should pop up. (As per attachment Expected.png) Actual behavior: Old version of playstore notification is seen. Please refer the attachments.
,
Aug 29 2017
,
Aug 29 2017
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b06652e467efe04345c57edfad923cf8fb7cf9aa commit b06652e467efe04345c57edfad923cf8fb7cf9aa Author: lgcheng <lgcheng@google.com> Date: Wed Aug 30 20:27:06 2017 arc optin notification new icon. Bug: 759787 Test: Manual Change-Id: I8bb22b3aff2500b8b09368bb1f227934084bbdc7 Reviewed-on: https://chromium-review.googlesource.com/641856 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#498590} [modify] https://crrev.com/b06652e467efe04345c57edfad923cf8fb7cf9aa/chrome/app/theme/default_100_percent/cros/notification_play_store.png [modify] https://crrev.com/b06652e467efe04345c57edfad923cf8fb7cf9aa/chrome/app/theme/default_200_percent/cros/notification_play_store.png
,
Aug 30 2017
New Icon is in ToT. This cl should be safe to merge as only changes the notification icon. Apply to merge to M61. If not approved for merge, please punt to later milestone. Thanks
,
Aug 30 2017
This bug requires manual review: We are only 5 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 30 2017
Approving merge to M61.
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96443f1b03f100e64d64db8a6fad2442d33f2451 commit 96443f1b03f100e64d64db8a6fad2442d33f2451 Author: lgcheng <lgcheng@google.com> Date: Wed Aug 30 23:39:17 2017 [Merge M61]arc optin notification new icon. TBR=oshima@chromium.org Bug: 759787 Test: Manual Change-Id: I8bb22b3aff2500b8b09368bb1f227934084bbdc7 Reviewed-on: https://chromium-review.googlesource.com/641856 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Original-Commit-Position: refs/heads/master@{#498590}(cherry picked from commit b06652e467efe04345c57edfad923cf8fb7cf9aa) Reviewed-on: https://chromium-review.googlesource.com/644154 Reviewed-by: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/branch-heads/3163@{#1017} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/96443f1b03f100e64d64db8a6fad2442d33f2451/chrome/app/theme/default_100_percent/cros/notification_play_store.png [modify] https://crrev.com/96443f1b03f100e64d64db8a6fad2442d33f2451/chrome/app/theme/default_200_percent/cros/notification_play_store.png
,
Sep 8 2017
Verified on Chrome OS: 9765.53.0, 61.0.3163.80 beta build. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mkarkada@chromium.org
, Aug 28 2017